dillon1000/react

Commit

Fix a crash when using dynamic children in <option> tag (#13261)

* Make option children a text content by default

fix #11911

* Apply requested changes

- Remove meaningless comments
- revert scripts/rollup/results.json

* remove empty row

* Update comment

* Add a simple unit-test

* [WIP: no flow] Pass through hostContext

* [WIP: no flow] Give better description for test

* Fixes

* Don't pass hostContext through

It ended up being more complicated than I thought.

* Also warn on hydration
Browse files
Konstantin Yakushin authored 0182a74632b66a226921ca13dcfe359c67e15c6f Parent 2a2ef7e
Changed paths7 files
First-parent comparison
M fixtures/dom/src/components/fixtures/selects/index.js ModifiedM packages/react-dom/src/__tests__/ReactDOMOption-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMSelect-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerIntegrationForms-test.js ModifiedM packages/react-dom/src/__tests__/utils/ReactDOMServerIntegrationTestUtils.js ModifiedM packages/react-dom/src/client/ReactDOMFiberOption.js ModifiedM packages/react-dom/src/client/ReactDOMHostConfig.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…