{"files":[{"status":"M","path":"src\/browser\/ui\/dom\/components\/__tests__\/ReactDOMInput-test.js"}],"commit":{"shortRevision":"089146b2f8","revision":"089146b2f8086e78ec94ed527306fb36efd67c30","authorName":"Jan Kassens","authoredAt":"2014-04-21T15:41:09-07:00","authorEmail":"jkassens@fb.com","subject":"fix log spew from ReactDOMInput test"},"patch":"diff --git a\/src\/browser\/ui\/dom\/components\/__tests__\/ReactDOMInput-test.js b\/src\/browser\/ui\/dom\/components\/__tests__\/ReactDOMInput-test.js\nindex 4657459c32..45b2df4115 100644\n--- a\/src\/browser\/ui\/dom\/components\/__tests__\/ReactDOMInput-test.js\n+++ b\/src\/browser\/ui\/dom\/components\/__tests__\/ReactDOMInput-test.js\n@@ -82,18 +82,18 @@ describe('ReactDOMInput', function() {\n });\n \n it('should allow setting `value` to `true`', function() {\n- var stub = ;\n+ var stub = ;\n stub = ReactTestUtils.renderIntoDocument(stub);\n var node = stub.getDOMNode();\n \n expect(node.value).toBe('yolo');\n \n- stub.replaceProps({value: true});\n+ stub.replaceProps({value: true, onChange: emptyFunction});\n expect(node.value).toEqual('true');\n });\n \n it(\"should allow setting `value` to `false`\", function() {\n- var stub = ;\n+ var stub = ;\n stub = ReactTestUtils.renderIntoDocument(stub);\n var node = stub.getDOMNode();\n \n@@ -104,7 +104,7 @@ describe('ReactDOMInput', function() {\n });\n \n it('should allow setting `value` to `objToString`', function() {\n- var stub = ;\n+ var stub = ;\n stub = ReactTestUtils.renderIntoDocument(stub);\n var node = stub.getDOMNode();\n \n@@ -116,12 +116,12 @@ describe('ReactDOMInput', function() {\n }\n };\n \n- stub.replaceProps({value: objToString});\n+ stub.replaceProps({value: objToString, onChange: emptyFunction});\n expect(node.value).toEqual('foobar');\n });\n \n it('should properly control a value of number `0`', function() {\n- var stub = ;\n+ var stub = ;\n stub = ReactTestUtils.renderIntoDocument(stub);\n var node = stub.getDOMNode();\n \n@@ -145,11 +145,28 @@ describe('ReactDOMInput', function() {\n render: function() {\n return (\n

\n- A\n- B\n+ A\n+ B\n \n

\n- \n+ \n <\/form>\n <\/div>\n );\n@@ -246,7 +263,13 @@ describe('ReactDOMInput', function() {\n \n expect(React.renderComponent.bind(React, instance, node)).not.toThrow();\n \n- instance = ;\n+ instance =\n+ ;\n expect(React.renderComponent.bind(React, instance, node)).toThrow();\n \n instance = ;\n@@ -283,7 +306,11 @@ describe('ReactDOMInput', function() {\n expect(console.warn.mock.calls.length).toBe(0);\n \n React.renderComponent(\n- ,\n+ ,\n node\n );\n expect(console.warn.mock.calls.length).toBe(0);\n@@ -319,10 +346,17 @@ describe('ReactDOMInput', function() {\n \n expect(React.renderComponent.bind(React, instance, node)).not.toThrow();\n \n- instance = ;\n+ instance =\n+ ;\n expect(React.renderComponent.bind(React, instance, node)).toThrow();\n \n- instance = ;\n+ instance =\n+ ;\n expect(React.renderComponent.bind(React, instance, node)).toThrow();\n \n });\n@@ -342,7 +376,8 @@ describe('ReactDOMInput', function() {\n instance = ;\n expect(React.renderComponent.bind(React, instance, node)).not.toThrow();\n \n- instance = ;\n+ instance =\n+ ;\n expect(React.renderComponent.bind(React, instance, node)).toThrow();\n });\n });\n","body":"The prop validation threw a warning that either `onChange` or `readOnly` is required. Set the `onChange` where needed.","parents":["c8933b947bd57f47801bf5d2e1f492a9b9f4f81b"]}

dillon1000/react

Files changed