{"commit":{"authorEmail":"rdlesyutin@gmail.com","authoredAt":"2024-02-06T16:51:58+00:00","subject":"chore: use versioned render in storeStressSync test and gate them for legacy rendering (#28216)","shortRevision":"08d6cef46a","authorName":"Ruslan Lesiutin","revision":"08d6cef46ab7310b6e8f4330e2fd23586a026a9c"},"parents":["db120f69ec7a0b8c7f38ca7a1ddb1886de92e465"],"files":[{"status":"M","path":"packages\/react-devtools-shared\/src\/__tests__\/storeStressSync-test.js"}],"body":"","patch":"diff --git a\/packages\/react-devtools-shared\/src\/__tests__\/storeStressSync-test.js b\/packages\/react-devtools-shared\/src\/__tests__\/storeStressSync-test.js\nindex e7bb03b34f..bf444f1692 100644\n--- a\/packages\/react-devtools-shared\/src\/__tests__\/storeStressSync-test.js\n+++ b\/packages\/react-devtools-shared\/src\/__tests__\/storeStressSync-test.js\n@@ -7,14 +7,14 @@\n * @flow\n *\/\n \n+import {getLegacyRenderImplementation} from '.\/utils';\n+\n describe('StoreStress (Legacy Mode)', () => {\n let React;\n- let ReactDOM;\n let act;\n let bridge;\n let store;\n let print;\n- let legacyRender;\n \n beforeEach(() => {\n bridge = global.bridge;\n@@ -22,18 +22,20 @@ describe('StoreStress (Legacy Mode)', () => {\n store.collapseNodesByDefault = false;\n \n React = require('react');\n- ReactDOM = require('react-dom');\n \n const utils = require('.\/utils');\n act = utils.act;\n- legacyRender = utils.legacyRender;\n \n print = require('.\/__serializers__\/storeSerializer').print;\n });\n \n+ const {render, unmount, createContainer, getContainer} =\n+ getLegacyRenderImplementation();\n+\n \/\/ This is a stress test for the tree mount\/update\/unmount traversal.\n \/\/ It renders different trees that should produce the same output.\n \/\/ @reactVersion >= 16.9\n+ \/\/ @reactVersion < 19\n it('should handle a stress test with different tree operations (Legacy Mode)', () => {\n let setShowX;\n const A = () => 'a';\n@@ -60,8 +62,7 @@ describe('StoreStress (Legacy Mode)', () => {\n }\n \n \/\/ 1. Render a normal version of [a, b, c, d, e].\n- let container = document.createElement('div');\n- act(() => legacyRender({[a, b, c, d, e]}<\/Parent>, container));\n+ act(() => render({[a, b, c, d, e]}<\/Parent>));\n expect(store).toMatchInlineSnapshot(`\n [root]\n ▾ \n@@ -71,7 +72,7 @@ describe('StoreStress (Legacy Mode)', () => {\n \n \n `);\n- expect(container.textContent).toMatch('abcde');\n+ expect(getContainer().textContent).toMatch('abcde');\n const snapshotForABCDE = print(store);\n \n \/\/ 2. Render a version where renders an child instead of 'c'.\n@@ -89,18 +90,18 @@ describe('StoreStress (Legacy Mode)', () => {\n \n \n `);\n- expect(container.textContent).toMatch('abxde');\n+ expect(getContainer().textContent).toMatch('abxde');\n const snapshotForABXDE = print(store);\n \n \/\/ 3. Verify flipping it back produces the original result.\n act(() => {\n setShowX(false);\n });\n- expect(container.textContent).toMatch('abcde');\n+ expect(getContainer().textContent).toMatch('abcde');\n expect(print(store)).toBe(snapshotForABCDE);\n \n \/\/ 4. Clean up.\n- act(() => ReactDOM.unmountComponentAtNode(container));\n+ act(() => unmount());\n expect(print(store)).toBe('');\n \n \/\/ Now comes the interesting part.\n@@ -138,61 +139,62 @@ describe('StoreStress (Legacy Mode)', () => {\n \/\/ 5. Test fresh mount for each case.\n for (let i = 0; i < cases.length; i++) {\n \/\/ Ensure fresh mount.\n- container = document.createElement('div');\n+ createContainer();\n \n \/\/ Verify mounting 'abcde'.\n- act(() => legacyRender({cases[i]}<\/Parent>, container));\n- expect(container.textContent).toMatch('abcde');\n+ act(() => render({cases[i]}<\/Parent>));\n+ expect(getContainer().textContent).toMatch('abcde');\n expect(print(store)).toEqual(snapshotForABCDE);\n \n \/\/ Verify switching to 'abxde'.\n act(() => {\n setShowX(true);\n });\n- expect(container.textContent).toMatch('abxde');\n+ expect(getContainer().textContent).toMatch('abxde');\n expect(print(store)).toBe(snapshotForABXDE);\n \n \/\/ Verify switching back to 'abcde'.\n act(() => {\n setShowX(false);\n });\n- expect(container.textContent).toMatch('abcde');\n+ expect(getContainer().textContent).toMatch('abcde');\n expect(print(store)).toBe(snapshotForABCDE);\n \n \/\/ Clean up.\n- act(() => ReactDOM.unmountComponentAtNode(container));\n+ act(() => unmount());\n expect(print(store)).toBe('');\n }\n \n \/\/ 6. Verify *updates* by reusing the container between iterations.\n \/\/ There'll be no unmounting until the very end.\n- container = document.createElement('div');\n+ createContainer();\n for (let i = 0; i < cases.length; i++) {\n \/\/ Verify mounting 'abcde'.\n- act(() => legacyRender({cases[i]}<\/Parent>, container));\n- expect(container.textContent).toMatch('abcde');\n+ act(() => render({cases[i]}<\/Parent>));\n+ expect(getContainer().textContent).toMatch('abcde');\n expect(print(store)).toEqual(snapshotForABCDE);\n \n \/\/ Verify switching to 'abxde'.\n act(() => {\n setShowX(true);\n });\n- expect(container.textContent).toMatch('abxde');\n+ expect(getContainer().textContent).toMatch('abxde');\n expect(print(store)).toBe(snapshotForABXDE);\n \n \/\/ Verify switching back to 'abcde'.\n act(() => {\n setShowX(false);\n });\n- expect(container.textContent).toMatch('abcde');\n+ expect(getContainer().textContent).toMatch('abcde');\n expect(print(store)).toBe(snapshotForABCDE);\n \/\/ Don't unmount. Reuse the container between iterations.\n }\n- act(() => ReactDOM.unmountComponentAtNode(container));\n+ act(() => unmount());\n expect(print(store)).toBe('');\n });\n \n \/\/ @reactVersion >= 16.9\n+ \/\/ @reactVersion <= 18.2\n it('should handle stress test with reordering (Legacy Mode)', () => {\n const A = () => 'a';\n const B = () => 'b';\n@@ -320,27 +322,29 @@ describe('StoreStress (Legacy Mode)', () => {\n \n \/\/ 1. Capture the expected render result.\n const snapshots = [];\n- let container = document.createElement('div');\n for (let i = 0; i < steps.length; i++) {\n- act(() => legacyRender({steps[i]}<\/Root>, container));\n+ createContainer();\n+\n+ act(() => render({steps[i]}<\/Root>));\n \/\/ We snapshot each step once so it doesn't regress.\n expect(store).toMatchInlineSnapshot(stepsSnapshot[i]);\n snapshots.push(print(store));\n- act(() => ReactDOM.unmountComponentAtNode(container));\n+ act(() => unmount());\n expect(print(store)).toBe('');\n }\n \n \/\/ 2. Verify that we can update from every step to every other step and back.\n for (let i = 0; i < steps.length; i++) {\n for (let j = 0; j < steps.length; j++) {\n- container = document.createElement('div');\n- act(() => legacyRender({steps[i]}<\/Root>, container));\n+ createContainer();\n+\n+ act(() => render({steps[i]}<\/Root>));\n expect(print(store)).toMatch(snapshots[i]);\n- act(() => legacyRender({steps[j]}<\/Root>, container));\n+ act(() => render({steps[j]}<\/Root>));\n expect(print(store)).toMatch(snapshots[j]);\n- act(() => legacyRender({steps[i]}<\/Root>, container));\n+ act(() => render({steps[i]}<\/Root>));\n expect(print(store)).toMatch(snapshots[i]);\n- act(() => ReactDOM.unmountComponentAtNode(container));\n+ act(() => unmount());\n expect(print(store)).toBe('');\n }\n }\n@@ -348,41 +352,40 @@ describe('StoreStress (Legacy Mode)', () => {\n \/\/ 3. Same test as above, but this time we wrap children in a host component.\n for (let i = 0; i < steps.length; i++) {\n for (let j = 0; j < steps.length; j++) {\n- container = document.createElement('div');\n+ createContainer();\n+\n act(() =>\n- legacyRender(\n+ render(\n \n

{steps[i]}<\/div>\n <\/Root>,\n- container,\n ),\n );\n expect(print(store)).toMatch(snapshots[i]);\n act(() =>\n- legacyRender(\n+ render(\n \n

{steps[j]}<\/div>\n <\/Root>,\n- container,\n ),\n );\n expect(print(store)).toMatch(snapshots[j]);\n act(() =>\n- legacyRender(\n+ render(\n \n

{steps[i]}<\/div>\n <\/Root>,\n- container,\n ),\n );\n expect(print(store)).toMatch(snapshots[i]);\n- act(() => ReactDOM.unmountComponentAtNode(container));\n+ act(() => unmount());\n expect(print(store)).toBe('');\n }\n }\n });\n \n \/\/ @reactVersion >= 18.0\n+ \/\/ @reactVersion <= 18.2\n it('should handle a stress test for Suspense (Legacy Mode)', async () => {\n const A = () => 'a';\n const B = () => 'b';\n@@ -528,29 +531,31 @@ describe('StoreStress (Legacy Mode)', () => {\n \/\/ 1. For each step, check Suspense can render them as initial primary content.\n \/\/ This is the only step where we use Jest snapshots.\n const snapshots = [];\n- let container = document.createElement('div');\n for (let i = 0; i < steps.length; i++) {\n+ createContainer();\n+\n act(() =>\n- legacyRender(\n+ render(\n \n \n {steps[i]}<\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n \/\/ We snapshot each step once so it doesn't regress.\n expect(store).toMatchInlineSnapshot(stepsSnapshot[i]);\n snapshots.push(print(store));\n- act(() => ReactDOM.unmountComponentAtNode(container));\n+ act(() => unmount());\n expect(print(store)).toBe('');\n }\n \n \/\/ 2. Verify check Suspense can render same steps as initial fallback content.\n for (let i = 0; i < steps.length; i++) {\n+ createContainer();\n+\n act(() =>\n- legacyRender(\n+ render(\n \n \n \n@@ -560,11 +565,10 @@ describe('StoreStress (Legacy Mode)', () => {\n <\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n expect(print(store)).toEqual(snapshots[i]);\n- act(() => ReactDOM.unmountComponentAtNode(container));\n+ act(() => unmount());\n expect(print(store)).toBe('');\n }\n \n@@ -572,45 +576,43 @@ describe('StoreStress (Legacy Mode)', () => {\n for (let i = 0; i < steps.length; i++) {\n for (let j = 0; j < steps.length; j++) {\n \/\/ Always start with a fresh container and steps[i].\n- container = document.createElement('div');\n+ createContainer();\n+\n act(() =>\n- legacyRender(\n+ render(\n \n \n {steps[i]}<\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n expect(print(store)).toEqual(snapshots[i]);\n \/\/ Re-render with steps[j].\n act(() =>\n- legacyRender(\n+ render(\n \n \n {steps[j]}<\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n \/\/ Verify the successful transition to steps[j].\n expect(print(store)).toEqual(snapshots[j]);\n \/\/ Check that we can transition back again.\n act(() =>\n- legacyRender(\n+ render(\n \n \n {steps[i]}<\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n expect(print(store)).toEqual(snapshots[i]);\n \/\/ Clean up after every iteration.\n- act(() => ReactDOM.unmountComponentAtNode(container));\n+ act(() => unmount());\n expect(print(store)).toBe('');\n }\n }\n@@ -619,9 +621,10 @@ describe('StoreStress (Legacy Mode)', () => {\n for (let i = 0; i < steps.length; i++) {\n for (let j = 0; j < steps.length; j++) {\n \/\/ Always start with a fresh container and steps[i].\n- container = document.createElement('div');\n+ createContainer();\n+\n act(() =>\n- legacyRender(\n+ render(\n \n \n \n@@ -631,13 +634,12 @@ describe('StoreStress (Legacy Mode)', () => {\n <\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n expect(print(store)).toEqual(snapshots[i]);\n \/\/ Re-render with steps[j].\n act(() =>\n- legacyRender(\n+ render(\n \n \n \n@@ -647,14 +649,13 @@ describe('StoreStress (Legacy Mode)', () => {\n <\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n \/\/ Verify the successful transition to steps[j].\n expect(print(store)).toEqual(snapshots[j]);\n \/\/ Check that we can transition back again.\n act(() =>\n- legacyRender(\n+ render(\n \n \n \n@@ -664,12 +665,11 @@ describe('StoreStress (Legacy Mode)', () => {\n <\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n expect(print(store)).toEqual(snapshots[i]);\n \/\/ Clean up after every iteration.\n- act(() => ReactDOM.unmountComponentAtNode(container));\n+ act(() => unmount());\n expect(print(store)).toBe('');\n }\n }\n@@ -678,21 +678,21 @@ describe('StoreStress (Legacy Mode)', () => {\n for (let i = 0; i < steps.length; i++) {\n for (let j = 0; j < steps.length; j++) {\n \/\/ Always start with a fresh container and steps[i].\n- container = document.createElement('div');\n+ createContainer();\n+\n act(() =>\n- legacyRender(\n+ render(\n \n \n {steps[i]}<\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n expect(print(store)).toEqual(snapshots[i]);\n \/\/ Re-render with steps[j].\n act(() =>\n- legacyRender(\n+ render(\n \n \n \n@@ -702,25 +702,23 @@ describe('StoreStress (Legacy Mode)', () => {\n <\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n \/\/ Verify the successful transition to steps[j].\n expect(print(store)).toEqual(snapshots[j]);\n \/\/ Check that we can transition back again.\n act(() =>\n- legacyRender(\n+ render(\n \n \n {steps[i]}<\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n expect(print(store)).toEqual(snapshots[i]);\n \/\/ Clean up after every iteration.\n- act(() => ReactDOM.unmountComponentAtNode(container));\n+ act(() => unmount());\n expect(print(store)).toBe('');\n }\n }\n@@ -729,9 +727,10 @@ describe('StoreStress (Legacy Mode)', () => {\n for (let i = 0; i < steps.length; i++) {\n for (let j = 0; j < steps.length; j++) {\n \/\/ Always start with a fresh container and steps[i].\n- container = document.createElement('div');\n+ createContainer();\n+\n act(() =>\n- legacyRender(\n+ render(\n \n \n \n@@ -741,26 +740,24 @@ describe('StoreStress (Legacy Mode)', () => {\n <\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n expect(print(store)).toEqual(snapshots[i]);\n \/\/ Re-render with steps[j].\n act(() =>\n- legacyRender(\n+ render(\n \n \n {steps[j]}<\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n \/\/ Verify the successful transition to steps[j].\n expect(print(store)).toEqual(snapshots[j]);\n \/\/ Check that we can transition back again.\n act(() =>\n- legacyRender(\n+ render(\n \n \n \n@@ -770,12 +767,11 @@ describe('StoreStress (Legacy Mode)', () => {\n <\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n expect(print(store)).toEqual(snapshots[i]);\n \/\/ Clean up after every iteration.\n- act(() => ReactDOM.unmountComponentAtNode(container));\n+ act(() => unmount());\n expect(print(store)).toBe('');\n }\n }\n@@ -784,15 +780,15 @@ describe('StoreStress (Legacy Mode)', () => {\n for (let i = 0; i < steps.length; i++) {\n for (let j = 0; j < steps.length; j++) {\n \/\/ Always start with a fresh container and steps[i].\n- container = document.createElement('div');\n+ createContainer();\n+\n act(() =>\n- legacyRender(\n+ render(\n \n \n {steps[i]}<\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n \n@@ -824,7 +820,7 @@ describe('StoreStress (Legacy Mode)', () => {\n \n \/\/ Trigger actual fallback.\n act(() =>\n- legacyRender(\n+ render(\n \n \n \n@@ -834,7 +830,6 @@ describe('StoreStress (Legacy Mode)', () => {\n <\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n expect(print(store)).toEqual(snapshots[j]);\n@@ -852,13 +847,12 @@ describe('StoreStress (Legacy Mode)', () => {\n \n \/\/ Switch to primary mode.\n act(() =>\n- legacyRender(\n+ render(\n \n \n {steps[i]}<\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n \/\/ Fallback is still forced though.\n@@ -876,13 +870,14 @@ describe('StoreStress (Legacy Mode)', () => {\n expect(print(store)).toEqual(snapshots[i]);\n \n \/\/ Clean up after every iteration.\n- act(() => ReactDOM.unmountComponentAtNode(container));\n+ act(() => unmount());\n expect(print(store)).toBe('');\n }\n }\n });\n \n \/\/ @reactVersion >= 18.0\n+ \/\/ @reactVersion <= 18.2\n it('should handle a stress test for Suspense without type change (Legacy Mode)', () => {\n const A = () => 'a';\n const B = () => 'b';\n@@ -1176,10 +1171,12 @@ describe('StoreStress (Legacy Mode)', () => {\n \/\/ 1. For each step, check Suspense can render them as initial primary content.\n \/\/ This is the only step where we use Jest snapshots.\n const snapshots = [];\n- let container = document.createElement('div');\n+\n for (let i = 0; i < steps.length; i++) {\n+ createContainer();\n+\n act(() =>\n- legacyRender(\n+ render(\n \n \n \n@@ -1187,13 +1184,12 @@ describe('StoreStress (Legacy Mode)', () => {\n <\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n \/\/ We snapshot each step once so it doesn't regress.\n expect(store).toMatchInlineSnapshot(stepsSnapshot[i]);\n snapshots.push(print(store));\n- act(() => ReactDOM.unmountComponentAtNode(container));\n+ act(() => unmount());\n expect(print(store)).toBe('');\n }\n \n@@ -1202,8 +1198,10 @@ describe('StoreStress (Legacy Mode)', () => {\n \/\/ which is different from the snapshots above. So we take more snapshots.\n const fallbackSnapshots = [];\n for (let i = 0; i < steps.length; i++) {\n+ createContainer();\n+\n act(() =>\n- legacyRender(\n+ render(\n \n \n \n@@ -1213,13 +1211,12 @@ describe('StoreStress (Legacy Mode)', () => {\n <\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n \/\/ We snapshot each step once so it doesn't regress.\n expect(store).toMatchInlineSnapshot(stepsSnapshotTwo[i]);\n fallbackSnapshots.push(print(store));\n- act(() => ReactDOM.unmountComponentAtNode(container));\n+ act(() => unmount());\n expect(print(store)).toBe('');\n }\n \n@@ -1227,9 +1224,10 @@ describe('StoreStress (Legacy Mode)', () => {\n for (let i = 0; i < steps.length; i++) {\n for (let j = 0; j < steps.length; j++) {\n \/\/ Always start with a fresh container and steps[i].\n- container = document.createElement('div');\n+ createContainer();\n+\n act(() =>\n- legacyRender(\n+ render(\n \n \n \n@@ -1237,13 +1235,12 @@ describe('StoreStress (Legacy Mode)', () => {\n <\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n expect(print(store)).toEqual(snapshots[i]);\n \/\/ Re-render with steps[j].\n act(() =>\n- legacyRender(\n+ render(\n \n \n \n@@ -1251,14 +1248,13 @@ describe('StoreStress (Legacy Mode)', () => {\n <\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n \/\/ Verify the successful transition to steps[j].\n expect(print(store)).toEqual(snapshots[j]);\n \/\/ Check that we can transition back again.\n act(() =>\n- legacyRender(\n+ render(\n \n \n \n@@ -1266,12 +1262,11 @@ describe('StoreStress (Legacy Mode)', () => {\n <\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n expect(print(store)).toEqual(snapshots[i]);\n \/\/ Clean up after every iteration.\n- act(() => ReactDOM.unmountComponentAtNode(container));\n+ act(() => unmount());\n expect(print(store)).toBe('');\n }\n }\n@@ -1280,9 +1275,10 @@ describe('StoreStress (Legacy Mode)', () => {\n for (let i = 0; i < steps.length; i++) {\n for (let j = 0; j < steps.length; j++) {\n \/\/ Always start with a fresh container and steps[i].\n- container = document.createElement('div');\n+ createContainer();\n+\n act(() =>\n- legacyRender(\n+ render(\n \n \n \n@@ -1295,13 +1291,12 @@ describe('StoreStress (Legacy Mode)', () => {\n <\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n expect(print(store)).toEqual(fallbackSnapshots[i]);\n \/\/ Re-render with steps[j].\n act(() =>\n- legacyRender(\n+ render(\n \n \n \n@@ -1314,14 +1309,13 @@ describe('StoreStress (Legacy Mode)', () => {\n <\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n \/\/ Verify the successful transition to steps[j].\n expect(print(store)).toEqual(fallbackSnapshots[j]);\n \/\/ Check that we can transition back again.\n act(() =>\n- legacyRender(\n+ render(\n \n \n \n@@ -1334,12 +1328,11 @@ describe('StoreStress (Legacy Mode)', () => {\n <\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n expect(print(store)).toEqual(fallbackSnapshots[i]);\n \/\/ Clean up after every iteration.\n- act(() => ReactDOM.unmountComponentAtNode(container));\n+ act(() => unmount());\n expect(print(store)).toBe('');\n }\n }\n@@ -1348,9 +1341,10 @@ describe('StoreStress (Legacy Mode)', () => {\n for (let i = 0; i < steps.length; i++) {\n for (let j = 0; j < steps.length; j++) {\n \/\/ Always start with a fresh container and steps[i].\n- container = document.createElement('div');\n+ createContainer();\n+\n act(() =>\n- legacyRender(\n+ render(\n \n \n \n@@ -1358,13 +1352,12 @@ describe('StoreStress (Legacy Mode)', () => {\n <\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n expect(print(store)).toEqual(snapshots[i]);\n \/\/ Re-render with steps[j].\n act(() =>\n- legacyRender(\n+ render(\n \n \n \n@@ -1372,14 +1365,13 @@ describe('StoreStress (Legacy Mode)', () => {\n <\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n \/\/ Verify the successful transition to steps[j].\n expect(print(store)).toEqual(fallbackSnapshots[j]);\n \/\/ Check that we can transition back again.\n act(() =>\n- legacyRender(\n+ render(\n \n \n \n@@ -1387,12 +1379,11 @@ describe('StoreStress (Legacy Mode)', () => {\n <\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n expect(print(store)).toEqual(snapshots[i]);\n \/\/ Clean up after every iteration.\n- act(() => ReactDOM.unmountComponentAtNode(container));\n+ act(() => unmount());\n expect(print(store)).toBe('');\n }\n }\n@@ -1401,9 +1392,10 @@ describe('StoreStress (Legacy Mode)', () => {\n for (let i = 0; i < steps.length; i++) {\n for (let j = 0; j < steps.length; j++) {\n \/\/ Always start with a fresh container and steps[i].\n- container = document.createElement('div');\n+ createContainer();\n+\n act(() =>\n- legacyRender(\n+ render(\n \n \n \n@@ -1411,13 +1403,12 @@ describe('StoreStress (Legacy Mode)', () => {\n <\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n expect(print(store)).toEqual(fallbackSnapshots[i]);\n \/\/ Re-render with steps[j].\n act(() =>\n- legacyRender(\n+ render(\n \n \n \n@@ -1425,14 +1416,13 @@ describe('StoreStress (Legacy Mode)', () => {\n <\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n \/\/ Verify the successful transition to steps[j].\n expect(print(store)).toEqual(snapshots[j]);\n \/\/ Check that we can transition back again.\n act(() =>\n- legacyRender(\n+ render(\n \n \n \n@@ -1440,12 +1430,11 @@ describe('StoreStress (Legacy Mode)', () => {\n <\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n expect(print(store)).toEqual(fallbackSnapshots[i]);\n \/\/ Clean up after every iteration.\n- act(() => ReactDOM.unmountComponentAtNode(container));\n+ act(() => unmount());\n expect(print(store)).toBe('');\n }\n }\n@@ -1454,9 +1443,10 @@ describe('StoreStress (Legacy Mode)', () => {\n for (let i = 0; i < steps.length; i++) {\n for (let j = 0; j < steps.length; j++) {\n \/\/ Always start with a fresh container and steps[i].\n- container = document.createElement('div');\n+ createContainer();\n+\n act(() =>\n- legacyRender(\n+ render(\n \n \n \n@@ -1464,7 +1454,6 @@ describe('StoreStress (Legacy Mode)', () => {\n <\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n \n@@ -1496,7 +1485,7 @@ describe('StoreStress (Legacy Mode)', () => {\n \n \/\/ Trigger actual fallback.\n act(() =>\n- legacyRender(\n+ render(\n \n \n \n@@ -1504,7 +1493,6 @@ describe('StoreStress (Legacy Mode)', () => {\n <\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n expect(print(store)).toEqual(fallbackSnapshots[j]);\n@@ -1522,7 +1510,7 @@ describe('StoreStress (Legacy Mode)', () => {\n \n \/\/ Switch to primary mode.\n act(() =>\n- legacyRender(\n+ render(\n \n \n \n@@ -1530,7 +1518,6 @@ describe('StoreStress (Legacy Mode)', () => {\n <\/React.Suspense>\n \n <\/Root>,\n- container,\n ),\n );\n \/\/ Fallback is still forced though.\n@@ -1548,7 +1535,7 @@ describe('StoreStress (Legacy Mode)', () => {\n expect(print(store)).toEqual(snapshots[i]);\n \n \/\/ Clean up after every iteration.\n- act(() => ReactDOM.unmountComponentAtNode(container));\n+ act(() => unmount());\n expect(print(store)).toBe('');\n }\n }\n"}

dillon1000/react

Files changed