{"commit":{"authorEmail":"git@andrewclark.io","shortRevision":"0bd0c5269f","authorName":"Andrew Clark","authoredAt":"2019-08-09T12:59:02-07:00","subject":"Upgrade ESLint so we can use JSX Fragment syntax (#16328)","revision":"0bd0c5269f2fe90ff7897ed5ce9146db99126eaf"},"parents":["07d062dea852befa47d5b11111c21769bd8205d3"],"body":"Now that we're using Babel 7, this is the last blocker.","files":[{"path":".eslintrc.js","status":"M"},{"path":"fixtures\/dom\/src\/components\/fixtures\/suspense\/index.js","status":"M"},{"path":"package.json","status":"M"},{"path":"packages\/react-dom\/src\/__tests__\/ReactDOMFiber-test.js","status":"M"},{"path":"packages\/react-dom\/src\/__tests__\/ReactDOMFiberAsync-test.internal.js","status":"M"},{"path":"packages\/react-dom\/src\/__tests__\/ReactDOMHooks-test.js","status":"M"},{"path":"packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationClassContextType-test.js","status":"M"},{"path":"packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationFragment-test.js","status":"M"},{"path":"packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationNewContext-test.js","status":"M"},{"path":"packages\/react-dom\/src\/__tests__\/ReactDOMServerPartialHydration-test.internal.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactBatchedMode-test.internal.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactExpiration-test.internal.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactFragment-test.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactHooks-test.internal.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactHooksWithNoopRenderer-test.internal.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactIncrementalErrorHandling-test.internal.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactIncrementalUpdates-test.internal.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactLazy-test.internal.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactNewContext-test.internal.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactSchedulerIntegration-test.internal.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactSuspense-test.internal.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactSuspenseFuzz-test.internal.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactSuspenseList-test.internal.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactSuspensePlaceholder-test.internal.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactSuspenseWithNoopRenderer-test.internal.js","status":"M"},{"path":"packages\/react-refresh\/src\/__tests__\/ReactFresh-test.js","status":"M"},{"path":"packages\/react-test-renderer\/src\/__tests__\/ReactShallowRenderer-test.js","status":"M"},{"path":"packages\/react-test-renderer\/src\/__tests__\/ReactShallowRendererMemo-test.js","status":"M"},{"path":"packages\/react-test-renderer\/src\/__tests__\/ReactTestRenderer-test.internal.js","status":"M"},{"path":"packages\/react-test-renderer\/src\/__tests__\/ReactTestRendererAsync-test.js","status":"M"},{"path":"packages\/react-test-renderer\/src\/__tests__\/ReactTestRendererTraversal-test.js","status":"M"},{"path":"packages\/react\/src\/__tests__\/ReactDOMTracing-test.internal.js","status":"M"},{"path":"packages\/react\/src\/__tests__\/ReactJSXElementValidator-test.js","status":"M"},{"path":"packages\/react\/src\/__tests__\/ReactProfiler-test.internal.js","status":"M"},{"path":"packages\/react\/src\/__tests__\/forwardRef-test.js","status":"M"},{"path":"scripts\/rollup\/validate\/eslintrc.cjs.js","status":"M"},{"path":"scripts\/rollup\/validate\/eslintrc.fb.js","status":"M"},{"path":"scripts\/rollup\/validate\/eslintrc.rn.js","status":"M"},{"path":"scripts\/rollup\/validate\/eslintrc.umd.js","status":"M"},{"path":"yarn.lock","status":"M"}],"patch":"diff --git a\/.eslintrc.js b\/.eslintrc.js\nindex 1c48ea5330..de78bd0749 100644\n--- a\/.eslintrc.js\n+++ b\/.eslintrc.js\n@@ -12,18 +12,13 @@ module.exports = {\n extends: 'fbjs',\n \n \/\/ Stop ESLint from looking for a configuration file in parent folders\n- 'root': true,\n+ root: true,\n \n- plugins: [\n- 'jest',\n- 'no-for-of-loops',\n- 'react',\n- 'react-internal',\n- ],\n+ plugins: ['jest', 'no-for-of-loops', 'react', 'react-internal'],\n \n- parser: 'espree',\n+ parser: 'babel-eslint',\n parserOptions: {\n- ecmaVersion: 2017,\n+ ecmaVersion: 8,\n sourceType: 'script',\n ecmaFeatures: {\n experimentalObjectRestSpread: true,\n@@ -40,8 +35,8 @@ module.exports = {\n 'dot-location': [ERROR, 'property'],\n 'dot-notation': ERROR,\n 'eol-last': ERROR,\n- 'eqeqeq': [ERROR, 'allow-null'],\n- 'indent': OFF,\n+ eqeqeq: [ERROR, 'allow-null'],\n+ indent: OFF,\n 'jsx-quotes': [ERROR, 'prefer-double'],\n 'keyword-spacing': [ERROR, {after: true, before: true}],\n 'no-bitwise': OFF,\n@@ -51,9 +46,9 @@ module.exports = {\n 'no-shadow': ERROR,\n 'no-unused-expressions': ERROR,\n 'no-unused-vars': [ERROR, {args: 'none'}],\n- 'no-use-before-define': [ERROR, {functions: false, variables: false}],\n+ 'no-use-before-define': OFF,\n 'no-useless-concat': OFF,\n- 'quotes': [ERROR, 'single', {avoidEscape: true, allowTemplateLiterals: true }],\n+ quotes: [ERROR, 'single', {avoidEscape: true, allowTemplateLiterals: true}],\n 'space-before-blocks': ERROR,\n 'space-before-function-paren': OFF,\n 'valid-typeof': [ERROR, {requireStringLiterals: true}],\n@@ -65,6 +60,12 @@ module.exports = {\n 'no-var': ERROR,\n strict: ERROR,\n \n+ \/\/ Enforced by Prettier\n+ \/\/ TODO: Prettier doesn't handle long strings or long comments. Not a big\n+ \/\/ deal. But I turned it off because loading the plugin causes some obscure\n+ \/\/ syntax error and it didn't seem worth investigating.\n+ 'max-len': OFF,\n+\n \/\/ React & JSX\n \/\/ Our transforms set this automatically\n 'react\/jsx-boolean-value': [ERROR, 'always'],\n@@ -78,7 +79,10 @@ module.exports = {\n 'react\/react-in-jsx-scope': ERROR,\n 'react\/self-closing-comp': ERROR,\n \/\/ We don't care to do this\n- 'react\/jsx-wrap-multilines': [ERROR, {declaration: false, assignment: false}],\n+ 'react\/jsx-wrap-multilines': [\n+ ERROR,\n+ {declaration: false, assignment: false},\n+ ],\n \n \/\/ Prevent for...of loops because they require a Symbol polyfill.\n \/\/ You can disable this rule for code that isn't shipped (e.g. build scripts and tests).\n@@ -112,6 +116,7 @@ module.exports = {\n files: esNextPaths,\n parser: 'babel-eslint',\n parserOptions: {\n+ ecmaVersion: 8,\n sourceType: 'module',\n },\n rules: {\n@@ -124,14 +129,14 @@ module.exports = {\n rules: {\n \/\/ https:\/\/github.com\/jest-community\/eslint-plugin-jest\n 'jest\/no-focused-tests': ERROR,\n- }\n+ },\n },\n {\n files: ['packages\/react-native-renderer\/**\/*.js'],\n globals: {\n nativeFabricUIManager: true,\n- }\n- }\n+ },\n+ },\n ],\n \n globals: {\ndiff --git a\/fixtures\/dom\/src\/components\/fixtures\/suspense\/index.js b\/fixtures\/dom\/src\/components\/fixtures\/suspense\/index.js\nindex 39efc39143..44b9f33192 100644\n--- a\/fixtures\/dom\/src\/components\/fixtures\/suspense\/index.js\n+++ b\/fixtures\/dom\/src\/components\/fixtures\/suspense\/index.js\n@@ -46,7 +46,7 @@ class SuspendyTreeChild extends React.Component {\n \n render() {\n return (\n- \n+ <>\n (display: none)<\/div>}>\n

\n \n@@ -54,7 +54,7 @@ class SuspendyTreeChild extends React.Component {\n <\/div>\n <\/Suspense>\n

footer<\/h2>\n

dillon1000/react

Files changed