{"files":[{"path":"packages\/react-dom\/src\/events\/plugins\/__tests__\/SelectEventPlugin-test.js","status":"M"}],"patch":"diff --git a\/packages\/react-dom\/src\/events\/plugins\/__tests__\/SelectEventPlugin-test.js b\/packages\/react-dom\/src\/events\/plugins\/__tests__\/SelectEventPlugin-test.js\nindex b21b5e3455..6f7943328a 100644\n--- a\/packages\/react-dom\/src\/events\/plugins\/__tests__\/SelectEventPlugin-test.js\n+++ b\/packages\/react-dom\/src\/events\/plugins\/__tests__\/SelectEventPlugin-test.js\n@@ -10,15 +10,16 @@\n 'use strict';\n \n let React;\n-let ReactDOM;\n+let ReactDOMClient;\n+let act;\n \n describe('SelectEventPlugin', () => {\n let container;\n \n beforeEach(() => {\n React = require('react');\n- ReactDOM = require('react-dom');\n-\n+ ReactDOMClient = require('react-dom\/client');\n+ act = require('internal-test-utils').act;\n container = document.createElement('div');\n document.body.appendChild(container);\n });\n@@ -29,7 +30,7 @@ describe('SelectEventPlugin', () => {\n });\n \n \/\/ See https:\/\/github.com\/facebook\/react\/pull\/3639 for details.\n- it('does not get confused when dependent events are registered independently', () => {\n+ it('does not get confused when dependent events are registered independently', async () => {\n const select = jest.fn();\n const onSelect = event => {\n expect(typeof event).toBe('object');\n@@ -38,11 +39,14 @@ describe('SelectEventPlugin', () => {\n select(event.currentTarget);\n };\n \n- \/\/ Pass `onMouseDown` so React registers a top-level listener.\n- const node = ReactDOM.render(\n- ,\n- container,\n- );\n+ const root = ReactDOMClient.createRoot(container);\n+ const node = await (async function () {\n+ await act(() => {\n+ \/\/ Pass `onMouseDown` so React registers a top-level listener.\n+ root.render();\n+ });\n+ return container.firstChild;\n+ })();\n \n \/\/ Trigger `mousedown` and `mouseup`. Note that\n \/\/ React is not currently listening to `mouseup`.\n@@ -59,8 +63,10 @@ describe('SelectEventPlugin', () => {\n }),\n );\n \n- \/\/ Now subscribe to `onSelect`.\n- ReactDOM.render(, container);\n+ await act(() => {\n+ \/\/ Now subscribe to `onSelect`\n+ root.render();\n+ });\n node.focus();\n \n \/\/ This triggers a `select` event in our polyfill.\n@@ -74,7 +80,7 @@ describe('SelectEventPlugin', () => {\n expect(select).toHaveBeenCalledTimes(1);\n });\n \n- it('should fire `onSelect` when a listener is present', () => {\n+ it('should fire `onSelect` when a listener is present', async () => {\n const select = jest.fn();\n const onSelect = event => {\n expect(typeof event).toBe('object');\n@@ -83,10 +89,14 @@ describe('SelectEventPlugin', () => {\n select(event.currentTarget);\n };\n \n- const node = ReactDOM.render(\n- ,\n- container,\n- );\n+ const node = await (async function () {\n+ const root = ReactDOMClient.createRoot(container);\n+ await act(() => {\n+ root.render();\n+ });\n+ return container.firstChild;\n+ })();\n+\n node.focus();\n \n let nativeEvent = new MouseEvent('focus', {\n@@ -108,7 +118,7 @@ describe('SelectEventPlugin', () => {\n expect(select).toHaveBeenCalledTimes(1);\n });\n \n- it('should fire `onSelectCapture` when a listener is present', () => {\n+ it('should fire `onSelectCapture` when a listener is present', async () => {\n const select = jest.fn();\n const onSelectCapture = event => {\n expect(typeof event).toBe('object');\n@@ -117,10 +127,14 @@ describe('SelectEventPlugin', () => {\n select(event.currentTarget);\n };\n \n- const node = ReactDOM.render(\n- ,\n- container,\n- );\n+ const node = await (async function () {\n+ const root = ReactDOMClient.createRoot(container);\n+ await act(() => {\n+ root.render();\n+ });\n+ return container.firstChild;\n+ })();\n+\n node.focus();\n \n let nativeEvent = new MouseEvent('focus', {\n@@ -143,7 +157,7 @@ describe('SelectEventPlugin', () => {\n });\n \n \/\/ Regression test for https:\/\/github.com\/facebook\/react\/issues\/11379\n- it('should not wait for `mouseup` after receiving `dragend`', () => {\n+ it('should not wait for `mouseup` after receiving `dragend`', async () => {\n const select = jest.fn();\n const onSelect = event => {\n expect(typeof event).toBe('object');\n@@ -152,10 +166,14 @@ describe('SelectEventPlugin', () => {\n select(event.currentTarget);\n };\n \n- const node = ReactDOM.render(\n- ,\n- container,\n- );\n+ const node = await (async function () {\n+ const root = ReactDOMClient.createRoot(container);\n+ await act(() => {\n+ root.render();\n+ });\n+ return container.firstChild;\n+ })();\n+\n node.focus();\n \n let nativeEvent = new MouseEvent('focus', {\n@@ -177,12 +195,17 @@ describe('SelectEventPlugin', () => {\n expect(select).toHaveBeenCalledTimes(1);\n });\n \n- it('should handle selectionchange events', function () {\n+ it('should handle selectionchange events', async function () {\n const onSelect = jest.fn();\n- const node = ReactDOM.render(\n- ,\n- container,\n- );\n+\n+ const node = await (async function () {\n+ const root = ReactDOMClient.createRoot(container);\n+ await act(() => {\n+ root.render();\n+ });\n+ return container.firstChild;\n+ })();\n+\n node.focus();\n \n \/\/ Make sure the event was not called before we emit the selection change event\n","commit":{"subject":"Convert SelectEventPlugin to createRoot (#28076)","revision":"0c45e8307135dc275b18b3a8fa5c85ba97d20a42","authorName":"Sebastian Silbermann","shortRevision":"0c45e83071","authorEmail":"silbermann.sebastian@gmail.com","authoredAt":"2024-01-26T10:17:13+01:00"},"parents":["b30ec67c4342c9e4ccf42e7b3f17e00ea3bf28bd"],"body":""}

dillon1000/react

Files changed