{"commit":{"authorName":"Sebastian \"Sebbie\" Silbermann","subject":"[devtools] Document that Store consistency throws must not be worked around (#37035)","authoredAt":"2026-07-16T15:04:50+02:00","revision":"0e516d326c9c3922c2584e42698b53ae4ab0d7e5","authorEmail":"sebastian.silbermann@vercel.com","shortRevision":"0e516d326c"},"parents":["71ecaf89904a352e751ee43b00253c9927fb7183"],"body":"Co-authored-by: Claude Fable 5 ","files":[{"status":"M","path":"packages\/react-devtools-shared\/src\/devtools\/store.js"}],"patch":"diff --git a\/packages\/react-devtools-shared\/src\/devtools\/store.js b\/packages\/react-devtools-shared\/src\/devtools\/store.js\nindex 557020620e..91b3586b81 100644\n--- a\/packages\/react-devtools-shared\/src\/devtools\/store.js\n+++ b\/packages\/react-devtools-shared\/src\/devtools\/store.js\n@@ -608,6 +608,7 @@ export default class Store extends EventEmitter<{\n root = this._idToElement.get(rootID);\n \n if (root === undefined) {\n+ \/\/ We should never reach this. This is a bug in the backend renderer.\n this._throwAndEmitError(\n Error(\n `Couldn't find root with id \"${rootID}\": no matching node was found in the Store.`,\n@@ -644,6 +645,7 @@ export default class Store extends EventEmitter<{\n const child = this._idToElement.get(childID);\n \n if (child === undefined) {\n+ \/\/ We should never reach this. This is a bug in the backend renderer.\n this._throwAndEmitError(\n Error(\n `Couldn't child element with id \"${childID}\": no matching node was found in the Store.`,\n@@ -1431,6 +1433,7 @@ export default class Store extends EventEmitter<{\n i += 3;\n \n if (this._idToElement.has(id)) {\n+ \/\/ We should never reach this. This is a bug in the backend renderer.\n this._throwAndEmitError(\n Error(\n `Cannot add node \"${id}\" because a node with that id is already in the Store.`,\n@@ -1541,6 +1544,7 @@ export default class Store extends EventEmitter<{\n \n const parentElement = this._idToElement.get(parentID);\n if (parentElement === undefined) {\n+ \/\/ We should never reach this. This is a bug in the backend renderer.\n this._throwAndEmitError(\n Error(\n `Cannot add child \"${id}\" to parent \"${parentID}\" because parent node was not found in the Store.`,\n@@ -1617,6 +1621,7 @@ export default class Store extends EventEmitter<{\n const element = this._idToElement.get(id);\n \n if (element === undefined) {\n+ \/\/ We should never reach this. This is a bug in the backend renderer.\n this._throwAndEmitError(\n Error(\n `Cannot remove node \"${id}\" because no matching node was found in the Store.`,\n@@ -1630,6 +1635,7 @@ export default class Store extends EventEmitter<{\n \n const {children, ownerID, parentID, weight} = element;\n if (children.length > 0) {\n+ \/\/ We should never reach this. This is a bug in the backend renderer.\n this._throwAndEmitError(\n Error(`Node \"${id}\" was removed before its children.`),\n );\n@@ -1657,6 +1663,7 @@ export default class Store extends EventEmitter<{\n \n parentElement = this._idToElement.get(parentID);\n if (parentElement === undefined) {\n+ \/\/ We should never reach this. This is a bug in the backend renderer.\n this._throwAndEmitError(\n Error(\n `Cannot remove node \"${id}\" from parent \"${parentID}\" because no matching node was found in the Store.`,\n@@ -1696,6 +1703,7 @@ export default class Store extends EventEmitter<{\n \n const element = this._idToElement.get(id);\n if (element === undefined) {\n+ \/\/ We should never reach this. This is a bug in the backend renderer.\n this._throwAndEmitError(\n Error(\n `Cannot reorder children for node \"${id}\" because no matching node was found in the Store.`,\n@@ -1707,6 +1715,7 @@ export default class Store extends EventEmitter<{\n \n const children = element.children;\n if (children.length !== numChildren) {\n+ \/\/ We should never reach this. This is a bug in the backend renderer.\n this._throwAndEmitError(\n Error(\n `Children cannot be added or removed during a reorder operation.`,\n@@ -1824,6 +1833,7 @@ export default class Store extends EventEmitter<{\n let name = stringTable[nameStringID];\n \n if (this._idToSuspense.has(id)) {\n+ \/\/ We should never reach this. This is a bug in the backend renderer.\n this._throwAndEmitError(\n Error(\n `Cannot add suspense node \"${id}\" because a suspense node with that id is already in the Store.`,\n@@ -1876,6 +1886,7 @@ export default class Store extends EventEmitter<{\n if (parentID !== 0) {\n const parentSuspense = this._idToSuspense.get(parentID);\n if (parentSuspense === undefined) {\n+ \/\/ We should never reach this. This is a bug in the backend renderer.\n this._throwAndEmitError(\n Error(\n `Cannot add suspense child \"${id}\" to parent suspense \"${parentID}\" because parent suspense node was not found in the Store.`,\n@@ -1912,6 +1923,7 @@ export default class Store extends EventEmitter<{\n const suspense = this._idToSuspense.get(id);\n \n if (suspense === undefined) {\n+ \/\/ We should never reach this. This is a bug in the backend renderer.\n this._throwAndEmitError(\n Error(\n `Cannot remove suspense node \"${id}\" because no matching node was found in the Store.`,\n@@ -1925,6 +1937,7 @@ export default class Store extends EventEmitter<{\n \n const {children, parentID, rects} = suspense;\n if (children.length > 0) {\n+ \/\/ We should never reach this. This is a bug in the backend renderer.\n this._throwAndEmitError(\n Error(`Suspense node \"${id}\" was removed before its children.`),\n );\n@@ -1954,6 +1967,7 @@ export default class Store extends EventEmitter<{\n \n parentSuspense = this._idToSuspense.get(parentID);\n if (parentSuspense === undefined) {\n+ \/\/ We should never reach this. This is a bug in the backend renderer.\n this._throwAndEmitError(\n Error(\n `Cannot remove suspense node \"${id}\" from parent \"${parentID}\" because no matching node was found in the Store.`,\n@@ -1965,6 +1979,7 @@ export default class Store extends EventEmitter<{\n \n const index = parentSuspense.children.indexOf(id);\n if (index === -1) {\n+ \/\/ We should never reach this. This is a bug in the backend renderer.\n this._throwAndEmitError(\n Error(\n `Cannot remove suspense node \"${id}\" from parent \"${parentID}\" because it is not a child of the parent.`,\n@@ -1985,6 +2000,7 @@ export default class Store extends EventEmitter<{\n \n const suspense = this._idToSuspense.get(id);\n if (suspense === undefined) {\n+ \/\/ We should never reach this. This is a bug in the backend renderer.\n this._throwAndEmitError(\n Error(\n `Cannot reorder children for suspense node \"${id}\" because no matching node was found in the Store.`,\n@@ -1996,6 +2012,7 @@ export default class Store extends EventEmitter<{\n \n const children = suspense.children;\n if (children.length !== numChildren) {\n+ \/\/ We should never reach this. This is a bug in the backend renderer.\n this._throwAndEmitError(\n Error(\n `Suspense children cannot be added or removed during a reorder operation.`,\n@@ -2036,6 +2053,7 @@ export default class Store extends EventEmitter<{\n \n const suspense = this._idToSuspense.get(id);\n if (suspense === undefined) {\n+ \/\/ We should never reach this. This is a bug in the backend renderer.\n this._throwAndEmitError(\n Error(\n `Cannot set rects for suspense node \"${id}\" because no matching node was found in the Store.`,\n@@ -2123,6 +2141,7 @@ export default class Store extends EventEmitter<{\n const suspense = this._idToSuspense.get(id);\n \n if (suspense === undefined) {\n+ \/\/ We should never reach this. This is a bug in the backend renderer.\n this._throwAndEmitError(\n Error(\n `Cannot update suspenders of suspense node \"${id}\" because no matching node was found in the Store.`,\n"}

dillon1000/react

Files changed