dillon1000/react
Commit
Browse files Remove `debugRenderPhaseSideEffects` flag (#17270)
There are two similar flags, `debugRenderPhaseSideEffects` and `debugRenderPhaseSideEffectsForStrictMode`. The strict mode one is the only one that is actually used. I think originally the theory is that we would one day turn it on for all components, even outside strict mode. But what we'll do instead is migrate everyone to strict mode. The only place `debugRenderPhaseSideEffects` was being used was in an internal test file. I rewrote those tests to use public APIs.
Changed paths15 files
First-parent comparisonpackages/react-reconciler/src/ReactFiberBeginWork.js ModifiedM packages/react-reconciler/src/ReactFiberClassComponent.js ModifiedM packages/react-reconciler/src/ReactUpdateQueue.js ModifiedM packages/react/src/__tests__/ReactDOMTracing-test.internal.js ModifiedM packages/react/src/__tests__/ReactProfiler-test.internal.js ModifiedM packages/react/src/__tests__/ReactProfilerDOM-test.internal.js ModifiedD packages/react/src/__tests__/ReactStrictMode-test.internal.js DeletedM packages/react/src/__tests__/ReactStrictMode-test.js ModifiedM packages/shared/ReactFeatureFlags.js ModifiedM packages/shared/forks/ReactFeatureFlags.native-fb.js ModifiedM packages/shared/forks/ReactFeatureFlags.native-oss.js ModifiedM packages/shared/forks/ReactFeatureFlags.persistent.js ModifiedM packages/shared/forks/ReactFeatureFlags.test-renderer.js ModifiedM packages/shared/forks/ReactFeatureFlags.test-renderer.www.js ModifiedM packages/shared/forks/ReactFeatureFlags.www.js ModifiedPatch
Files changed
Rendering syntax-highlighted changes…