{"body":"These feature flags are fully rolled out and easy to clean up. Let's\r\nremove them!","parents":["7002a6743ebb24ed55af8f626c89dd39460230fc"],"patch":"diff --git a\/packages\/react-dom\/src\/__tests__\/ReactComponent-test.js b\/packages\/react-dom\/src\/__tests__\/ReactComponent-test.js\nindex 4df1b8dfc1..1c95f08862 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactComponent-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactComponent-test.js\n@@ -12,7 +12,6 @@\n let React;\n let ReactDOM;\n let ReactDOMServer;\n-let ReactFeatureFlags;\n let ReactTestUtils;\n \n describe('ReactComponent', () => {\n@@ -22,7 +21,6 @@ describe('ReactComponent', () => {\n React = require('react');\n ReactDOM = require('react-dom');\n ReactDOMServer = require('react-dom\/server');\n- ReactFeatureFlags = require('shared\/ReactFeatureFlags');\n ReactTestUtils = require('react-dom\/test-utils');\n });\n \n@@ -137,24 +135,20 @@ describe('ReactComponent', () => {\n \n expect(() => {\n ReactTestUtils.renderIntoDocument();\n- }).toErrorDev(\n- ReactFeatureFlags.warnAboutStringRefs\n- ? [\n- 'Warning: Component \"div\" contains the string ref \"inner\". ' +\n- 'Support for string refs will be removed in a future major release. ' +\n- 'We recommend using useRef() or createRef() instead. ' +\n- 'Learn more about using refs safely here: https:\/\/reactjs.org\/link\/strict-mode-string-ref\\n' +\n- ' in div (at **)\\n' +\n- ' in Wrapper (at **)\\n' +\n- ' in Component (at **)',\n- 'Warning: Component \"Component\" contains the string ref \"outer\". ' +\n- 'Support for string refs will be removed in a future major release. ' +\n- 'We recommend using useRef() or createRef() instead. ' +\n- 'Learn more about using refs safely here: https:\/\/reactjs.org\/link\/strict-mode-string-ref\\n' +\n- ' in Component (at **)',\n- ]\n- : [],\n- );\n+ }).toErrorDev([\n+ 'Warning: Component \"div\" contains the string ref \"inner\". ' +\n+ 'Support for string refs will be removed in a future major release. ' +\n+ 'We recommend using useRef() or createRef() instead. ' +\n+ 'Learn more about using refs safely here: https:\/\/reactjs.org\/link\/strict-mode-string-ref\\n' +\n+ ' in div (at **)\\n' +\n+ ' in Wrapper (at **)\\n' +\n+ ' in Component (at **)',\n+ 'Warning: Component \"Component\" contains the string ref \"outer\". ' +\n+ 'Support for string refs will be removed in a future major release. ' +\n+ 'We recommend using useRef() or createRef() instead. ' +\n+ 'Learn more about using refs safely here: https:\/\/reactjs.org\/link\/strict-mode-string-ref\\n' +\n+ ' in Component (at **)',\n+ ]);\n });\n \n it('should not have string refs on unmounted components', () => {\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationRefs-test.js b\/packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationRefs-test.js\nindex 041dc9ebe7..9dc12c71f2 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationRefs-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationRefs-test.js\n@@ -14,7 +14,6 @@ const ReactDOMServerIntegrationUtils = require('.\/utils\/ReactDOMServerIntegratio\n let React;\n let ReactDOM;\n let ReactDOMServer;\n-let ReactFeatureFlags;\n let ReactTestUtils;\n \n function initModules() {\n@@ -23,7 +22,6 @@ function initModules() {\n React = require('react');\n ReactDOM = require('react-dom');\n ReactDOMServer = require('react-dom\/server');\n- ReactFeatureFlags = require('shared\/ReactFeatureFlags');\n ReactTestUtils = require('react-dom\/test-utils');\n \n \/\/ Make them available to the helpers.\n@@ -99,17 +97,13 @@ describe('ReactDOMServerIntegration', () => {\n root,\n true,\n );\n- }).toErrorDev(\n- ReactFeatureFlags.warnAboutStringRefs\n- ? [\n- 'Warning: Component \"RefsComponent\" contains the string ref \"myDiv\". ' +\n- 'Support for string refs will be removed in a future major release. ' +\n- 'We recommend using useRef() or createRef() instead. ' +\n- 'Learn more about using refs safely here: https:\/\/reactjs.org\/link\/strict-mode-string-ref\\n' +\n- ' in RefsComponent (at **)',\n- ]\n- : [],\n- );\n+ }).toErrorDev([\n+ 'Warning: Component \"RefsComponent\" contains the string ref \"myDiv\". ' +\n+ 'Support for string refs will be removed in a future major release. ' +\n+ 'We recommend using useRef() or createRef() instead. ' +\n+ 'Learn more about using refs safely here: https:\/\/reactjs.org\/link\/strict-mode-string-ref\\n' +\n+ ' in RefsComponent (at **)',\n+ ]);\n expect(component.refs.myDiv).toBe(root.firstChild);\n });\n });\ndiff --git a\/packages\/react-dom\/src\/__tests__\/refs-test.js b\/packages\/react-dom\/src\/__tests__\/refs-test.js\nindex 363005f066..a8af8cfd66 100644\n--- a\/packages\/react-dom\/src\/__tests__\/refs-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/refs-test.js\n@@ -123,28 +123,24 @@ describe('reactiverefs', () => {\n let testRefsComponent;\n expect(() => {\n testRefsComponent = ReactDOM.render(, container);\n- }).toErrorDev(\n- ReactFeatureFlags.warnAboutStringRefs\n- ? [\n- 'Warning: Component \"div\" contains the string ref \"resetDiv\". ' +\n- 'Support for string refs will be removed in a future major release. ' +\n- 'We recommend using useRef() or createRef() instead. ' +\n- 'Learn more about using refs safely here: https:\/\/reactjs.org\/link\/strict-mode-string-ref\\n' +\n- ' in div (at **)\\n' +\n- ' in TestRefsComponent (at **)',\n- 'Warning: Component \"span\" contains the string ref \"clickLog0\". ' +\n- 'Support for string refs will be removed in a future major release. ' +\n- 'We recommend using useRef() or createRef() instead. ' +\n- 'Learn more about using refs safely here: https:\/\/reactjs.org\/link\/strict-mode-string-ref\\n' +\n- ' in span (at **)\\n' +\n- ' in ClickCounter (at **)\\n' +\n- ' in div (at **)\\n' +\n- ' in GeneralContainerComponent (at **)\\n' +\n- ' in div (at **)\\n' +\n- ' in TestRefsComponent (at **)',\n- ]\n- : [],\n- );\n+ }).toErrorDev([\n+ 'Warning: Component \"div\" contains the string ref \"resetDiv\". ' +\n+ 'Support for string refs will be removed in a future major release. ' +\n+ 'We recommend using useRef() or createRef() instead. ' +\n+ 'Learn more about using refs safely here: https:\/\/reactjs.org\/link\/strict-mode-string-ref\\n' +\n+ ' in div (at **)\\n' +\n+ ' in TestRefsComponent (at **)',\n+ 'Warning: Component \"span\" contains the string ref \"clickLog0\". ' +\n+ 'Support for string refs will be removed in a future major release. ' +\n+ 'We recommend using useRef() or createRef() instead. ' +\n+ 'Learn more about using refs safely here: https:\/\/reactjs.org\/link\/strict-mode-string-ref\\n' +\n+ ' in span (at **)\\n' +\n+ ' in ClickCounter (at **)\\n' +\n+ ' in div (at **)\\n' +\n+ ' in GeneralContainerComponent (at **)\\n' +\n+ ' in div (at **)\\n' +\n+ ' in TestRefsComponent (at **)',\n+ ]);\n \n expect(testRefsComponent instanceof TestRefsComponent).toBe(true);\n \n@@ -349,17 +345,13 @@ describe('ref swapping', () => {\n let a;\n expect(() => {\n a = ReactTestUtils.renderIntoDocument();\n- }).toErrorDev(\n- ReactFeatureFlags.warnAboutStringRefs\n- ? [\n- 'Warning: Component \"A\" contains the string ref \"1\". ' +\n- 'Support for string refs will be removed in a future major release. ' +\n- 'We recommend using useRef() or createRef() instead. ' +\n- 'Learn more about using refs safely here: https:\/\/reactjs.org\/link\/strict-mode-string-ref\\n' +\n- ' in A (at **)',\n- ]\n- : [],\n- );\n+ }).toErrorDev([\n+ 'Warning: Component \"A\" contains the string ref \"1\". ' +\n+ 'Support for string refs will be removed in a future major release. ' +\n+ 'We recommend using useRef() or createRef() instead. ' +\n+ 'Learn more about using refs safely here: https:\/\/reactjs.org\/link\/strict-mode-string-ref\\n' +\n+ ' in A (at **)',\n+ ]);\n expect(a.refs[1].nodeName).toBe('DIV');\n });\n \n@@ -546,18 +538,14 @@ describe('strings refs across renderers', () => {\n let inst;\n expect(() => {\n inst = ReactDOM.render(, div1);\n- }).toErrorDev(\n- ReactFeatureFlags.warnAboutStringRefs\n- ? [\n- 'Warning: Component \"Indirection\" contains the string ref \"child1\". ' +\n- 'Support for string refs will be removed in a future major release. ' +\n- 'We recommend using useRef() or createRef() instead. ' +\n- 'Learn more about using refs safely here: https:\/\/reactjs.org\/link\/strict-mode-string-ref\\n' +\n- ' in Indirection (at **)\\n' +\n- ' in Parent (at **)',\n- ]\n- : [],\n- );\n+ }).toErrorDev([\n+ 'Warning: Component \"Indirection\" contains the string ref \"child1\". ' +\n+ 'Support for string refs will be removed in a future major release. ' +\n+ 'We recommend using useRef() or createRef() instead. ' +\n+ 'Learn more about using refs safely here: https:\/\/reactjs.org\/link\/strict-mode-string-ref\\n' +\n+ ' in Indirection (at **)\\n' +\n+ ' in Parent (at **)',\n+ ]);\n \n \/\/ Only the first ref has rendered yet.\n expect(inst.refs.child1.tagName).toBe('DIV');\n@@ -567,14 +555,12 @@ describe('strings refs across renderers', () => {\n \/\/ Now both refs should be rendered.\n ReactDOM.render(, div1);\n }).toErrorDev(\n- ReactFeatureFlags.warnAboutStringRefs\n- ? [\n- 'Warning: Component \"Root\" contains the string ref \"child2\". ' +\n- 'Support for string refs will be removed in a future major release. ' +\n- 'We recommend using useRef() or createRef() instead. ' +\n- 'Learn more about using refs safely here: https:\/\/reactjs.org\/link\/strict-mode-string-ref',\n- ]\n- : [],\n+ [\n+ 'Warning: Component \"Root\" contains the string ref \"child2\". ' +\n+ 'Support for string refs will be removed in a future major release. ' +\n+ 'We recommend using useRef() or createRef() instead. ' +\n+ 'Learn more about using refs safely here: https:\/\/reactjs.org\/link\/strict-mode-string-ref',\n+ ],\n {withoutStack: true},\n );\n expect(inst.refs.child1.tagName).toBe('DIV');\ndiff --git a\/packages\/react-reconciler\/src\/ReactChildFiber.js b\/packages\/react-reconciler\/src\/ReactChildFiber.js\nindex 6d9c6e83f9..71362afb8a 100644\n--- a\/packages\/react-reconciler\/src\/ReactChildFiber.js\n+++ b\/packages\/react-reconciler\/src\/ReactChildFiber.js\n@@ -28,7 +28,6 @@ import {\n } from 'shared\/ReactSymbols';\n import {ClassComponent, HostText, HostPortal, Fragment} from '.\/ReactWorkTags';\n import isArray from 'shared\/isArray';\n-import {warnAboutStringRefs} from 'shared\/ReactFeatureFlags';\n import {checkPropStringCoercion} from 'shared\/CheckStringCoercion';\n \n import {\n@@ -40,7 +39,6 @@ import {\n createFiberFromPortal,\n } from '.\/ReactFiber';\n import {isCompatibleFamilyForHotReloading} from '.\/ReactFiberHotReloading';\n-import {StrictLegacyMode} from '.\/ReactTypeOfMode';\n import {getIsHydrating} from '.\/ReactFiberHydrationContext';\n import {pushTreeFork} from '.\/ReactFiberTreeContext';\n \n@@ -113,10 +111,7 @@ function coerceRef(\n typeof mixedRef !== 'object'\n ) {\n if (__DEV__) {\n- \/\/ TODO: Clean this up once we turn on the string ref warning for\n- \/\/ everyone, because the strict mode case will no longer be relevant\n if (\n- (returnFiber.mode & StrictLegacyMode || warnAboutStringRefs) &&\n \/\/ We warn in ReactElement.js if owner and self are equal for string refs\n \/\/ because these cannot be automatically converted to an arrow function\n \/\/ using a codemod. Therefore, we don't have to warn about string refs again.\n@@ -138,26 +133,15 @@ function coerceRef(\n const componentName =\n getComponentNameFromFiber(returnFiber) || 'Component';\n if (!didWarnAboutStringRefs[componentName]) {\n- if (warnAboutStringRefs) {\n- console.error(\n- 'Component \"%s\" contains the string ref \"%s\". Support for string refs ' +\n- 'will be removed in a future major release. We recommend using ' +\n- 'useRef() or createRef() instead. ' +\n- 'Learn more about using refs safely here: ' +\n- 'https:\/\/reactjs.org\/link\/strict-mode-string-ref',\n- componentName,\n- mixedRef,\n- );\n- } else {\n- console.error(\n- 'A string ref, \"%s\", has been found within a strict mode tree. ' +\n- 'String refs are a source of potential bugs and should be avoided. ' +\n- 'We recommend using useRef() or createRef() instead. ' +\n- 'Learn more about using refs safely here: ' +\n- 'https:\/\/reactjs.org\/link\/strict-mode-string-ref',\n- mixedRef,\n- );\n- }\n+ console.error(\n+ 'Component \"%s\" contains the string ref \"%s\". Support for string refs ' +\n+ 'will be removed in a future major release. We recommend using ' +\n+ 'useRef() or createRef() instead. ' +\n+ 'Learn more about using refs safely here: ' +\n+ 'https:\/\/reactjs.org\/link\/strict-mode-string-ref',\n+ componentName,\n+ mixedRef,\n+ );\n didWarnAboutStringRefs[componentName] = true;\n }\n }\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberBeginWork.js b\/packages\/react-reconciler\/src\/ReactFiberBeginWork.js\nindex fc593516be..6a7c147ff3 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberBeginWork.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberBeginWork.js\n@@ -97,7 +97,6 @@ import {\n disableModulePatternComponents,\n enableProfilerCommitHooks,\n enableProfilerTimer,\n- warnAboutDefaultPropsOnFunctionComponents,\n enableScopeAPI,\n enableCache,\n enableLazyContextPropagation,\n@@ -506,10 +505,7 @@ function updateMemoComponent(\n getComponentNameFromType(type),\n );\n }\n- if (\n- warnAboutDefaultPropsOnFunctionComponents &&\n- Component.defaultProps !== undefined\n- ) {\n+ if (Component.defaultProps !== undefined) {\n const componentName = getComponentNameFromType(type) || 'Unknown';\n if (!didWarnAboutDefaultPropsOnFunctionComponent[componentName]) {\n console.error(\n@@ -2058,10 +2054,7 @@ function validateFunctionComponentInDev(workInProgress: Fiber, Component: any) {\n }\n }\n \n- if (\n- warnAboutDefaultPropsOnFunctionComponents &&\n- Component.defaultProps !== undefined\n- ) {\n+ if (Component.defaultProps !== undefined) {\n const componentName = getComponentNameFromType(Component) || 'Unknown';\n \n if (!didWarnAboutDefaultPropsOnFunctionComponent[componentName]) {\ndiff --git a\/packages\/react-reconciler\/src\/__tests__\/ReactIncrementalSideEffects-test.js b\/packages\/react-reconciler\/src\/__tests__\/ReactIncrementalSideEffects-test.js\nindex 6bac75ab30..1203c9494c 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ReactIncrementalSideEffects-test.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ReactIncrementalSideEffects-test.js\n@@ -11,7 +11,6 @@\n 'use strict';\n \n let React;\n-let ReactFeatureFlags;\n let ReactNoop;\n let Scheduler;\n \n@@ -20,7 +19,6 @@ describe('ReactIncrementalSideEffects', () => {\n jest.resetModules();\n \n React = require('react');\n- ReactFeatureFlags = require('shared\/ReactFeatureFlags');\n ReactNoop = require('react-noop-renderer');\n Scheduler = require('scheduler');\n });\n@@ -1310,17 +1308,13 @@ describe('ReactIncrementalSideEffects', () => {\n ReactNoop.render();\n expect(() => {\n expect(Scheduler).toFlushWithoutYielding();\n- }).toErrorDev(\n- ReactFeatureFlags.warnAboutStringRefs\n- ? [\n- 'Warning: Component \"Foo\" contains the string ref \"bar\". ' +\n- 'Support for string refs will be removed in a future major release. ' +\n- 'We recommend using useRef() or createRef() instead. ' +\n- 'Learn more about using refs safely here: https:\/\/reactjs.org\/link\/strict-mode-string-ref\\n' +\n- ' in Foo (at **)',\n- ]\n- : [],\n- );\n+ }).toErrorDev([\n+ 'Warning: Component \"Foo\" contains the string ref \"bar\". ' +\n+ 'Support for string refs will be removed in a future major release. ' +\n+ 'We recommend using useRef() or createRef() instead. ' +\n+ 'Learn more about using refs safely here: https:\/\/reactjs.org\/link\/strict-mode-string-ref\\n' +\n+ ' in Foo (at **)',\n+ ]);\n expect(fooInstance.refs.bar.test).toEqual('test');\n });\n });\ndiff --git a\/packages\/react-server\/src\/ReactFizzServer.js b\/packages\/react-server\/src\/ReactFizzServer.js\nindex d0ad4ec09c..281e8bf342 100644\n--- a\/packages\/react-server\/src\/ReactFizzServer.js\n+++ b\/packages\/react-server\/src\/ReactFizzServer.js\n@@ -129,7 +129,6 @@ import ReactSharedInternals from 'shared\/ReactSharedInternals';\n import {\n disableLegacyContext,\n disableModulePatternComponents,\n- warnAboutDefaultPropsOnFunctionComponents,\n enableScopeAPI,\n enableSuspenseAvoidThisFallbackFizz,\n enableFloat,\n@@ -949,10 +948,7 @@ function validateFunctionComponentInDev(Component: any): void {\n }\n }\n \n- if (\n- warnAboutDefaultPropsOnFunctionComponents &&\n- Component.defaultProps !== undefined\n- ) {\n+ if (Component.defaultProps !== undefined) {\n const componentName = getComponentNameFromType(Component) || 'Unknown';\n \n if (!didWarnAboutDefaultPropsOnFunctionComponent[componentName]) {\ndiff --git a\/packages\/react\/src\/__tests__\/ReactCoffeeScriptClass-test.coffee b\/packages\/react\/src\/__tests__\/ReactCoffeeScriptClass-test.coffee\nindex 0fd7e0b1e2..5bd9b24d52 100644\n--- a\/packages\/react\/src\/__tests__\/ReactCoffeeScriptClass-test.coffee\n+++ b\/packages\/react\/src\/__tests__\/ReactCoffeeScriptClass-test.coffee\n@@ -9,7 +9,6 @@ PropTypes = null\n React = null\n ReactDOM = null\n ReactDOMClient = null\n-ReactFeatureFlags = null\n act = null\n \n describe 'ReactCoffeeScriptClass', ->\n@@ -23,7 +22,6 @@ describe 'ReactCoffeeScriptClass', ->\n React = require 'react'\n ReactDOM = require 'react-dom'\n ReactDOMClient = require 'react-dom\/client'\n- ReactFeatureFlags = require 'shared\/ReactFeatureFlags'\n act = require('jest-react').act\n PropTypes = require 'prop-types'\n container = document.createElement 'div'\n@@ -545,17 +543,13 @@ describe 'ReactCoffeeScriptClass', ->\n ref = React.createRef()\n expect(->\n test(React.createElement(Foo, ref: ref), 'DIV', 'foo')\n- ).toErrorDev(\n- if ReactFeatureFlags.warnAboutStringRefs\n- then [\n- 'Warning: Component \"Foo\" contains the string ref \"inner\". ' +\n- 'Support for string refs will be removed in a future major release. ' +\n- 'We recommend using useRef() or createRef() instead. ' +\n- 'Learn more about using refs safely here: https:\/\/reactjs.org\/link\/strict-mode-string-ref\\n' +\n- ' in Foo (at **)'\n- ]\n- else []\n- );\n+ ).toErrorDev([\n+ 'Warning: Component \"Foo\" contains the string ref \"inner\". ' +\n+ 'Support for string refs will be removed in a future major release. ' +\n+ 'We recommend using useRef() or createRef() instead. ' +\n+ 'Learn more about using refs safely here: https:\/\/reactjs.org\/link\/strict-mode-string-ref\\n' +\n+ ' in Foo (at **)'\n+ ]);\n expect(ref.current.refs.inner.getName()).toBe 'foo'\n \n it 'supports drilling through to the DOM using findDOMNode', ->\ndiff --git a\/packages\/react\/src\/__tests__\/ReactES6Class-test.js b\/packages\/react\/src\/__tests__\/ReactES6Class-test.js\nindex 6c23038205..6ccf7ce4c6 100644\n--- a\/packages\/react\/src\/__tests__\/ReactES6Class-test.js\n+++ b\/packages\/react\/src\/__tests__\/ReactES6Class-test.js\n@@ -13,7 +13,6 @@ let PropTypes;\n let React;\n let ReactDOM;\n let ReactDOMClient;\n-let ReactFeatureFlags;\n let act;\n \n describe('ReactES6Class', () => {\n@@ -32,7 +31,6 @@ describe('ReactES6Class', () => {\n React = require('react');\n ReactDOM = require('react-dom');\n ReactDOMClient = require('react-dom\/client');\n- ReactFeatureFlags = require('shared\/ReactFeatureFlags');\n act = require('jest-react').act;\n container = document.createElement('div');\n root = ReactDOMClient.createRoot(container);\n@@ -587,17 +585,13 @@ describe('ReactES6Class', () => {\n const ref = React.createRef();\n expect(() => {\n test(, 'DIV', 'foo');\n- }).toErrorDev(\n- ReactFeatureFlags.warnAboutStringRefs\n- ? [\n- 'Warning: Component \"Foo\" contains the string ref \"inner\". ' +\n- 'Support for string refs will be removed in a future major release. ' +\n- 'We recommend using useRef() or createRef() instead. ' +\n- 'Learn more about using refs safely here: https:\/\/reactjs.org\/link\/strict-mode-string-ref\\n' +\n- ' in Foo (at **)',\n- ]\n- : [],\n- );\n+ }).toErrorDev([\n+ 'Warning: Component \"Foo\" contains the string ref \"inner\". ' +\n+ 'Support for string refs will be removed in a future major release. ' +\n+ 'We recommend using useRef() or createRef() instead. ' +\n+ 'Learn more about using refs safely here: https:\/\/reactjs.org\/link\/strict-mode-string-ref\\n' +\n+ ' in Foo (at **)',\n+ ]);\n expect(ref.current.refs.inner.getName()).toBe('foo');\n });\n \ndiff --git a\/packages\/react\/src\/__tests__\/ReactStrictMode-test.js b\/packages\/react\/src\/__tests__\/ReactStrictMode-test.js\nindex b41497ae3a..e3553e6154 100644\n--- a\/packages\/react\/src\/__tests__\/ReactStrictMode-test.js\n+++ b\/packages\/react\/src\/__tests__\/ReactStrictMode-test.js\n@@ -926,18 +926,11 @@ describe('string refs', () => {\n expect(() => {\n ReactDOM.render(, container);\n }).toErrorDev(\n- ReactFeatureFlags.warnAboutStringRefs\n- ? 'Warning: Component \"StrictMode\" contains the string ref \"somestring\". ' +\n- 'Support for string refs will be removed in a future major release. ' +\n- 'We recommend using useRef() or createRef() instead. ' +\n- 'Learn more about using refs safely here: https:\/\/reactjs.org\/link\/strict-mode-string-ref\\n' +\n- ' in OuterComponent (at **)'\n- : 'Warning: A string ref, \"somestring\", has been found within a strict mode tree. ' +\n- 'String refs are a source of potential bugs and should be avoided. ' +\n- 'We recommend using useRef() or createRef() instead. ' +\n- 'Learn more about using refs safely here: ' +\n- 'https:\/\/reactjs.org\/link\/strict-mode-string-ref\\n' +\n- ' in OuterComponent (at **)',\n+ 'Warning: Component \"StrictMode\" contains the string ref \"somestring\". ' +\n+ 'Support for string refs will be removed in a future major release. ' +\n+ 'We recommend using useRef() or createRef() instead. ' +\n+ 'Learn more about using refs safely here: https:\/\/reactjs.org\/link\/strict-mode-string-ref\\n' +\n+ ' in OuterComponent (at **)',\n );\n \n \/\/ Dedup\n@@ -973,20 +966,12 @@ describe('string refs', () => {\n expect(() => {\n ReactDOM.render(, container);\n }).toErrorDev(\n- ReactFeatureFlags.warnAboutStringRefs\n- ? 'Warning: Component \"InnerComponent\" contains the string ref \"somestring\". ' +\n- 'Support for string refs will be removed in a future major release. ' +\n- 'We recommend using useRef() or createRef() instead. ' +\n- 'Learn more about using refs safely here: https:\/\/reactjs.org\/link\/strict-mode-string-ref\\n' +\n- ' in InnerComponent (at **)\\n' +\n- ' in OuterComponent (at **)'\n- : 'Warning: A string ref, \"somestring\", has been found within a strict mode tree. ' +\n- 'String refs are a source of potential bugs and should be avoided. ' +\n- 'We recommend using useRef() or createRef() instead. ' +\n- 'Learn more about using refs safely here: ' +\n- 'https:\/\/reactjs.org\/link\/strict-mode-string-ref\\n' +\n- ' in InnerComponent (at **)\\n' +\n- ' in OuterComponent (at **)',\n+ 'Warning: Component \"InnerComponent\" contains the string ref \"somestring\". ' +\n+ 'Support for string refs will be removed in a future major release. ' +\n+ 'We recommend using useRef() or createRef() instead. ' +\n+ 'Learn more about using refs safely here: https:\/\/reactjs.org\/link\/strict-mode-string-ref\\n' +\n+ ' in InnerComponent (at **)\\n' +\n+ ' in OuterComponent (at **)',\n );\n \n \/\/ Dedup\ndiff --git a\/packages\/react\/src\/__tests__\/ReactTypeScriptClass-test.ts b\/packages\/react\/src\/__tests__\/ReactTypeScriptClass-test.ts\nindex 39304e9d6f..dfea3cea47 100644\n--- a\/packages\/react\/src\/__tests__\/ReactTypeScriptClass-test.ts\n+++ b\/packages\/react\/src\/__tests__\/ReactTypeScriptClass-test.ts\n@@ -17,7 +17,6 @@ import ReactDOMClient = require('react-dom\/client');\n import ReactDOMTestUtils = require('react-dom\/test-utils');\n import PropTypes = require('prop-types');\n import internalAct = require('jest-react');\n-import ReactFeatureFlags = require('shared\/ReactFeatureFlags')\n \n \/\/ Before Each\n \n@@ -691,17 +690,13 @@ describe('ReactTypeScriptClass', function() {\n const ref = React.createRef();\n expect(() => {\n test(React.createElement(ClassicRefs, {ref: ref}), 'DIV', 'foo');\n- }).toErrorDev(\n- ReactFeatureFlags.warnAboutStringRefs\n- ? [\n- 'Warning: Component \"ClassicRefs\" contains the string ref \"inner\". ' +\n- 'Support for string refs will be removed in a future major release. ' +\n- 'We recommend using useRef() or createRef() instead. ' +\n- 'Learn more about using refs safely here: https:\/\/reactjs.org\/link\/strict-mode-string-ref\\n' +\n- ' in ClassicRefs (at **)',\n- ]\n- : [],\n- );\n+ }).toErrorDev([\n+ 'Warning: Component \"ClassicRefs\" contains the string ref \"inner\". ' +\n+ 'Support for string refs will be removed in a future major release. ' +\n+ 'We recommend using useRef() or createRef() instead. ' +\n+ 'Learn more about using refs safely here: https:\/\/reactjs.org\/link\/strict-mode-string-ref\\n' +\n+ ' in ClassicRefs (at **)',\n+ ]);\n expect(ref.current.refs.inner.getName()).toBe('foo');\n });\n \ndiff --git a\/packages\/shared\/ReactFeatureFlags.js b\/packages\/shared\/ReactFeatureFlags.js\nindex dd01bb14e4..18f38d3aa8 100644\n--- a\/packages\/shared\/ReactFeatureFlags.js\n+++ b\/packages\/shared\/ReactFeatureFlags.js\n@@ -207,17 +207,10 @@ export const disableTextareaChildren = false;\n \n \/\/ New API for JSX transforms to target - https:\/\/github.com\/reactjs\/rfcs\/pull\/107\n \n-\/\/ Part of the simplification of React.createElement so we can eventually move\n-\/\/ from React.createElement to React.jsx\n-\/\/ https:\/\/github.com\/reactjs\/rfcs\/blob\/createlement-rfc\/text\/0000-create-element-changes.md\n-export const warnAboutDefaultPropsOnFunctionComponents = true; \/\/ deprecate later, not 18.0\n-\n \/\/ Enables a warning when trying to spread a 'key' to an element;\n \/\/ a deprecated pattern we want to get rid of in the future\n export const warnAboutSpreadingKeyToJSX = true;\n \n-export const warnAboutStringRefs = true;\n-\n \/\/ -----------------------------------------------------------------------------\n \/\/ Debugging and DevTools\n \/\/ -----------------------------------------------------------------------------\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js b\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\nindex 9fe2bdcfcd..056672c914 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.native-fb.js\n@@ -40,8 +40,6 @@ export const replayFailedUnitOfWorkWithInvokeGuardedCallback = __DEV__;\n export const enableScopeAPI = false;\n export const enableCreateEventHandleAPI = false;\n export const enableSuspenseCallback = false;\n-export const warnAboutDefaultPropsOnFunctionComponents = true;\n-export const warnAboutStringRefs = true;\n export const disableLegacyContext = false;\n export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;\n export const enableTrustedTypesIntegration = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js b\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\nindex 3d403ab509..97723bdc9d 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.native-oss.js\n@@ -30,8 +30,6 @@ export const enableSchedulerDebugging = false;\n export const enableScopeAPI = false;\n export const enableCreateEventHandleAPI = false;\n export const enableSuspenseCallback = false;\n-export const warnAboutDefaultPropsOnFunctionComponents = true;\n-export const warnAboutStringRefs = true;\n export const disableLegacyContext = false;\n export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;\n export const enableTrustedTypesIntegration = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\nindex 907351d710..8941aa4b39 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js\n@@ -30,8 +30,6 @@ export const enableSchedulerDebugging = false;\n export const enableScopeAPI = false;\n export const enableCreateEventHandleAPI = false;\n export const enableSuspenseCallback = false;\n-export const warnAboutDefaultPropsOnFunctionComponents = true;\n-export const warnAboutStringRefs = true;\n export const disableLegacyContext = false;\n export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;\n export const enableTrustedTypesIntegration = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js\nindex 34f467ab30..faa6aa3ebf 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js\n@@ -30,8 +30,6 @@ export const enableSchedulerDebugging = false;\n export const enableScopeAPI = false;\n export const enableCreateEventHandleAPI = false;\n export const enableSuspenseCallback = false;\n-export const warnAboutDefaultPropsOnFunctionComponents = true;\n-export const warnAboutStringRefs = true;\n export const disableLegacyContext = false;\n export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;\n export const enableTrustedTypesIntegration = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\nindex b7eecfaeef..9d97f6cba6 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js\n@@ -30,8 +30,6 @@ export const disableInputAttributeSyncing = false;\n export const enableScopeAPI = true;\n export const enableCreateEventHandleAPI = false;\n export const enableSuspenseCallback = true;\n-export const warnAboutDefaultPropsOnFunctionComponents = true;\n-export const warnAboutStringRefs = true;\n export const disableLegacyContext = false;\n export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;\n export const enableTrustedTypesIntegration = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.testing.js b\/packages\/shared\/forks\/ReactFeatureFlags.testing.js\nindex 0f17f71b0d..bf00a16769 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.testing.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.testing.js\n@@ -30,8 +30,6 @@ export const enableSchedulerDebugging = false;\n export const enableScopeAPI = false;\n export const enableCreateEventHandleAPI = false;\n export const enableSuspenseCallback = false;\n-export const warnAboutDefaultPropsOnFunctionComponents = true;\n-export const warnAboutStringRefs = true;\n export const disableLegacyContext = false;\n export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;\n export const enableTrustedTypesIntegration = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.testing.www.js b\/packages\/shared\/forks\/ReactFeatureFlags.testing.www.js\nindex bffb42bf78..727d2b0770 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.testing.www.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.testing.www.js\n@@ -30,8 +30,6 @@ export const enableSchedulerDebugging = false;\n export const enableScopeAPI = true;\n export const enableCreateEventHandleAPI = true;\n export const enableSuspenseCallback = true;\n-export const warnAboutDefaultPropsOnFunctionComponents = true;\n-export const warnAboutStringRefs = true;\n export const disableLegacyContext = __EXPERIMENTAL__;\n export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;\n export const enableTrustedTypesIntegration = false;\ndiff --git a\/packages\/shared\/forks\/ReactFeatureFlags.www.js b\/packages\/shared\/forks\/ReactFeatureFlags.www.js\nindex 1ba6e4e3d1..d20c9fad93 100644\n--- a\/packages\/shared\/forks\/ReactFeatureFlags.www.js\n+++ b\/packages\/shared\/forks\/ReactFeatureFlags.www.js\n@@ -66,8 +66,6 @@ export const enableSchedulingProfiler: boolean =\n \/\/ At least this will let us stop shipping implementation to all users.\n export const enableSchedulerDebugging = true;\n export const disableLegacyContext = __EXPERIMENTAL__;\n-export const warnAboutStringRefs = true;\n-export const warnAboutDefaultPropsOnFunctionComponents = true;\n export const enableGetInspectorDataForInstanceInProduction = false;\n \n export const enableCache = true;\n","files":[{"status":"M","path":"packages\/react-dom\/src\/__tests__\/ReactComponent-test.js"},{"status":"M","path":"packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationRefs-test.js"},{"status":"M","path":"packages\/react-dom\/src\/__tests__\/refs-test.js"},{"status":"M","path":"packages\/react-reconciler\/src\/ReactChildFiber.js"},{"status":"M","path":"packages\/react-reconciler\/src\/ReactFiberBeginWork.js"},{"status":"M","path":"packages\/react-reconciler\/src\/__tests__\/ReactIncrementalSideEffects-test.js"},{"status":"M","path":"packages\/react-server\/src\/ReactFizzServer.js"},{"status":"M","path":"packages\/react\/src\/__tests__\/ReactCoffeeScriptClass-test.coffee"},{"status":"M","path":"packages\/react\/src\/__tests__\/ReactES6Class-test.js"},{"status":"M","path":"packages\/react\/src\/__tests__\/ReactStrictMode-test.js"},{"status":"M","path":"packages\/react\/src\/__tests__\/ReactTypeScriptClass-test.ts"},{"status":"M","path":"packages\/shared\/ReactFeatureFlags.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.native-fb.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.native-oss.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.testing.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.testing.www.js"},{"status":"M","path":"packages\/shared\/forks\/ReactFeatureFlags.www.js"}],"commit":{"shortRevision":"0fce6bb498","revision":"0fce6bb498357feb4465859912004b2e20fe7084","authorName":"Jan Kassens","authorEmail":"jkassens@meta.com","subject":"[cleanup] remove feature flags warnAboutDefaultPropsOnFunctionComponents and warnAboutStringRefs (#25980)","authoredAt":"2023-01-11T12:19:46-05:00"}}

dillon1000/react

Files changed