{"body":"No longer being used.","files":[{"path":"packages\/react-art\/src\/ReactARTHostConfig.js","status":"M"},{"path":"packages\/react-dom\/src\/__tests__\/ReactDOMServerPartialHydration-test.internal.js","status":"M"},{"path":"packages\/react-dom\/src\/__tests__\/ReactUpdates-test.js","status":"M"},{"path":"packages\/react-dom\/src\/client\/ReactDOMHostConfig.js","status":"M"},{"path":"packages\/react-native-renderer\/src\/ReactFabricHostConfig.js","status":"M"},{"path":"packages\/react-native-renderer\/src\/ReactNativeHostConfig.js","status":"M"},{"path":"packages\/react-noop-renderer\/src\/createReactNoop.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactIncremental-test.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactIncrementalErrorHandling-test.internal.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactIncrementalSideEffects-test.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactNewContext-test.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactSchedulerIntegration-test.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactSuspenseWithNoopRenderer-test.js","status":"M"},{"path":"packages\/react-reconciler\/src\/forks\/ReactFiberHostConfig.custom.js","status":"M"},{"path":"packages\/react-refresh\/src\/__tests__\/ReactFresh-test.js","status":"M"},{"path":"packages\/react-test-renderer\/src\/ReactTestHostConfig.js","status":"M"},{"path":"packages\/react\/src\/__tests__\/ReactDOMTracing-test.internal.js","status":"M"}],"parents":["8f05f2bd6d131a39835d468622e248b231ccbf8e"],"commit":{"revision":"103ed08c46198d01119ef35c37d78c6bc89705db","shortRevision":"103ed08c46","authoredAt":"2020-06-12T12:57:20-07:00","authorName":"Andrew Clark","subject":"Remove shouldDeprioritizeSubtree from host config (#19124)","authorEmail":"git@andrewclark.io"},"patch":"diff --git a\/packages\/react-art\/src\/ReactARTHostConfig.js b\/packages\/react-art\/src\/ReactARTHostConfig.js\nindex d8864397b7..fed5cf3cee 100644\n--- a\/packages\/react-art\/src\/ReactARTHostConfig.js\n+++ b\/packages\/react-art\/src\/ReactARTHostConfig.js\n@@ -323,10 +323,6 @@ export function resetTextContent(domElement) {\n \/\/ Noop\n }\n \n-export function shouldDeprioritizeSubtree(type, props) {\n- return false;\n-}\n-\n export function getRootHostContext() {\n return NO_CONTEXT;\n }\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactDOMServerPartialHydration-test.internal.js b\/packages\/react-dom\/src\/__tests__\/ReactDOMServerPartialHydration-test.internal.js\nindex f223e9e5a7..43c8c2de6c 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDOMServerPartialHydration-test.internal.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDOMServerPartialHydration-test.internal.js\n@@ -91,10 +91,7 @@ describe('ReactDOMServerPartialHydration', () => {\n \/\/ once the extra div wrapper is no longer neccessary.\n function LegacyHiddenDiv({children, mode}) {\n return (\n- \n+

\n \n {children}\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactUpdates-test.js b\/packages\/react-dom\/src\/__tests__\/ReactUpdates-test.js\nindex a3eb0455fc..174a22d92e 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactUpdates-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactUpdates-test.js\n@@ -29,10 +29,7 @@ describe('ReactUpdates', () => {\n \/\/ once the extra div wrapper is no longer neccessary.\n function LegacyHiddenDiv({children, mode}) {\n return (\n- \n+

\n \n {children}\ndiff --git a\/packages\/react-dom\/src\/client\/ReactDOMHostConfig.js b\/packages\/react-dom\/src\/client\/ReactDOMHostConfig.js\nindex 34e398268e..95ab9fe912 100644\n--- a\/packages\/react-dom\/src\/client\/ReactDOMHostConfig.js\n+++ b\/packages\/react-dom\/src\/client\/ReactDOMHostConfig.js\n@@ -371,12 +371,6 @@ export function shouldSetTextContent(type: string, props: Props): boolean {\n );\n }\n \n-export function shouldDeprioritizeSubtree(type: string, props: Props): boolean {\n- \/\/ This is obnoxiously specific so that nobody uses it, but we can still opt\n- \/\/ in via an infra-level userspace abstraction.\n- return props.hidden === 'unstable-do-not-use-legacy-hidden';\n-}\n-\n export function createTextInstance(\n text: string,\n rootContainerInstance: Container,\ndiff --git a\/packages\/react-native-renderer\/src\/ReactFabricHostConfig.js b\/packages\/react-native-renderer\/src\/ReactFabricHostConfig.js\nindex 2e7b8c7ab0..f25ed6a25a 100644\n--- a\/packages\/react-native-renderer\/src\/ReactFabricHostConfig.js\n+++ b\/packages\/react-native-renderer\/src\/ReactFabricHostConfig.js\n@@ -329,10 +329,6 @@ export function resetAfterCommit(containerInfo: Container): void {\n \/\/ Noop\n }\n \n-export function shouldDeprioritizeSubtree(type: string, props: Props): boolean {\n- return false;\n-}\n-\n export function shouldSetTextContent(type: string, props: Props): boolean {\n \/\/ TODO (bvaughn) Revisit this decision.\n \/\/ Always returning false simplifies the createInstance() implementation,\ndiff --git a\/packages\/react-native-renderer\/src\/ReactNativeHostConfig.js b\/packages\/react-native-renderer\/src\/ReactNativeHostConfig.js\nindex a5d3e6d176..36eb8421db 100644\n--- a\/packages\/react-native-renderer\/src\/ReactNativeHostConfig.js\n+++ b\/packages\/react-native-renderer\/src\/ReactNativeHostConfig.js\n@@ -248,10 +248,6 @@ export const scheduleTimeout = setTimeout;\n export const cancelTimeout = clearTimeout;\n export const noTimeout = -1;\n \n-export function shouldDeprioritizeSubtree(type: string, props: Props): boolean {\n- return false;\n-}\n-\n export function shouldSetTextContent(type: string, props: Props): boolean {\n \/\/ TODO (bvaughn) Revisit this decision.\n \/\/ Always returning false simplifies the createInstance() implementation,\ndiff --git a\/packages\/react-noop-renderer\/src\/createReactNoop.js b\/packages\/react-noop-renderer\/src\/createReactNoop.js\nindex 924fd22e2b..5c5e47bec8 100644\n--- a\/packages\/react-noop-renderer\/src\/createReactNoop.js\n+++ b\/packages\/react-noop-renderer\/src\/createReactNoop.js\n@@ -335,10 +335,6 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {\n \n shouldSetTextContent,\n \n- shouldDeprioritizeSubtree(type: string, props: Props): boolean {\n- return !!props.hidden;\n- },\n-\n createTextInstance(\n text: string,\n rootContainerInstance: Container,\ndiff --git a\/packages\/react-reconciler\/src\/__tests__\/ReactIncremental-test.js b\/packages\/react-reconciler\/src\/__tests__\/ReactIncremental-test.js\nindex 41dee63f24..7b9025554d 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ReactIncremental-test.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ReactIncremental-test.js\n@@ -28,10 +28,7 @@ describe('ReactIncremental', () => {\n \/\/ once the extra div wrapper is no longer neccessary.\n function LegacyHiddenDiv({children, mode}) {\n return (\n- \n+

\n \n {children}\ndiff --git a\/packages\/react-reconciler\/src\/__tests__\/ReactIncrementalErrorHandling-test.internal.js b\/packages\/react-reconciler\/src\/__tests__\/ReactIncrementalErrorHandling-test.internal.js\nindex 76ff7647ea..109f85d331 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ReactIncrementalErrorHandling-test.internal.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ReactIncrementalErrorHandling-test.internal.js\n@@ -49,10 +49,7 @@ describe('ReactIncrementalErrorHandling', () => {\n \/\/ once the extra div wrapper is no longer neccessary.\n function LegacyHiddenDiv({children, mode}) {\n return (\n- \n+

\n \n {children}\ndiff --git a\/packages\/react-reconciler\/src\/__tests__\/ReactIncrementalSideEffects-test.js b\/packages\/react-reconciler\/src\/__tests__\/ReactIncrementalSideEffects-test.js\nindex 6acd32d8b8..bcd35fb264 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ReactIncrementalSideEffects-test.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ReactIncrementalSideEffects-test.js\n@@ -42,10 +42,7 @@ describe('ReactIncrementalSideEffects', () => {\n \/\/ once the extra div wrapper is no longer neccessary.\n function LegacyHiddenDiv({children, mode}) {\n return (\n- \n+

\n \n {children}\ndiff --git a\/packages\/react-reconciler\/src\/__tests__\/ReactNewContext-test.js b\/packages\/react-reconciler\/src\/__tests__\/ReactNewContext-test.js\nindex a9bc6e4522..efd9943a45 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ReactNewContext-test.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ReactNewContext-test.js\n@@ -46,10 +46,7 @@ describe('ReactNewContext', () => {\n \/\/ once the extra div wrapper is no longer neccessary.\n function LegacyHiddenDiv({children, mode}) {\n return (\n- \n+

\n \n {children}\ndiff --git a\/packages\/react-reconciler\/src\/__tests__\/ReactSchedulerIntegration-test.js b\/packages\/react-reconciler\/src\/__tests__\/ReactSchedulerIntegration-test.js\nindex ef5853226e..8a9666932e 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ReactSchedulerIntegration-test.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ReactSchedulerIntegration-test.js\n@@ -57,10 +57,7 @@ describe('ReactSchedulerIntegration', () => {\n \/\/ once the extra div wrapper is no longer neccessary.\n function LegacyHiddenDiv({children, mode}) {\n return (\n- \n+

\n \n {children}\ndiff --git a\/packages\/react-reconciler\/src\/__tests__\/ReactSuspenseWithNoopRenderer-test.js b\/packages\/react-reconciler\/src\/__tests__\/ReactSuspenseWithNoopRenderer-test.js\nindex 6962f12811..342421bf36 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ReactSuspenseWithNoopRenderer-test.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ReactSuspenseWithNoopRenderer-test.js\n@@ -144,10 +144,7 @@ describe('ReactSuspenseWithNoopRenderer', () => {\n \/\/ once the extra div wrapper is no longer neccessary.\n function LegacyHiddenDiv({children, mode}) {\n return (\n- \n+

\n \n {children}\ndiff --git a\/packages\/react-reconciler\/src\/forks\/ReactFiberHostConfig.custom.js b\/packages\/react-reconciler\/src\/forks\/ReactFiberHostConfig.custom.js\nindex 2315cd6d98..d6f998634b 100644\n--- a\/packages\/react-reconciler\/src\/forks\/ReactFiberHostConfig.custom.js\n+++ b\/packages\/react-reconciler\/src\/forks\/ReactFiberHostConfig.custom.js\n@@ -51,8 +51,6 @@ export const appendInitialChild = $$$hostConfig.appendInitialChild;\n export const finalizeInitialChildren = $$$hostConfig.finalizeInitialChildren;\n export const prepareUpdate = $$$hostConfig.prepareUpdate;\n export const shouldSetTextContent = $$$hostConfig.shouldSetTextContent;\n-export const shouldDeprioritizeSubtree =\n- $$$hostConfig.shouldDeprioritizeSubtree;\n export const createTextInstance = $$$hostConfig.createTextInstance;\n export const scheduleTimeout = $$$hostConfig.scheduleTimeout;\n export const cancelTimeout = $$$hostConfig.cancelTimeout;\ndiff --git a\/packages\/react-refresh\/src\/__tests__\/ReactFresh-test.js b\/packages\/react-refresh\/src\/__tests__\/ReactFresh-test.js\nindex eed7a4a0f7..4c3c932c90 100644\n--- a\/packages\/react-refresh\/src\/__tests__\/ReactFresh-test.js\n+++ b\/packages\/react-refresh\/src\/__tests__\/ReactFresh-test.js\n@@ -79,10 +79,7 @@ describe('ReactFresh', () => {\n \/\/ once the extra div wrapper is no longer neccessary.\n function LegacyHiddenDiv({children, mode}) {\n return (\n-

dillon1000/react

Files changed