{"commit":{"subject":"Convert SimpleEventPlugin to createRoot (#28164)","authorName":"Sebastian Silbermann","authoredAt":"2024-01-30T22:22:02+01:00","revision":"13aae52aea07b59b17aebaf65fd83d1c67c6ecb4","shortRevision":"13aae52aea","authorEmail":"silbermann.sebastian@gmail.com"},"parents":["417188314dd1d6df54efc8cd6a0c5d4830615888"],"files":[{"status":"M","path":"packages\/react-dom\/src\/events\/plugins\/__tests__\/SimpleEventPlugin-test.js"}],"patch":"diff --git a\/packages\/react-dom\/src\/events\/plugins\/__tests__\/SimpleEventPlugin-test.js b\/packages\/react-dom\/src\/events\/plugins\/__tests__\/SimpleEventPlugin-test.js\nindex 5479f5192d..4cd9c8f27e 100644\n--- a\/packages\/react-dom\/src\/events\/plugins\/__tests__\/SimpleEventPlugin-test.js\n+++ b\/packages\/react-dom\/src\/events\/plugins\/__tests__\/SimpleEventPlugin-test.js\n@@ -11,7 +11,6 @@\n \n describe('SimpleEventPlugin', function () {\n let React;\n- let ReactDOM;\n let ReactDOMClient;\n let Scheduler;\n let act;\n@@ -21,8 +20,10 @@ describe('SimpleEventPlugin', function () {\n let assertLog;\n let waitForAll;\n \n- function expectClickThru(element) {\n- element.click();\n+ async function expectClickThru(element) {\n+ await act(() => {\n+ element.click();\n+ });\n expect(onClick).toHaveBeenCalledTimes(1);\n }\n \n@@ -31,23 +32,27 @@ describe('SimpleEventPlugin', function () {\n expect(onClick).toHaveBeenCalledTimes(0);\n }\n \n- function mounted(element) {\n+ async function mounted(element) {\n container = document.createElement('div');\n document.body.appendChild(container);\n- element = ReactDOM.render(element, container);\n+ const root = ReactDOMClient.createRoot(container);\n+ await act(() => {\n+ root.render(element);\n+ });\n+ element = container.firstChild;\n return element;\n }\n \n beforeEach(function () {\n jest.resetModules();\n React = require('react');\n- ReactDOM = require('react-dom');\n ReactDOMClient = require('react-dom\/client');\n Scheduler = require('scheduler');\n \n const InternalTestUtils = require('internal-test-utils');\n assertLog = InternalTestUtils.assertLog;\n waitForAll = InternalTestUtils.waitForAll;\n+ act = InternalTestUtils.act;\n \n onClick = jest.fn();\n });\n@@ -59,13 +64,13 @@ describe('SimpleEventPlugin', function () {\n }\n });\n \n- it('A non-interactive tags click when disabled', function () {\n+ it('A non-interactive tags click when disabled', async function () {\n const element =

;\n- expectClickThru(mounted(element));\n+ await expectClickThru(await mounted(element));\n });\n \n- it('A non-interactive tags clicks bubble when disabled', function () {\n- const element = mounted(\n+ it('A non-interactive tags clicks bubble when disabled', async function () {\n+ const element = await mounted(\n

\n <\/div>,\n@@ -75,8 +80,8 @@ describe('SimpleEventPlugin', function () {\n expect(onClick).toHaveBeenCalledTimes(1);\n });\n \n- it('does not register a click when clicking a child of a disabled element', function () {\n- const element = mounted(\n+ it('does not register a click when clicking a child of a disabled element', async function () {\n+ const element = await mounted(\n

dillon1000/react

Files changed