{"commit":{"shortRevision":"14be29b2b9","subject":"Add more test coverage for nested memo() (#14311)","revision":"14be29b2b97f2be6c82955acc0455fbac22ec403","authorName":"Dan Abramov","authorEmail":"dan.abramov@gmail.com","authoredAt":"2018-11-22T19:30:56+00:00"},"files":[{"path":"packages\/react-reconciler\/src\/__tests__\/ReactMemo-test.internal.js","status":"M"}],"patch":"diff --git a\/packages\/react-reconciler\/src\/__tests__\/ReactMemo-test.internal.js b\/packages\/react-reconciler\/src\/__tests__\/ReactMemo-test.internal.js\nindex a7abe9dff3..8ba3027b8a 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ReactMemo-test.internal.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ReactMemo-test.internal.js\n@@ -253,6 +253,59 @@ describe('memo', () => {\n expect(ReactNoop.getChildren()).toEqual([span('1!')]);\n });\n \n+ it('supports defaultProps defined on the memo() return value', async () => {\n+ function Counter({a, b, c, d, e}) {\n+ return ;\n+ }\n+ Counter.defaultProps = {\n+ a: 1,\n+ };\n+ \/\/ Note! We intentionally use React.memo() rather than the injected memo().\n+ \/\/ This tests a synchronous chain of React.memo() without lazy() in the middle.\n+ Counter = React.memo(Counter);\n+ Counter.defaultProps = {\n+ b: 2,\n+ };\n+ Counter = React.memo(Counter);\n+ Counter = React.memo(Counter); \/\/ Layer without defaultProps\n+ Counter.defaultProps = {\n+ c: 3,\n+ };\n+ Counter = React.memo(Counter);\n+ Counter.defaultProps = {\n+ d: 4,\n+ };\n+ \/\/ The final layer uses memo() from test fixture (which might be lazy).\n+ Counter = memo(Counter);\n+ ReactNoop.render(\n+ }>\n+ \n+ <\/Suspense>,\n+ );\n+ expect(ReactNoop.flush()).toEqual(['Loading...']);\n+ await Promise.resolve();\n+ expect(ReactNoop.flush()).toEqual([15]);\n+ expect(ReactNoop.getChildren()).toEqual([span(15)]);\n+\n+ \/\/ Should bail out because props have not changed\n+ ReactNoop.render(\n+ \n+ \n+ <\/Suspense>,\n+ );\n+ expect(ReactNoop.flush()).toEqual([]);\n+ expect(ReactNoop.getChildren()).toEqual([span(15)]);\n+\n+ \/\/ Should update because count prop changed\n+ ReactNoop.render(\n+ \n+ \n+ <\/Suspense>,\n+ );\n+ expect(ReactNoop.flush()).toEqual([20]);\n+ expect(ReactNoop.getChildren()).toEqual([span(20)]);\n+ });\n+\n it('warns if first argument is undefined', () => {\n expect(() => memo()).toWarnDev(\n 'memo: The first argument must be a component. Instead ' +\n","parents":["dc0dd4bbff3f681216b13ae2842f1601bfae3cd8"],"body":""}

dillon1000/react

Files changed