dillon1000/react

Commit

Rename Node SSR Callbacks to onShellReady/onAllReady and Other Fixes (#24030)

* I forgot to call onFatalError

I can't figure out how to write a test for this because it only happens
when there is a bug in React itself which would then be fixed if we found
it.

We're also covered by the protection of ReadableStream which doesn't leak
other errors to us.

* Abort requests if the reader cancels

No need to continue computing at this point.

* Abort requests if node streams get destroyed

This is if the downstream cancels is for example.

* Rename Node APIs for Parity with allReady

The "Complete" terminology is a little misleading because not everything
has been written yet. It's just "Ready" to be written now.

onShellReady
onShellError
onAllReady

* 'close' should be enough
Browse files
Sebastian Markbåge authored 14c2be8dac2d5482fda8a0906a31d239df8551fc Parent cb1e7b1
Changed paths12 files
First-parent comparison
M fixtures/ssr/server/render.js ModifiedM fixtures/ssr2/server/render.js ModifiedM packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMFizzServerBrowser-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMFizzServerNode-test.js ModifiedM packages/react-dom/src/__tests__/utils/ReactDOMServerIntegrationTestUtils.js ModifiedM packages/react-dom/src/server/ReactDOMFizzServerBrowser.js ModifiedM packages/react-dom/src/server/ReactDOMFizzServerNode.js ModifiedM packages/react-dom/src/server/ReactDOMLegacyServerBrowser.js ModifiedM packages/react-dom/src/server/ReactDOMLegacyServerNode.js ModifiedM packages/react-noop-renderer/src/ReactNoopServer.js ModifiedM packages/react-server/src/ReactFizzServer.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…