dillon1000/react

Commit

Fix “no onChange handler” warning to fire on falsy values ("", 0, false) too (#12628)

* throw warning for falsey `value` prop

* add nop onChange handler to tests for `value` prop

* prettier

* check for falsey checked

* fix tests for `checked` prop

* new tests for `value` prop

* test formatting

* forgot 0 (:

* test for falsey `checked` prop

* add null check

* Update ReactDOMInput-test.js

* revert unneeded change

* prettier

* Update DOMPropertyOperations-test.js

* Update ReactDOMInput-test.js

* Update ReactDOMSelect-test.js

* Fixes and tests

* Remove unnecessary changes
Browse files
Nicole Levy authored 171e0b7d447a20b7cc90808a95478c6e5b8b6af0 Parent 606c30a
Changed paths5 files
First-parent comparison
M packages/react-dom/src/__tests__/DOMPropertyOperations-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMInput-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMSelect-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMTextarea-test.js ModifiedM packages/react-dom/src/shared/ReactControlledValuePropTypes.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…