{"commit":{"revision":"17f6912a44e2ce7b88a72488931428da58f19c56","authorEmail":"samuel.susla@gmail.com","shortRevision":"17f6912a44","authorName":"Samuel Susla","authoredAt":"2022-12-02T15:31:53+00:00","subject":"Add flow types to ReactFiberHooks (#25752)"},"parents":["f0bba2d4f57ed9b160cada4039e126b05b9e82de"],"body":"Increase type coverage in ReactFiberHooks file.","files":[{"path":"packages\/react-reconciler\/src\/ReactFiberHooks.js","status":"M"}],"patch":"diff --git a\/packages\/react-reconciler\/src\/ReactFiberHooks.js b\/packages\/react-reconciler\/src\/ReactFiberHooks.js\nindex 8332587a1d..cf3d34f4c4 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberHooks.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberHooks.js\n@@ -268,7 +268,7 @@ let hookTypesUpdateIndexDev: number = -1;\n \/\/ When true, such Hooks will always be \"remounted\". Only used during hot reload.\n let ignorePreviousDependencies: boolean = false;\n \n-function mountHookTypesDev() {\n+function mountHookTypesDev(): void {\n if (__DEV__) {\n const hookName = ((currentHookNameInDev: any): HookType);\n \n@@ -280,7 +280,7 @@ function mountHookTypesDev() {\n }\n }\n \n-function updateHookTypesDev() {\n+function updateHookTypesDev(): void {\n if (__DEV__) {\n const hookName = ((currentHookNameInDev: any): HookType);\n \n@@ -293,7 +293,7 @@ function updateHookTypesDev() {\n }\n }\n \n-function checkDepsAreArrayDev(deps: mixed) {\n+function checkDepsAreArrayDev(deps: mixed): void {\n if (__DEV__) {\n if (deps !== undefined && deps !== null && !isArray(deps)) {\n \/\/ Verify deps, but only on mount to avoid extra checks.\n@@ -308,7 +308,7 @@ function checkDepsAreArrayDev(deps: mixed) {\n }\n }\n \n-function warnOnHookMismatchInDev(currentHookName: HookType) {\n+function warnOnHookMismatchInDev(currentHookName: HookType): void {\n if (__DEV__) {\n const componentName = getComponentNameFromFiber(currentlyRenderingFiber);\n if (!didWarnAboutMismatchedHooksForComponent.has(componentName)) {\n@@ -369,7 +369,7 @@ function throwInvalidHookError() {\n function areHookInputsEqual(\n nextDeps: Array,\n prevDeps: Array | null,\n-) {\n+): boolean {\n if (__DEV__) {\n if (ignorePreviousDependencies) {\n \/\/ Only true when this component is being hot reloaded.\n@@ -681,7 +681,7 @@ function renderWithHooksAgain(\n Component: (p: Props, arg: SecondArg) => any,\n props: Props,\n secondArg: SecondArg,\n-) {\n+): any {\n \/\/ This is used to perform another render pass. It's used when setState is\n \/\/ called during render, and for double invoking components in Strict Mode\n \/\/ during development.\n@@ -745,7 +745,7 @@ export function bailoutHooks(\n current: Fiber,\n workInProgress: Fiber,\n lanes: Lanes,\n-) {\n+): void {\n workInProgress.updateQueue = current.updateQueue;\n \/\/ TODO: Don't need to reset the flags here, because they're reset in the\n \/\/ complete phase (bubbleProperties).\n@@ -1732,7 +1732,7 @@ function pushStoreConsistencyCheck(\n fiber: Fiber,\n getSnapshot: () => T,\n renderedSnapshot: T,\n-) {\n+): void {\n fiber.flags |= StoreConsistency;\n const check: StoreConsistencyCheck = {\n getSnapshot,\n@@ -1758,7 +1758,7 @@ function updateStoreInstance(\n inst: StoreInstance,\n nextSnapshot: T,\n getSnapshot: () => T,\n-) {\n+): void {\n \/\/ These are updated in the passive phase\n inst.value = nextSnapshot;\n inst.getSnapshot = getSnapshot;\n@@ -1773,7 +1773,11 @@ function updateStoreInstance(\n }\n }\n \n-function subscribeToStore(fiber, inst: StoreInstance, subscribe) {\n+function subscribeToStore(\n+ fiber: Fiber,\n+ inst: StoreInstance,\n+ subscribe: (() => void) => () => void,\n+): any {\n const handleStoreChange = () => {\n \/\/ The store changed. Check if the snapshot changed since the last time we\n \/\/ read from the store.\n@@ -1843,7 +1847,12 @@ function rerenderState(\n return rerenderReducer(basicStateReducer, (initialState: any));\n }\n \n-function pushEffect(tag, create, destroy, deps: Array | void | null) {\n+function pushEffect(\n+ tag: HookFlags,\n+ create: () => (() => void) | void,\n+ destroy: (() => void) | void,\n+ deps: Array | void | null,\n+): Effect {\n const effect: Effect = {\n tag,\n create,\n@@ -1963,9 +1972,9 @@ function updateRef(initialValue: T): {current: T} {\n }\n \n function mountEffectImpl(\n- fiberFlags,\n- hookFlags,\n- create,\n+ fiberFlags: Flags,\n+ hookFlags: HookFlags,\n+ create: () => (() => void) | void,\n deps: Array | void | null,\n ): void {\n const hook = mountWorkInProgressHook();\n@@ -1980,9 +1989,9 @@ function mountEffectImpl(\n }\n \n function updateEffectImpl(\n- fiberFlags,\n- hookFlags,\n- create,\n+ fiberFlags: Flags,\n+ hookFlags: HookFlags,\n+ create: () => (() => void) | void,\n deps: Array | void | null,\n ): void {\n const hook = updateWorkInProgressHook();\n@@ -2019,14 +2028,14 @@ function mountEffect(\n __DEV__ &&\n (currentlyRenderingFiber.mode & StrictEffectsMode) !== NoMode\n ) {\n- return mountEffectImpl(\n+ mountEffectImpl(\n MountPassiveDevEffect | PassiveEffect | PassiveStaticEffect,\n HookPassive,\n create,\n deps,\n );\n } else {\n- return mountEffectImpl(\n+ mountEffectImpl(\n PassiveEffect | PassiveStaticEffect,\n HookPassive,\n create,\n@@ -2039,7 +2048,7 @@ function updateEffect(\n create: () => (() => void) | void,\n deps: Array | void | null,\n ): void {\n- return updateEffectImpl(PassiveEffect, HookPassive, create, deps);\n+ updateEffectImpl(PassiveEffect, HookPassive, create, deps);\n }\n \n function useEventImpl) => Return>(\n@@ -2099,7 +2108,7 @@ function mountInsertionEffect(\n create: () => (() => void) | void,\n deps: Array | void | null,\n ): void {\n- return mountEffectImpl(UpdateEffect, HookInsertion, create, deps);\n+ mountEffectImpl(UpdateEffect, HookInsertion, create, deps);\n }\n \n function updateInsertionEffect(\n@@ -2133,7 +2142,7 @@ function updateLayoutEffect(\n function imperativeHandleEffect(\n create: () => T,\n ref: {current: T | null} | ((inst: T | null) => mixed) | null | void,\n-) {\n+): void | (() => void) {\n if (typeof ref === 'function') {\n const refCallback = ref;\n const inst = create();\n@@ -2186,7 +2195,7 @@ function mountImperativeHandle(\n ) {\n fiberFlags |= MountLayoutDevEffect;\n }\n- return mountEffectImpl(\n+ mountEffectImpl(\n fiberFlags,\n HookLayout,\n imperativeHandleEffect.bind(null, create, ref),\n@@ -2213,7 +2222,7 @@ function updateImperativeHandle(\n const effectDeps =\n deps !== null && deps !== undefined ? deps.concat([ref]) : null;\n \n- return updateEffectImpl(\n+ updateEffectImpl(\n UpdateEffect,\n HookLayout,\n imperativeHandleEffect.bind(null, create, ref),\n@@ -2361,7 +2370,11 @@ function updateDeferredValueImpl(hook: Hook, prevValue: T, value: T): T {\n }\n }\n \n-function startTransition(setPending, callback, options) {\n+function startTransition(\n+ setPending: boolean => void,\n+ callback: () => void,\n+ options?: StartTransitionOptions,\n+): void {\n const previousPriority = getCurrentUpdatePriority();\n setCurrentUpdatePriority(\n higherEventPriority(previousPriority, ContinuousEventPriority),\n@@ -2483,7 +2496,7 @@ function updateId(): string {\n return id;\n }\n \n-function mountRefresh() {\n+function mountRefresh(): any {\n const hook = mountWorkInProgressHook();\n const refresh = (hook.memoizedState = refreshCache.bind(\n null,\n@@ -2492,12 +2505,12 @@ function mountRefresh() {\n return refresh;\n }\n \n-function updateRefresh() {\n+function updateRefresh(): any {\n const hook = updateWorkInProgressHook();\n return hook.memoizedState;\n }\n \n-function refreshCache(fiber: Fiber, seedKey: ?() => T, seedValue: T) {\n+function refreshCache(fiber: Fiber, seedKey: ?() => T, seedValue: T): void {\n if (!enableCache) {\n return;\n }\n@@ -2553,7 +2566,7 @@ function dispatchReducerAction(\n fiber: Fiber,\n queue: UpdateQueue,\n action: A,\n-) {\n+): void {\n if (__DEV__) {\n if (typeof arguments[3] === 'function') {\n console.error(\n@@ -2592,7 +2605,7 @@ function dispatchSetState(\n fiber: Fiber,\n queue: UpdateQueue,\n action: A,\n-) {\n+): void {\n if (__DEV__) {\n if (typeof arguments[3] === 'function') {\n console.error(\n@@ -2670,7 +2683,7 @@ function dispatchSetState(\n markUpdateInDevTools(fiber, lane, action);\n }\n \n-function isRenderPhaseUpdate(fiber: Fiber) {\n+function isRenderPhaseUpdate(fiber: Fiber): boolean {\n const alternate = fiber.alternate;\n return (\n fiber === currentlyRenderingFiber ||\n@@ -2681,7 +2694,7 @@ function isRenderPhaseUpdate(fiber: Fiber) {\n function enqueueRenderPhaseUpdate(\n queue: UpdateQueue,\n update: Update,\n-) {\n+): void {\n \/\/ This is a render phase update. Stash it in a lazily-created map of\n \/\/ queue -> linked list of updates. After this render pass, we'll restart\n \/\/ and apply the stashed updates on top of the work-in-progress hook.\n@@ -2702,7 +2715,7 @@ function entangleTransitionUpdate(\n root: FiberRoot,\n queue: UpdateQueue,\n lane: Lane,\n-) {\n+): void {\n if (isTransitionLane(lane)) {\n let queueLanes = queue.lanes;\n \n@@ -2723,7 +2736,7 @@ function entangleTransitionUpdate(\n }\n }\n \n-function markUpdateInDevTools(fiber, lane, action: A) {\n+function markUpdateInDevTools (fiber, lane, action: A): void {\n if (__DEV__) {\n if (enableDebugTracing) {\n if (fiber.mode & DebugTracingMode) {\n"}

dillon1000/react

Files changed