dillon1000/react

Commit

[DevTools] Fix Bugs With Component Stacks (#24815)

This PR:
* Simplifies the code in `SidebarEventInfo` by passing it the actual clicked event rather than an index.
* Lightly refactored the `SidebarEventInfo` code so that it can be used for more than just `schedulingEvents`
* Fixes bug. Previously, whenever a state update event was clicked, we updated the `selectedCommitIndex` in the `ProfilerContext`. However, this index is used for the selected commit in the Flamegraph profiler, which caused a bug where if you would change the contents of the event sidebar, the commit sidebar in the Flamegraph profiler would change too. This PR replaces this with the actual event info instead
Browse files
Luna Ruan authored 1974d08c93ddf171779fde59215e8430f36d281a Parent cd80d32
Changed paths5 files
First-parent comparison
M packages/react-devtools-shared/src/devtools/views/Profiler/SidebarEventInfo.js ModifiedM packages/react-devtools-timeline/src/CanvasPage.js ModifiedM packages/react-devtools-timeline/src/EventTooltip.js ModifiedM packages/react-devtools-timeline/src/TimelineContext.js ModifiedM packages/react-devtools-timeline/src/types.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…