dillon1000/react
Commit
Browse files [Suspense] Use !important to hide Suspended nodes (#15861)
Suspended nodes are hidden using an inline `display: none` style. We do this instead of removing the nodes from the DOM so that their state is preserved when they are shown again. Inline styles have the greatest specificity, but they are superseded by `!important`. To prevent an external style from overriding React's, this commit changes the hidden style to `display: none !important`. MaYBE AnDREw sHOulD JusT LEArn Css I attempted to write a unit test using `getComputedStyle` but JSDOM doesn't respect `!important`. I think our existing tests are sufficient but if we were to decide we need something more robust, I would set up an e2e test.
Changed paths3 files
First-parent comparisonpackages/react-dom/src/__tests__/ReactDOMSuspensePlaceholder-test.js ModifiedM packages/react-dom/src/client/ReactDOMHostConfig.js ModifiedM packages/react-fresh/src/__tests__/ReactFresh-test.js ModifiedPatch
Files changed
Rendering syntax-highlighted changes…