dillon1000/react

Commit

Make ReactPerf.start() work during reconciliation (#7208)

* Add failing test demonstrating a ReactPerf warning

* Make the failing ReactPerf test more precise

* Make ReactPerf.start() work during reconciliation

* Reorder lifecycle methods for greater clarity

* Fix memory leak

* Error boundaries should not break ReactPerf

* Put onBeginFlush/onEndFlush into transaction wrappers

This looks cleaner even though it is not strictly necessary.
We still call them manually for unmounting because it doesn't have a transaction.
Browse files
Dan Abramov authored 1a0e3a32150468223d6f9fd0125db0f8503b76d6 Parent 21ce271
Changed paths12 files
First-parent comparison
M src/renderers/dom/client/ReactMount.js ModifiedM src/renderers/dom/client/ReactReconcileTransaction.js ModifiedM src/renderers/dom/server/ReactServerRendering.js ModifiedM src/renderers/dom/server/ReactServerRenderingTransaction.js ModifiedM src/renderers/native/ReactNativeMount.js ModifiedM src/renderers/native/ReactNativeReconcileTransaction.js ModifiedM src/renderers/shared/ReactDebugTool.js ModifiedM src/renderers/shared/__tests__/ReactPerf-test.js ModifiedM src/renderers/shared/devtools/__tests__/ReactHostOperationHistoryDevtool-test.js ModifiedM src/renderers/shared/stack/reconciler/ReactCompositeComponent.js ModifiedM src/renderers/shared/stack/reconciler/ReactUpdates.js ModifiedM src/renderers/testing/ReactTestMount.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…