dillon1000/react

Commits/1b7478246d

Commit

[compiler] Special-case phi inference for mixed readonly type

This allows us to handle common operations such as `useFragment(...).edges.nodes ?? []` where we have a `Phi(MixedReadonly, Array)`. The underlying pattern remains general-purpose and not Relay-specific, and any API that returns transitively "mixed" data (primitives, arrays, plain objects) can benefit from the same type refinement.

ghstack-source-id: 51283108942002a14d032613a9d0b8b665ee3a94
Pull Request resolved: https://github.com/facebook/react/pull/30797

Browse files

Joe Savona authored 8/23/2024, 12:51:22 AM 1b7478246d05b030a2ae7a8bb07aea8c7df7ef27 Parent 4f54674

Changed paths4 files

First-parent comparison

M compiler/packages/babel-plugin-react-compiler/src/TypeInference/InferTypes.ts Modified D

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/error.todo-repro-missing-memoization-lack-of-phi-types.expect.md

Deleted A

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/repro-missing-memoization-lack-of-phi-types.expect.md

Added R compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/error.todo-repro-missing-memoization-lack-of-phi-types.js →

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/repro-missing-memoization-lack-of-phi-types.js

Renamed

Patch

Files changed

Rendering syntax-highlighted changes…