dillon1000/react

Commit

Fix createRoot container signature (#24110)

The internal Container type represents the types of containers that React
can support in its internals that deal with containers.

This didn't include DocumentFragment which we support specifically for
rendering into shadow roots.

However, not all types makes sense to pass into the createRoot API.

One of those is comment nodes that is deprecated and we don't really fully
support. It really only exists for FB legacy.

For createRoot it doesn't make sense to pass a Document since that will try
to empty the document which removes the HTML tag which doesn't work.
Documents can only be passed to hydrateRoot.

Conversely I'm not sure we actually support hydrating a shadow root properly
so I excluded DocumentFragment from hydrateRoot.
Browse files
Changed paths5 files
First-parent comparison
M packages/react-dom/client.js ModifiedM packages/react-dom/src/client/ReactDOM.js ModifiedM packages/react-dom/src/client/ReactDOMComponent.js ModifiedM packages/react-dom/src/client/ReactDOMHostConfig.js ModifiedM packages/react-dom/src/client/ReactDOMRoot.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…