{"commit":{"shortRevision":"1c8901f750","authorName":"Sebastian Silbermann","authoredAt":"2024-01-29T09:10:34+01:00","revision":"1c8901f750fe09396de311e9c9e1e337599b2e9c","authorEmail":"silbermann.sebastian@gmail.com","subject":"Convert ReactDOMSelect to createRoot (#28142)"},"parents":["7aa45db6a2d30e62cf5ace08e17d971c8e8b977c"],"files":[{"status":"M","path":"packages\/react-dom\/src\/__tests__\/ReactDOMSelect-test.js"}],"patch":"diff --git a\/packages\/react-dom\/src\/__tests__\/ReactDOMSelect-test.js b\/packages\/react-dom\/src\/__tests__\/ReactDOMSelect-test.js\nindex 9df6b07e23..35aaba29a6 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDOMSelect-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDOMSelect-test.js\n@@ -19,8 +19,9 @@ Element.prototype.setAttribute = function (name, value) {\n describe('ReactDOMSelect', () => {\n let React;\n let ReactDOM;\n+ let ReactDOMClient;\n let ReactDOMServer;\n- let ReactTestUtils;\n+ let act;\n \n const noop = function () {};\n \n@@ -28,11 +29,12 @@ describe('ReactDOMSelect', () => {\n jest.resetModules();\n React = require('react');\n ReactDOM = require('react-dom');\n+ ReactDOMClient = require('react-dom\/client');\n ReactDOMServer = require('react-dom\/server');\n- ReactTestUtils = require('react-dom\/test-utils');\n+ act = require('internal-test-utils').act;\n });\n \n- it('should allow setting `defaultValue`', () => {\n+ it('should allow setting `defaultValue`', async () => {\n const stub = (\n {options}<\/select>,\n- container,\n- );\n+ await act(() => {\n+ root.render(;\n \n- expect(() => {\n- ReactTestUtils.renderIntoDocument(stub);\n+ expect(async () => {\n+ const container = document.createElement('div');\n+ const root = ReactDOMClient.createRoot(container);\n+\n+ await act(() => {\n+ root.render(stub);\n+ });\n }).not.toThrow();\n });\n \n- it('should not control when using `defaultValue`', () => {\n+ it('should not control when using `defaultValue`', async () => {\n const el = (\n \n

dillon1000/react

Files changed