{"body":"","commit":{"authorName":"Sebastian Silbermann","authorEmail":"silbermann.sebastian@gmail.com","revision":"1deda7690fc95d873b14cbcb0ee6c8f1dd1395a3","subject":"Remove ReactTestUtils from ReactDOMComponent (#28334)","authoredAt":"2024-02-20T16:52:30+01:00","shortRevision":"1deda7690f"},"files":[{"status":"M","path":"packages\/react-dom\/src\/__tests__\/ReactDOMComponent-test.js"}],"patch":"diff --git a\/packages\/react-dom\/src\/__tests__\/ReactDOMComponent-test.js b\/packages\/react-dom\/src\/__tests__\/ReactDOMComponent-test.js\nindex 006b29fd97..65c6dfa182 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDOMComponent-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDOMComponent-test.js\n@@ -11,7 +11,6 @@\n \n describe('ReactDOMComponent', () => {\n let React;\n- let ReactTestUtils;\n let ReactDOM;\n let ReactDOMClient;\n let ReactDOMServer;\n@@ -25,7 +24,6 @@ describe('ReactDOMComponent', () => {\n ReactDOM = require('react-dom');\n ReactDOMClient = require('react-dom\/client');\n ReactDOMServer = require('react-dom\/server');\n- ReactTestUtils = require('react-dom\/test-utils');\n act = require('internal-test-utils').act;\n });\n \n@@ -162,7 +160,7 @@ describe('ReactDOMComponent', () => {\n expect(stubStyle.lineHeight).toBe('');\n });\n \n- it('should throw when mutating style objects', () => {\n+ it('should throw when mutating style objects', async () => {\n const style = {border: '1px solid black'};\n \n class App extends React.Component {\n@@ -173,7 +171,12 @@ describe('ReactDOMComponent', () => {\n }\n }\n \n- ReactTestUtils.renderIntoDocument();\n+ const container = document.createElement('div');\n+ const root = ReactDOMClient.createRoot(container);\n+ await act(() => {\n+ root.render();\n+ });\n+\n if (__DEV__) {\n expect(() => (style.position = 'absolute')).toThrow();\n }\n@@ -298,14 +301,18 @@ describe('ReactDOMComponent', () => {\n expect(container.firstChild.getAttribute('CHILDREN')).toBe('5');\n });\n \n- it('should not warn for \"0\" as a unitless style value', () => {\n+ it('should not warn for \"0\" as a unitless style value', async () => {\n class Component extends React.Component {\n render() {\n return

;\n }\n }\n \n- ReactTestUtils.renderIntoDocument();\n+ const container = document.createElement('div');\n+ const root = ReactDOMClient.createRoot(container);\n+ await act(() => {\n+ root.render();\n+ });\n });\n \n it('should warn nicely about NaN in style', async () => {\n@@ -906,28 +913,36 @@ describe('ReactDOMComponent', () => {\n ]);\n });\n \n- it('should reject attribute key injection attack on mount for regular DOM', () => {\n- expect(() => {\n+ it('should reject attribute key injection attack on mount for regular DOM', async () => {\n+ await expect(async () => {\n for (let i = 0; i < 3; i++) {\n const container = document.createElement('div');\n- ReactDOM.render(\n- React.createElement(\n- 'div',\n- {'blah\" onclick=\"beevil\" noise=\"hi': 'selected'},\n- null,\n- ),\n- container,\n- );\n+ let root = ReactDOMClient.createRoot(container);\n+ await act(() => {\n+ root.render(\n+ React.createElement(\n+ 'div',\n+ {'blah\" onclick=\"beevil\" noise=\"hi': 'selected'},\n+ null,\n+ ),\n+ );\n+ });\n+\n expect(container.firstChild.attributes.length).toBe(0);\n- ReactDOM.unmountComponentAtNode(container);\n- ReactDOM.render(\n- React.createElement(\n- 'div',\n- {'><\/div>

dillon1000/react

Files changed