{"files":[{"path":"src\/renderers\/shared\/fiber\/__tests__\/ReactIncremental-test.js","status":"M"}],"patch":"diff --git a\/src\/renderers\/shared\/fiber\/__tests__\/ReactIncremental-test.js b\/src\/renderers\/shared\/fiber\/__tests__\/ReactIncremental-test.js\nindex 6c5e04d010..8643829a71 100644\n--- a\/src\/renderers\/shared\/fiber\/__tests__\/ReactIncremental-test.js\n+++ b\/src\/renderers\/shared\/fiber\/__tests__\/ReactIncremental-test.js\n@@ -1797,23 +1797,41 @@ describe('ReactIncremental', () => {\n state = {x: 0};\n render() {\n statefulInst = this;\n- return [\n- ,\n- ,\n- ];\n+ return this.props.children;\n+ }\n+ }\n+\n+ function IndirectionFn(props, context) {\n+ ops.push('IndirectionFn ' + JSON.stringify(context));\n+ return props.children;\n+ }\n+\n+ class IndirectionClass extends React.Component {\n+ render() {\n+ ops.push('IndirectionClass ' + JSON.stringify(this.context));\n+ return this.props.children;\n }\n }\n \n ops.length = 0;\n ReactNoop.render(\n \n- \n+ \n+ \n+ \n+ \n+ \n+ <\/Stateful>\n+ <\/IndirectionClass>\n+ <\/IndirectionFn>\n <\/Intl>\n );\n ReactNoop.flush();\n expect(ops).toEqual([\n 'Intl:read null',\n 'Intl:provide {\"locale\":\"fr\"}',\n+ 'IndirectionFn null',\n+ 'IndirectionClass null',\n 'ShowLocaleClass:read {\"locale\":\"fr\"}',\n 'ShowLocaleFn:read {\"locale\":\"fr\"}',\n ]);\n@@ -1821,12 +1839,9 @@ describe('ReactIncremental', () => {\n ops.length = 0;\n statefulInst.setState({x: 1});\n ReactNoop.flush();\n- expect(ops).toEqual([\n- \/\/ Intl was memoized so we did not need to\n- \/\/ either render it or recompute its context.\n- 'ShowLocaleClass:read {\"locale\":\"fr\"}',\n- 'ShowLocaleFn:read {\"locale\":\"fr\"}',\n- ]);\n+ \/\/ All work has been memoized because setState()\n+ \/\/ happened below the context and could not have affected it.\n+ expect(ops).toEqual([]);\n });\n \n it('reads context when setState is above the provider', () => {\n@@ -1868,25 +1883,47 @@ describe('ReactIncremental', () => {\n locale: React.PropTypes.string,\n };\n \n+ function IndirectionFn(props, context) {\n+ ops.push('IndirectionFn ' + JSON.stringify(context));\n+ return props.children;\n+ }\n+\n+ class IndirectionClass extends React.Component {\n+ render() {\n+ ops.push('IndirectionClass ' + JSON.stringify(this.context));\n+ return this.props.children;\n+ }\n+ }\n+\n class Stateful extends React.Component {\n state = {locale: 'fr'};\n render() {\n statefulInst = this;\n return (\n \n- \n- \n+ {this.props.children}\n <\/Intl>\n );\n }\n }\n \n ops.length = 0;\n- ReactNoop.render();\n+ ReactNoop.render(\n+ \n+ \n+ \n+ \n+ \n+ <\/IndirectionClass>\n+ <\/IndirectionFn>\n+ <\/Stateful>\n+ );\n ReactNoop.flush();\n expect(ops).toEqual([\n 'Intl:read null',\n 'Intl:provide {\"locale\":\"fr\"}',\n+ 'IndirectionFn null',\n+ 'IndirectionClass null',\n 'ShowLocaleClass:read {\"locale\":\"fr\"}',\n 'ShowLocaleFn:read {\"locale\":\"fr\"}',\n ]);\n@@ -1900,6 +1937,11 @@ describe('ReactIncremental', () => {\n \/\/ its child context.\n 'Intl:read null',\n 'Intl:provide {\"locale\":\"gr\"}',\n+ \/\/ TODO: it's unfortunate that we can't reuse work on\n+ \/\/ these components even though they don't depend on context.\n+ 'IndirectionFn null',\n+ 'IndirectionClass null',\n+ \/\/ These components depend on context:\n 'ShowLocaleClass:read {\"locale\":\"gr\"}',\n 'ShowLocaleFn:read {\"locale\":\"gr\"}',\n ]);\n","body":"","commit":{"revision":"1e42c1833cf50f2450be35758470f8b84d7a60a2","authorName":"Dan Abramov","authorEmail":"dan.abramov@gmail.com","authoredAt":"2016-11-15T16:08:15+00:00","subject":"Add explicit tests for intermediate components","shortRevision":"1e42c1833c"},"parents":["fd8c8038f01b992a81d86299b3e46bb5ab5f19a2"]}

dillon1000/react

Files changed