dillon1000/react

Commit

Fix a portal unmounting crash for renderers with distinct Instance and Container (#13220)

* Fix Portal unmount

Before that change, currentParent is not set as a container even if it should so it break on react-native and probably other custom renderers

* Assert that *ToContainer() methods receive containers

* Add regression tests

* Add comments
Browse files
Thibault Malbranche authored 21ac62c77ac68c66b2a1f0adcc60f7760b884a0e Parent d6a0626
Changed paths4 files
First-parent comparison
M packages/react-noop-renderer/src/createReactNoop.js ModifiedM packages/react-reconciler/src/ReactFiberCommitWork.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalPerf-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalSideEffects-test.internal.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…