dillon1000/react
Commit
Browse files chore[DevTools]: make clipboardWrite optional for chromium (#32262)
Addresses https://github.com/facebook/react/issues/32244. ### Chromium We will use [chrome.permissions](https://developer.chrome.com/docs/extensions/reference/api/permissions) for checking / requesting `clipboardWrite` permission before copying something to the clipboard. ### Firefox We will keep `clipboardWrite` as a required permission, because there is no reliable and working API for requesting optional permissions for extensions that are extending browser DevTools: - `chrome.permissions` is unavailable for devtools pages - https://bugzilla.mozilla.org/show_bug.cgi?id=1796933 - You can't call `chrome.permissions.request` from background, because this instruction has to be executed inside user-event callback, basically only initiated by user. I don't really want to come up with solutions like opening a new tab with a button that user has to click.
Changed paths16 files
First-parent comparison.eslintrc.js ModifiedM packages/react-devtools-extensions/chrome/manifest.json ModifiedM packages/react-devtools-extensions/edge/manifest.json ModifiedM packages/react-devtools-shared/src/devtools/ContextMenu/types.js ModifiedM packages/react-devtools-shared/src/devtools/store.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/InspectedElementContextTree.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/InspectedElementPropsTree.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/InspectedElementSourcePanel.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/InspectedElementStateTree.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/NativeStyleEditor/StyleEditor.js ModifiedM packages/react-devtools-shared/src/devtools/views/Profiler/SidebarEventInfo.js ModifiedM packages/react-devtools-shared/src/devtools/views/UnsupportedBridgeProtocolDialog.js ModifiedA packages/react-devtools-shared/src/errors/PermissionNotGrantedError.js AddedA packages/react-devtools-shared/src/frontend/utils/withPermissionsCheck.js AddedM packages/react-devtools-timeline/src/CanvasPageContextMenu.js ModifiedM scripts/flow/react-devtools.js ModifiedPatch
Files changed
Rendering syntax-highlighted changes…