dillon1000/react

Commit

Errors thrown when detaching a ref should not interrupt unmount

If a ref throws while detaching, it should not prevent
componentWillUnmount from being called.

Additionally, errors thrown by removeChild should not be ignored, even
as the result of unmounting a failed subtree.
Browse files
Andrew Clark authored 2508888a2b2273b10c39a5a76818f5e58d0248a9 Parent 7e82214
Changed paths3 files
First-parent comparison
M scripts/fiber/tests-passing.txt ModifiedM src/renderers/shared/fiber/ReactFiberCommitWork.js ModifiedM src/renderers/shared/fiber/__tests__/ReactIncrementalErrorHandling-test.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…