dillon1000/react

Commit

Add more SSR unit tests for elements and children. (#9221)

* Adding more SSR unit tests for elements and children.

* Some of my SSR tests were testing for react-text and react-empty elements that no longer exist in Fiber. Fixed the tests so that they expect correct markup in Fiber.

* Tweaked some test names after @gaearon review comment https://github.com/facebook/react/pull/9221#discussion_r107045673 . Also realized that one of the tests was essentially a direct copy of another, so deleted it.

* Responding to code review https://github.com/facebook/react/pull/9221#pullrequestreview-28996315 . Thanks @spicyj!
Browse files
Changed paths4 files
First-parent comparison
M scripts/fiber/tests-failing.txt ModifiedM scripts/fiber/tests-passing-except-dev.txt ModifiedM scripts/fiber/tests-passing.txt ModifiedM src/renderers/dom/shared/__tests__/ReactDOMServerIntegration-test.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…