{"body":"","files":[{"status":"M","path":"src\/__tests__\/__snapshots__\/store-test.js.snap"},{"status":"M","path":"src\/devtools\/store.js"}],"parents":["4926d160d6d270805ecc8c569125403e74d97c1c"],"patch":"diff --git a\/src\/__tests__\/__snapshots__\/store-test.js.snap b\/src\/__tests__\/__snapshots__\/store-test.js.snap\nindex 2787592224..8683a9e943 100644\n--- a\/src\/__tests__\/__snapshots__\/store-test.js.snap\n+++ b\/src\/__tests__\/__snapshots__\/store-test.js.snap\n@@ -1,20 +1,23 @@\n \/\/ Jest Snapshot v1, https:\/\/goo.gl\/fbAQLP\n \n exports[`Store should initialize a multiple root tree 1`] = `\n-▾ \n- \n- \n-▾ \n- \n- \n-`;\n-\n-exports[`Store should initialize a simple tree 1`] = `\n-▾ \n+[root]\n ▾ \n \n \n+[root]\n ▾ \n \n \n `;\n+\n+exports[`Store should initialize a simple tree 1`] = `\n+[root]\n+ ▾ \n+ ▾ \n+ \n+ \n+ ▾ \n+ \n+ \n+`;\ndiff --git a\/src\/devtools\/store.js b\/src\/devtools\/store.js\nindex b4945b0d71..38d33f2a6a 100644\n--- a\/src\/devtools\/store.js\n+++ b\/src\/devtools\/store.js\n@@ -836,30 +836,40 @@ export default class Store extends EventEmitter {\n this._bridge.removeListener('shutdown', this.onBridgeShutdown);\n };\n \n- \/\/ Jest snapshot testing\n+ \/\/ Used for Jest snapshot testing.\n+ \/\/ May also be useful for visually debugging the tree, so it lives on the Store.\n __toSnapshot = () => {\n- const snapshot = [];\n+ const snapshotLines = [];\n \n- \/\/ TODO Include root (ids) in the snapshot?\n- for (let i = 0; i < this._weightAcrossRoots; i++) {\n- const element = ((this.getElementAtIndex(i): any): Element);\n+ let rootWeight = 0;\n \n- let prefix = ' ';\n- if (element.children.length > 0) {\n- prefix = element.isCollapsed ? '▸' : '▾';\n- }\n+ this._roots.forEach(rootID => {\n+ snapshotLines.push('[root]');\n+\n+ const { weight } = ((this.getElementByID(rootID): any): Element);\n+\n+ for (let i = rootWeight; i < rootWeight + weight; i++) {\n+ const element = ((this.getElementAtIndex(i): any): Element);\n+\n+ let prefix = ' ';\n+ if (element.children.length > 0) {\n+ prefix = element.isCollapsed ? '▸' : '▾';\n+ }\n+\n+ let key = '';\n+ if (element.key !== null) {\n+ key = ` key=\"${element.key}\"`;\n+ }\n \n- let key = '';\n- if (element.key !== null) {\n- key = ` key=\"${element.key}\"`;\n+ snapshotLines.push(\n+ `${' '.repeat(element.depth + 1)}${prefix} <${element.displayName ||\n+ 'null'}${key}>`\n+ );\n }\n \n- snapshot.push(\n- `${' '.repeat(element.depth)}${prefix} <${element.displayName ||\n- 'null'}${key}>`\n- );\n- }\n+ rootWeight += weight;\n+ });\n \n- return snapshot.join('\\n');\n+ return snapshotLines.join('\\n');\n };\n }\n","commit":{"shortRevision":"25e918b4d9","authorName":"Brian Vaughn","authorEmail":"bvaughn@fb.com","revision":"25e918b4d98ad915110e5ad8516cbb0b64cf2757","authoredAt":"2019-04-11T09:25:39-07:00","subject":"Added [root] indicator to Store snapshot reprensentation"}}

dillon1000/react

Files changed