{"body":"","files":[{"status":"M","path":"src\/browser\/ui\/dom\/components\/ReactDOMSelect.js"},{"status":"M","path":"src\/browser\/ui\/dom\/components\/__tests__\/ReactDOMSelect-test.js"}],"commit":{"authoredAt":"2014-09-25T11:59:19+02:00","authorEmail":"andreas@syranide.com","revision":"2601b6a0b0c2b0bccaca67fbbfab6987ac5bef30","authorName":"Andreas Svensson","subject":"ReactDOMSelect makeover, fix edge-case inconsistencies and remove state","shortRevision":"2601b6a0b0"},"parents":["cb50a8698b3e8aef4e96fed09a4c8e0ec193af72"],"patch":"diff --git a\/src\/browser\/ui\/dom\/components\/ReactDOMSelect.js b\/src\/browser\/ui\/dom\/components\/ReactDOMSelect.js\nindex 0b071400b5..051a9759d6 100644\n--- a\/src\/browser\/ui\/dom\/components\/ReactDOMSelect.js\n+++ b\/src\/browser\/ui\/dom\/components\/ReactDOMSelect.js\n@@ -22,11 +22,14 @@ var assign = require('Object.assign');\n \n var select = ReactElement.createFactory('select');\n \n-function updateWithPendingValueIfMounted() {\n+function updateOptionsIfPendingUpdateAndMounted() {\n \/*jshint validthis:true *\/\n- if (this.isMounted()) {\n- this.setState({value: this._pendingValue});\n- this._pendingValue = 0;\n+ if (this._pendingUpdate) {\n+ this._pendingUpdate = false;\n+ var value = LinkedValueUtils.getValue(this);\n+ if (value != null && this.isMounted()) {\n+ updateOptions(this, value);\n+ }\n }\n }\n \n@@ -56,40 +59,43 @@ function selectValueType(props, propName, componentName) {\n }\n \n \/**\n- * If `value` is supplied, updates

dillon1000/react

Files changed