{"files":[{"status":"M","path":"OVERVIEW.md"},{"status":"M","path":"package.json"},{"status":"M","path":"shells\/browser\/shared\/src\/background.js"},{"status":"M","path":"shells\/browser\/shared\/src\/contentScript.js"},{"status":"M","path":"shells\/browser\/shared\/src\/main.js"},{"status":"M","path":"shells\/dev\/src\/backend.js"},{"status":"M","path":"shells\/dev\/src\/devtools.js"},{"status":"M","path":"src\/__tests__\/__snapshots__\/profilingCache-test.js.snap"},{"status":"M","path":"src\/backend\/agent.js"},{"status":"M","path":"src\/bridge.js"},{"status":"M","path":"src\/devtools\/ProfilerStore.js"},{"status":"M","path":"src\/devtools\/store.js"},{"status":"M","path":"src\/devtools\/views\/Profiler\/SidebarCommitInfo.css"},{"status":"M","path":"src\/devtools\/views\/Profiler\/SidebarCommitInfo.js"},{"status":"M","path":"src\/devtools\/views\/Profiler\/types.js"},{"status":"M","path":"src\/devtools\/views\/Profiler\/utils.js"},{"status":"M","path":"src\/devtools\/views\/Settings\/ProfilerSettings.js"},{"status":"M","path":"src\/devtools\/views\/Settings\/SettingsShared.css"},{"status":"M","path":"yarn.lock"}],"body":"This wasn't reliable because of browser extension API limitations and required serious throttling to avoid harming performance, so I've decided to just remove it entirely for now.","parents":["4f8b7864eea378841ef7e4a41aeec92d54431084"],"patch":"diff --git a\/OVERVIEW.md b\/OVERVIEW.md\nindex f4f849096a..3cd314d888 100644\n--- a\/OVERVIEW.md\n+++ b\/OVERVIEW.md\n@@ -262,6 +262,4 @@ Once profiling is finished, the frontend requests profiling data from the backen\n \n ### Importing\/exporting data\n \n-Because all of the data is merged in the frontend after a profiling session is completed, it can be exported and imported (as JSON), enabling profiling sessions to be shared between users.\n-\n-At the moment, screenshots are not included in the exported data (to keep the export filesize small) but this could be changed in the future.\n\\ No newline at end of file\n+Because all of the data is merged in the frontend after a profiling session is completed, it can be exported and imported (as JSON), enabling profiling sessions to be shared between users.\n\\ No newline at end of file\ndiff --git a\/package.json b\/package.json\nindex a2615e14a2..cdfd58da14 100644\n--- a\/package.json\n+++ b\/package.json\n@@ -122,7 +122,6 @@\n \"flow-bin\": \"^0.103.0\",\n \"fs-extra\": \"^3.0.1\",\n \"gh-pages\": \"^1.0.0\",\n- \"html2canvas\": \"^1.0.0-alpha.12\",\n \"immutable\": \"3.7.6\",\n \"jest\": \"^24.7.1\",\n \"lerna\": \"^2.8.0\",\ndiff --git a\/shells\/browser\/shared\/src\/background.js b\/shells\/browser\/shared\/src\/background.js\nindex 1090ef76d8..e22071b3aa 100644\n--- a\/shells\/browser\/shared\/src\/background.js\n+++ b\/shells\/browser\/shared\/src\/background.js\n@@ -109,31 +109,5 @@ chrome.runtime.onMessage.addListener((request, sender) => {\n \n setIconAndPopup(reactBuildType, sender.tab.id);\n }\n-\n- if (request.captureScreenshot) {\n- const { commitIndex, rootID } = request;\n- try {\n- chrome.tabs.captureVisibleTab(undefined, undefined, dataURL => {\n- \/\/ TODO For some reason, sending a response using the third param (sendResponse) doesn't work,\n- \/\/ so we have to use the chrome.tabs API for this instead.\n- chrome.tabs.query({ active: true, currentWindow: true }, tabs => {\n- if (tabs.length > 0) {\n- chrome.tabs.sendMessage(tabs[0].id, {\n- event: 'screenshotCaptured',\n- payload: {\n- commitIndex,\n- dataURL,\n- rootID,\n- },\n- });\n- }\n- });\n- });\n- } catch (error) {\n- \/\/ Screen captures may not always be allowed.\n- \/\/ DevTools is robust enough to handle missing images in this case.\n- \/\/ See https:\/\/stackoverflow.com\/questions\/55504938\n- }\n- }\n }\n });\ndiff --git a\/shells\/browser\/shared\/src\/contentScript.js b\/shells\/browser\/shared\/src\/contentScript.js\nindex af4e328f0d..68a44e21af 100644\n--- a\/shells\/browser\/shared\/src\/contentScript.js\n+++ b\/shells\/browser\/shared\/src\/contentScript.js\n@@ -75,15 +75,3 @@ if (!backendInitialized) {\n }\n }, 500);\n }\n-\n-chrome.runtime.onMessage.addListener(function(request, sender, sendResponse) {\n- if (request.event === 'screenshotCaptured') {\n- window.postMessage(\n- {\n- source: 'react-devtools-content-script',\n- payload: request,\n- },\n- '*'\n- );\n- }\n-});\ndiff --git a\/shells\/browser\/shared\/src\/main.js b\/shells\/browser\/shared\/src\/main.js\nindex 8263adab53..8ce8782216 100644\n--- a\/shells\/browser\/shared\/src\/main.js\n+++ b\/shells\/browser\/shared\/src\/main.js\n@@ -97,16 +97,6 @@ function createPanelIfReactLoaded() {\n localStorageSetItem(LOCAL_STORAGE_SUPPORTS_PROFILING_KEY, 'true');\n chrome.devtools.inspectedWindow.eval('window.location.reload();');\n });\n- bridge.addListener('captureScreenshot', ({ commitIndex, rootID }) => {\n- chrome.runtime.sendMessage(\n- {\n- captureScreenshot: true,\n- commitIndex,\n- rootID,\n- },\n- response => bridge.send('screenshotCaptured', response)\n- );\n- });\n bridge.addListener('syncSelectionToNativeElementsPanel', () => {\n setBrowserSelectionFromReact();\n });\n@@ -126,7 +116,6 @@ function createPanelIfReactLoaded() {\n \n store = new Store(bridge, {\n isProfiling,\n- supportsCaptureScreenshots: true,\n supportsReloadAndProfile: true,\n supportsProfiling,\n });\ndiff --git a\/shells\/dev\/src\/backend.js b\/shells\/dev\/src\/backend.js\nindex 808230b82d..6d0af11c43 100644\n--- a\/shells\/dev\/src\/backend.js\n+++ b\/shells\/dev\/src\/backend.js\n@@ -1,6 +1,5 @@\n \/** @flow *\/\n \n-import html2canvas from 'html2canvas';\n import Agent from 'src\/backend\/agent';\n import Bridge from 'src\/bridge';\n import { initBackend } from 'src\/backend';\n@@ -21,16 +20,6 @@ const bridge = new Bridge({\n },\n });\n \n-bridge.addListener('captureScreenshot', ({ commitIndex, rootID }) => {\n- html2canvas(document.body, { logging: false }).then(canvas => {\n- bridge.send('screenshotCaptured', {\n- commitIndex,\n- dataURL: canvas.toDataURL(),\n- rootID,\n- });\n- });\n-});\n-\n const agent = new Agent(bridge);\n \n const hook = window.__REACT_DEVTOOLS_GLOBAL_HOOK__;\ndiff --git a\/shells\/dev\/src\/devtools.js b\/shells\/dev\/src\/devtools.js\nindex 5727856dd9..c8f5ba036f 100644\n--- a\/shells\/dev\/src\/devtools.js\n+++ b\/shells\/dev\/src\/devtools.js\n@@ -67,7 +67,7 @@ inject('dist\/app.js', () => {\n \n cb(bridge);\n \n- const store = new Store(bridge, { supportsCaptureScreenshots: true });\n+ const store = new Store(bridge);\n \n const root = createRoot(container);\n const batch = root.createBatch();\ndiff --git a\/src\/__tests__\/__snapshots__\/profilingCache-test.js.snap b\/src\/__tests__\/__snapshots__\/profilingCache-test.js.snap\nindex 8485313a29..82438ada7c 100644\n--- a\/src\/__tests__\/__snapshots__\/profilingCache-test.js.snap\n+++ b\/src\/__tests__\/__snapshots__\/profilingCache-test.js.snap\n@@ -40,7 +40,6 @@ Object {\n },\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 16,\n }\n `;\n@@ -78,7 +77,6 @@ Object {\n },\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 15,\n }\n `;\n@@ -105,7 +103,6 @@ Object {\n },\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 18,\n }\n `;\n@@ -159,7 +156,6 @@ Object {\n },\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 12,\n }\n `;\n@@ -215,7 +211,6 @@ Object {\n },\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 25,\n }\n `;\n@@ -253,7 +248,6 @@ Object {\n },\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 35,\n }\n `;\n@@ -282,7 +276,6 @@ Object {\n },\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 45,\n }\n `;\n@@ -382,7 +375,6 @@ Object {\n ],\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 12,\n },\n Object {\n@@ -477,7 +469,6 @@ Object {\n ],\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 25,\n },\n Object {\n@@ -536,7 +527,6 @@ Object {\n ],\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 35,\n },\n Object {\n@@ -577,7 +567,6 @@ Object {\n ],\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 45,\n },\n ],\n@@ -841,7 +830,6 @@ Object {\n ],\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 11,\n },\n Object {\n@@ -918,7 +906,6 @@ Object {\n ],\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 22,\n },\n Object {\n@@ -1013,7 +1000,6 @@ Object {\n ],\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 35,\n },\n ],\n@@ -1213,7 +1199,6 @@ Object {\n },\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 13,\n },\n Object {\n@@ -1248,7 +1233,6 @@ Object {\n },\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 34,\n },\n Object {\n@@ -1274,7 +1258,6 @@ Object {\n },\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 44,\n },\n ],\n@@ -1443,7 +1426,6 @@ Object {\n },\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 24,\n },\n ],\n@@ -1526,7 +1508,6 @@ Object {\n \"fiberSelfDurations\": Map {},\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 34,\n },\n ],\n@@ -1688,7 +1669,6 @@ Object {\n ],\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 13,\n },\n Object {\n@@ -1747,7 +1727,6 @@ Object {\n ],\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 34,\n },\n Object {\n@@ -1788,7 +1767,6 @@ Object {\n ],\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 44,\n },\n ],\n@@ -2017,7 +1995,6 @@ Object {\n ],\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 24,\n },\n ],\n@@ -2097,7 +2074,6 @@ Object {\n \"fiberSelfDurations\": Array [],\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 34,\n },\n ],\n@@ -2249,7 +2225,6 @@ Object {\n },\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 0,\n }\n `;\n@@ -2320,7 +2295,6 @@ Object {\n },\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 0,\n }\n `;\n@@ -2387,7 +2361,6 @@ Object {\n },\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 0,\n }\n `;\n@@ -2455,7 +2428,6 @@ Object {\n },\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 0,\n }\n `;\n@@ -2522,7 +2494,6 @@ Object {\n },\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 0,\n }\n `;\n@@ -2648,7 +2619,6 @@ Object {\n ],\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 0,\n },\n Object {\n@@ -2767,7 +2737,6 @@ Object {\n ],\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 0,\n },\n Object {\n@@ -2888,7 +2857,6 @@ Object {\n ],\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 0,\n },\n Object {\n@@ -3010,7 +2978,6 @@ Object {\n ],\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 0,\n },\n Object {\n@@ -3131,7 +3098,6 @@ Object {\n ],\n \"interactionIDs\": Array [],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 0,\n },\n ],\n@@ -3445,7 +3411,6 @@ Object {\n 0,\n ],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 11,\n },\n Object {\n@@ -3524,7 +3489,6 @@ Object {\n 1,\n ],\n \"priorityLevel\": \"Immediate\",\n- \"screenshot\": null,\n \"timestamp\": 22,\n },\n ],\ndiff --git a\/src\/backend\/agent.js b\/src\/backend\/agent.js\nindex a711080827..fa2df90f73 100644\n--- a\/src\/backend\/agent.js\n+++ b\/src\/backend\/agent.js\n@@ -113,7 +113,6 @@ export default class Agent extends EventEmitter<{|\n \n this._bridge = bridge;\n \n- bridge.addListener('captureScreenshot', this.captureScreenshot);\n bridge.addListener('getProfilingData', this.getProfilingData);\n bridge.addListener('getProfilingStatus', this.getProfilingStatus);\n bridge.addListener('getOwnersList', this.getOwnersList);\n@@ -125,7 +124,6 @@ export default class Agent extends EventEmitter<{|\n bridge.addListener('overrideState', this.overrideState);\n bridge.addListener('overrideSuspense', this.overrideSuspense);\n bridge.addListener('reloadAndProfile', this.reloadAndProfile);\n- bridge.addListener('screenshotCaptured', this.screenshotCaptured);\n bridge.addListener('selectElement', this.selectElement);\n bridge.addListener('startProfiling', this.startProfiling);\n bridge.addListener('stopProfiling', this.stopProfiling);\n@@ -161,16 +159,6 @@ export default class Agent extends EventEmitter<{|\n return this._rendererInterfaces;\n }\n \n- captureScreenshot = ({\n- commitIndex,\n- rootID,\n- }: {\n- commitIndex: number,\n- rootID: number,\n- }) => {\n- this._bridge.send('captureScreenshot', { commitIndex, rootID });\n- };\n-\n getInstanceAndStyle({\n id,\n rendererID,\n@@ -256,18 +244,6 @@ export default class Agent extends EventEmitter<{|\n this._bridge.send('reloadAppForProfiling');\n };\n \n- screenshotCaptured = ({\n- commitIndex,\n- dataURL,\n- rootID,\n- }: {|\n- commitIndex: number,\n- dataURL: string,\n- rootID: number,\n- |}) => {\n- this._bridge.send('screenshotCaptured', { commitIndex, dataURL, rootID });\n- };\n-\n selectElement = ({ id, rendererID }: ElementAndRendererID) => {\n const renderer = this._rendererInterfaces[rendererID];\n if (renderer == null) {\ndiff --git a\/src\/bridge.js b\/src\/bridge.js\nindex b8ab73e710..f9101e582b 100644\n--- a\/src\/bridge.js\n+++ b\/src\/bridge.js\n@@ -63,7 +63,6 @@ type NativeStyleEditor_SetValueParams = {|\n |};\n \n type BackendEvents = {|\n- captureScreenshot: [{| commitIndex: number, rootID: number |}],\n inspectedElement: [InspectedElementPayload],\n isBackendStorageAPISupported: [boolean],\n operations: [Array],\n@@ -72,9 +71,6 @@ type BackendEvents = {|\n profilingData: [ProfilingDataBackend],\n profilingStatus: [boolean],\n reloadAppForProfiling: [],\n- screenshotCaptured: [\n- {| commitIndex: number, dataURL: string, rootID: number |},\n- ],\n selectFiber: [number],\n shutdown: [],\n stopInspectingNative: [boolean],\n@@ -89,7 +85,6 @@ type BackendEvents = {|\n |};\n \n type FrontendEvents = {|\n- captureScreenshot: [{| commitIndex: number, rootID: number |}],\n clearNativeElementHighlight: [],\n getOwnersList: [ElementAndRendererID],\n getProfilingData: [{| rendererID: RendererID |}],\ndiff --git a\/src\/devtools\/ProfilerStore.js b\/src\/devtools\/ProfilerStore.js\nindex eb79c41e65..103947ac8c 100644\n--- a\/src\/devtools\/ProfilerStore.js\n+++ b\/src\/devtools\/ProfilerStore.js\n@@ -1,8 +1,6 @@\n \/\/ @flow\n \n import EventEmitter from 'events';\n-import memoize from 'memoize-one';\n-import throttle from 'lodash.throttle';\n import { prepareProfilingDataFrontendFromBackendAndStore } from '.\/views\/Profiler\/utils';\n import ProfilingCache from '.\/ProfilingCache';\n import Store from '.\/store';\n@@ -16,8 +14,6 @@ import type {\n SnapshotNode,\n } from '.\/views\/Profiler\/types';\n \n-const THROTTLE_CAPTURE_SCREENSHOT_DURATION = 500;\n-\n export default class ProfilerStore extends EventEmitter<{|\n isProcessingData: [],\n isProfiling: [],\n@@ -62,13 +58,6 @@ export default class ProfilerStore extends EventEmitter<{|\n \/\/ Upon completion, it is converted into the exportable ProfilingDataFrontend format.\n _inProgressOperationsByRootID: Map>> = new Map();\n \n- \/\/ Map of root (id) to a Map of screenshots by commit ID.\n- \/\/ Stores screenshots for each commit (when profiling).\n- \/\/\n- \/\/ This map is only updated while profiling is in progress;\n- \/\/ Upon completion, it is converted into the exportable ProfilingDataFrontend format.\n- _inProgressScreenshotsByRootID: Map> = new Map();\n-\n \/\/ The backend is currently profiling.\n \/\/ When profiling is in progress, operations are stored so that we can later reconstruct past commit trees.\n _isProfiling: boolean = false;\n@@ -164,7 +153,6 @@ export default class ProfilerStore extends EventEmitter<{|\n this._initialRendererIDs.clear();\n this._initialSnapshotsByRootID.clear();\n this._inProgressOperationsByRootID.clear();\n- this._inProgressScreenshotsByRootID.clear();\n this._cache.invalidate();\n \n this.emit('profilingData');\n@@ -176,7 +164,6 @@ export default class ProfilerStore extends EventEmitter<{|\n this._initialRendererIDs.clear();\n this._initialSnapshotsByRootID.clear();\n this._inProgressOperationsByRootID.clear();\n- this._inProgressScreenshotsByRootID.clear();\n this._rendererQueue.clear();\n \n \/\/ Invalidate suspense cache if profiling data is being (re-)recorded.\n@@ -204,13 +191,6 @@ export default class ProfilerStore extends EventEmitter<{|\n \/\/ We do this to avoid mismatches on e.g. CommitTreeBuilder that would cause errors.\n }\n \n- _captureScreenshot = throttle(\n- memoize((rootID: number, commitIndex: number) => {\n- this._bridge.send('captureScreenshot', { commitIndex, rootID });\n- }),\n- THROTTLE_CAPTURE_SCREENSHOT_DURATION\n- );\n-\n _takeProfilingSnapshotRecursive = (\n elementID: number,\n profilingSnapshots: Map\n@@ -253,11 +233,6 @@ export default class ProfilerStore extends EventEmitter<{|\n if (!this._initialSnapshotsByRootID.has(rootID)) {\n this._initialSnapshotsByRootID.set(rootID, new Map());\n }\n-\n- if (this._store.captureScreenshots) {\n- const commitIndex = profilingOperations.length - 1;\n- this._captureScreenshot(rootID, commitIndex);\n- }\n }\n };\n \n@@ -282,7 +257,6 @@ export default class ProfilerStore extends EventEmitter<{|\n this._dataFrontend = prepareProfilingDataFrontendFromBackendAndStore(\n this._dataBackends,\n this._inProgressOperationsByRootID,\n- this._inProgressScreenshotsByRootID,\n this._initialSnapshotsByRootID\n );\n \n@@ -306,7 +280,6 @@ export default class ProfilerStore extends EventEmitter<{|\n this._initialRendererIDs.clear();\n this._initialSnapshotsByRootID.clear();\n this._inProgressOperationsByRootID.clear();\n- this._inProgressScreenshotsByRootID.clear();\n this._rendererQueue.clear();\n \n \/\/ Record all renderer IDs initially too (in case of unmount)\n@@ -354,26 +327,4 @@ export default class ProfilerStore extends EventEmitter<{|\n }\n }\n };\n-\n- onScreenshotCaptured = ({\n- commitIndex,\n- dataURL,\n- rootID,\n- }: {|\n- commitIndex: number,\n- dataURL: string,\n- rootID: number,\n- |}) => {\n- let screenshotsForRootByCommitIndex = this._inProgressScreenshotsByRootID.get(\n- rootID\n- );\n- if (!screenshotsForRootByCommitIndex) {\n- screenshotsForRootByCommitIndex = new Map();\n- this._inProgressScreenshotsByRootID.set(\n- rootID,\n- screenshotsForRootByCommitIndex\n- );\n- }\n- screenshotsForRootByCommitIndex.set(commitIndex, dataURL);\n- };\n }\ndiff --git a\/src\/devtools\/store.js b\/src\/devtools\/store.js\nindex adaccfe24b..41db44634f 100644\n--- a\/src\/devtools\/store.js\n+++ b\/src\/devtools\/store.js\n@@ -36,8 +36,6 @@ const debug = (methodName, ...args) => {\n }\n };\n \n-const LOCAL_STORAGE_CAPTURE_SCREENSHOTS_KEY =\n- 'React::DevTools::captureScreenshots';\n const LOCAL_STORAGE_COLLAPSE_ROOTS_BY_DEFAULT_KEY =\n 'React::DevTools::collapseNodesByDefault';\n const LOCAL_STORAGE_RECORD_CHANGE_DESCRIPTIONS_KEY =\n@@ -45,7 +43,6 @@ const LOCAL_STORAGE_RECORD_CHANGE_DESCRIPTIONS_KEY =\n \n type Config = {|\n isProfiling?: boolean,\n- supportsCaptureScreenshots?: boolean,\n supportsNativeInspection?: boolean,\n supportsReloadAndProfile?: boolean,\n supportsProfiling?: boolean,\n@@ -61,7 +58,6 @@ export type Capabilities = {|\n * ContextProviders can subscribe to the Store for specific things they want to provide.\n *\/\n export default class Store extends EventEmitter<{|\n- captureScreenshots: [],\n collapseNodesByDefault: [],\n componentFilters: [],\n mutated: [[Array, Map]],\n@@ -73,8 +69,6 @@ export default class Store extends EventEmitter<{|\n |}> {\n _bridge: FrontendBridge;\n \n- _captureScreenshots: boolean = false;\n-\n \/\/ Should new nodes be collapsed by default when added to the tree?\n _collapseNodesByDefault: boolean = true;\n \n@@ -120,7 +114,6 @@ export default class Store extends EventEmitter<{|\n \n \/\/ These options may be initially set by a confiugraiton option when constructing the Store.\n \/\/ In the case of \"supportsProfiling\", the option may be updated based on the injected renderers.\n- _supportsCaptureScreenshots: boolean = false;\n _supportsNativeInspection: boolean = false;\n _supportsProfiling: boolean = false;\n _supportsReloadAndProfile: boolean = false;\n@@ -151,16 +144,10 @@ export default class Store extends EventEmitter<{|\n isProfiling = config.isProfiling === true;\n \n const {\n- supportsCaptureScreenshots,\n supportsNativeInspection,\n supportsProfiling,\n supportsReloadAndProfile,\n } = config;\n- if (supportsCaptureScreenshots) {\n- this._supportsCaptureScreenshots = true;\n- this._captureScreenshots =\n- localStorageGetItem(LOCAL_STORAGE_CAPTURE_SCREENSHOTS_KEY) === 'true';\n- }\n this._supportsNativeInspection = supportsNativeInspection !== false;\n if (supportsProfiling) {\n this._supportsProfiling = true;\n@@ -222,20 +209,6 @@ export default class Store extends EventEmitter<{|\n }\n }\n \n- get captureScreenshots(): boolean {\n- return this._captureScreenshots;\n- }\n- set captureScreenshots(value: boolean): void {\n- this._captureScreenshots = value;\n-\n- localStorageSetItem(\n- LOCAL_STORAGE_CAPTURE_SCREENSHOTS_KEY,\n- value ? 'true' : 'false'\n- );\n-\n- this.emit('captureScreenshots');\n- }\n-\n get collapseNodesByDefault(): boolean {\n return this._collapseNodesByDefault;\n }\n@@ -338,10 +311,6 @@ export default class Store extends EventEmitter<{|\n return this._roots;\n }\n \n- get supportsCaptureScreenshots(): boolean {\n- return this._supportsCaptureScreenshots;\n- }\n-\n get supportsNativeInspection(): boolean {\n return this._supportsNativeInspection;\n }\ndiff --git a\/src\/devtools\/views\/Profiler\/SidebarCommitInfo.css b\/src\/devtools\/views\/Profiler\/SidebarCommitInfo.css\nindex 6a835e64a2..c0564e0d8c 100644\n--- a\/src\/devtools\/views\/Profiler\/SidebarCommitInfo.css\n+++ b\/src\/devtools\/views\/Profiler\/SidebarCommitInfo.css\n@@ -63,40 +63,3 @@\n height: 100%;\n color: var(--color-dim);\n }\n-\n-.Screenshot {\n- width: 100%;\n- border: 1px solid var(--color-border);\n- border-radius: 0.25rem;\n- cursor: pointer;\n-}\n-\n-.Modal {\n- position: absolute;\n- top: 0;\n- bottom: 0;\n- left: 0;\n- right: 0;\n- display: flex;\n- align-items: center;\n- justify-content: center;\n- background-color: var(--color-modal-background);\n- padding: 0.5rem;\n-}\n-\n-.ModalImage {\n- max-height: 100%;\n- max-width: 100%;\n- border: 1px solid var(--color-border);\n- border-radius: 0.5rem;\n-}\n-\n-.NoScreenshot {\n- width: 100%;\n- height: 200px;\n- background-color: var(--color-button-background-focus);\n- border-radius: 0.25rem;\n- display: flex;\n- align-items: center;\n- justify-content: center;\n-}\ndiff --git a\/src\/devtools\/views\/Profiler\/SidebarCommitInfo.js b\/src\/devtools\/views\/Profiler\/SidebarCommitInfo.js\nindex f4b7ea9a24..527d0ebffa 100644\n--- a\/src\/devtools\/views\/Profiler\/SidebarCommitInfo.js\n+++ b\/src\/devtools\/views\/Profiler\/SidebarCommitInfo.js\n@@ -1,6 +1,6 @@\n \/\/ @flow\n \n-import React, { Fragment, useCallback, useContext, useState } from 'react';\n+import React, { Fragment, useContext } from 'react';\n import { ProfilerContext } from '.\/ProfilerContext';\n import { formatDuration, formatTime } from '.\/utils';\n import { StoreContext } from '..\/context';\n@@ -17,21 +17,7 @@ export default function SidebarCommitInfo(_: Props) {\n selectTab,\n } = useContext(ProfilerContext);\n \n- const { captureScreenshots, profilerStore } = useContext(StoreContext);\n-\n- const [\n- isScreenshotModalVisible,\n- setIsScreenshotModalVisible,\n- ] = useState(false);\n-\n- const hideScreenshotModal = useCallback(\n- () => setIsScreenshotModalVisible(false),\n- []\n- );\n- const showScreenshotModal = useCallback(\n- () => setIsScreenshotModalVisible(true),\n- []\n- );\n+ const { profilerStore } = useContext(StoreContext);\n \n if (rootID === null || selectedCommitIndex === null) {\n return

Nothing selected<\/div>;\n@@ -42,7 +28,6 @@ export default function SidebarCommitInfo(_: Props) {\n duration,\n interactionIDs,\n priorityLevel,\n- screenshot,\n timestamp,\n } = profilerStore.getCommitData(rootID, selectedCommitIndex);\n \n@@ -93,45 +78,8 @@ export default function SidebarCommitInfo(_: Props) {\n })}\n <\/div>\n <\/li>\n- {captureScreenshots && (\n-

\n- Screenshot<\/label>:\n- {screenshot != null ? (\n- \n- ) : (\n-

\n- No screenshot available\n- <\/div>\n- )}\n- <\/li>\n- )}\n- {screenshot != null && isScreenshotModalVisible && (\n- \n- )}\n <\/ul>\n <\/div>\n <\/Fragment>\n );\n }\n-\n-function ScreenshotModal({\n- hideScreenshotModal,\n- screenshot,\n-}: {|\n- hideScreenshotModal: Function,\n- screenshot: string,\n-|}) {\n- return (\n-

\n- $\"Screenshot\"$ \n- <\/div>\n- );\n-}\ndiff --git a\/src\/devtools\/views\/Profiler\/types.js b\/src\/devtools\/views\/Profiler\/types.js\nindex b6c2fcc2fd..d8c954e5b7 100644\n--- a\/src\/devtools\/views\/Profiler\/types.js\n+++ b\/src\/devtools\/views\/Profiler\/types.js\n@@ -60,9 +60,6 @@ export type CommitDataFrontend = {|\n \/\/ Priority level of the commit (if React provided this info)\n priorityLevel: string | null,\n \n- \/\/ Screenshot data for this commit (if available).\n- screenshot: string | null,\n-\n \/\/ When did this commit occur (relative to the start of profiling)\n timestamp: number,\n |};\n@@ -112,7 +109,6 @@ export type CommitDataExport = {|\n fiberSelfDurations: Array<[number, number]>,\n interactionIDs: Array,\n priorityLevel: string | null,\n- screenshot: string | null,\n timestamp: number,\n |};\n \ndiff --git a\/src\/devtools\/views\/Profiler\/utils.js b\/src\/devtools\/views\/Profiler\/utils.js\nindex e0f1dcdd83..973d5ba2d5 100644\n--- a\/src\/devtools\/views\/Profiler\/utils.js\n+++ b\/src\/devtools\/views\/Profiler\/utils.js\n@@ -29,7 +29,6 @@ const commitGradient = [\n export function prepareProfilingDataFrontendFromBackendAndStore(\n dataBackends: Array,\n operationsByRootID: Map>>,\n- screenshotsByRootID: Map>,\n snapshotsByRootID: Map>\n ): ProfilingDataFrontend {\n const dataForRoots: Map = new Map();\n@@ -44,8 +43,6 @@ export function prepareProfilingDataFrontendFromBackendAndStore(\n interactions,\n rootID,\n }) => {\n- const screenshots = screenshotsByRootID.get(rootID) || null;\n-\n const operations = operationsByRootID.get(rootID);\n if (operations == null) {\n throw Error(`Could not find profiling operations for root ${rootID}`);\n@@ -69,8 +66,6 @@ export function prepareProfilingDataFrontendFromBackendAndStore(\n fiberSelfDurations: new Map(commitDataBackend.fiberSelfDurations),\n interactionIDs: commitDataBackend.interactionIDs,\n priorityLevel: commitDataBackend.priorityLevel,\n- screenshot:\n- (screenshots !== null && screenshots.get(commitIndex)) || null,\n timestamp: commitDataBackend.timestamp,\n })),\n displayName,\n@@ -119,7 +114,6 @@ export function prepareProfilingDataFrontendFromExport(\n fiberSelfDurations,\n interactionIDs,\n priorityLevel,\n- screenshot,\n timestamp,\n }) => ({\n changeDescriptions:\n@@ -129,7 +123,6 @@ export function prepareProfilingDataFrontendFromExport(\n fiberSelfDurations: new Map(fiberSelfDurations),\n interactionIDs,\n priorityLevel,\n- screenshot,\n timestamp,\n })\n ),\n@@ -172,7 +165,6 @@ export function prepareProfilingDataExport(\n fiberSelfDurations,\n interactionIDs,\n priorityLevel,\n- screenshot,\n timestamp,\n }) => ({\n changeDescriptions:\n@@ -184,7 +176,6 @@ export function prepareProfilingDataExport(\n fiberSelfDurations: Array.from(fiberSelfDurations.entries()),\n interactionIDs,\n priorityLevel,\n- screenshot,\n timestamp,\n })\n ),\ndiff --git a\/src\/devtools\/views\/Settings\/ProfilerSettings.js b\/src\/devtools\/views\/Settings\/ProfilerSettings.js\nindex a52597d2eb..b13f7ad6e8 100644\n--- a\/src\/devtools\/views\/Settings\/ProfilerSettings.js\n+++ b\/src\/devtools\/views\/Settings\/ProfilerSettings.js\n@@ -1,12 +1,6 @@\n \/\/ @flow\n \n-import React, {\n- Fragment,\n- useCallback,\n- useContext,\n- useMemo,\n- useRef,\n-} from 'react';\n+import React, { useCallback, useContext, useMemo, useRef } from 'react';\n import { useSubscription } from '..\/hooks';\n import { StoreContext } from '..\/context';\n import { ProfilerContext } from 'src\/devtools\/views\/Profiler\/ProfilerContext';\n@@ -23,20 +17,6 @@ export default function ProfilerSettings(_: {||}) {\n } = useContext(ProfilerContext);\n const store = useContext(StoreContext);\n \n- const captureScreenshotsSubscription = useMemo(\n- () => ({\n- getCurrentValue: () => store.captureScreenshots,\n- subscribe: (callback: Function) => {\n- store.addListener('captureScreenshots', callback);\n- return () => store.removeListener('captureScreenshots', callback);\n- },\n- }),\n- [store]\n- );\n- const captureScreenshots = useSubscription(\n- captureScreenshotsSubscription\n- );\n-\n const recordChangeDescriptionsSubscription = useMemo(\n () => ({\n getCurrentValue: () => store.recordChangeDescriptions,\n@@ -51,12 +31,6 @@ export default function ProfilerSettings(_: {||}) {\n recordChangeDescriptionsSubscription\n );\n \n- const updateCaptureScreenshotsWhileProfiling = useCallback(\n- ({ currentTarget }) => {\n- store.captureScreenshots = currentTarget.checked;\n- },\n- [store]\n- );\n const updateRecordChangeDescriptions = useCallback(\n ({ currentTarget }) => {\n store.recordChangeDescriptions = currentTarget.checked;\n@@ -118,27 +92,6 @@ export default function ProfilerSettings(_: {||}) {\n \/>{' '}\n (ms)\n <\/div>\n-\n- {store.supportsCaptureScreenshots && (\n- \n-

\n- \n- {' '}\n- Capture screenshots while profiling\n- <\/label>\n- <\/div>\n- {captureScreenshots && (\n-

\n- Screenshots will be throttled in order to reduce the negative\n- impact on performance.\n- <\/div>\n- )}\n- <\/Fragment>\n- )}\n <\/div>\n );\n }\ndiff --git a\/src\/devtools\/views\/Settings\/SettingsShared.css b\/src\/devtools\/views\/Settings\/SettingsShared.css\nindex cafbe1bede..bcdc427668 100644\n--- a\/src\/devtools\/views\/Settings\/SettingsShared.css\n+++ b\/src\/devtools\/views\/Settings\/SettingsShared.css\n@@ -38,13 +38,6 @@\n padding: 0 0 0.5rem;\n }\n \n-.ScreenshotThrottling {\n- display: inline-block;\n- background-color: var(--color-background-hover);\n- padding: 0.25rem 0.5rem;\n- border-radius: 0.25rem;\n-}\n-\n .HRule {\n height: 1px;\n background-color: var(--color-border);\ndiff --git a\/yarn.lock b\/yarn.lock\nindex 3f8a3dd8fe..86531c672e 100644\n--- a\/yarn.lock\n+++ b\/yarn.lock\n@@ -2414,11 +2414,6 @@ balanced-match@^1.0.0:\n resolved \"https:\/\/registry.yarnpkg.com\/balanced-match\/-\/balanced-match-1.0.0.tgz#89b4d199ab2bee49de164ea02b89ce462d71b767\"\n integrity sha1-ibTRmasr7kneFk6gK4nORi1xt2c=\n \n-base64-arraybuffer@^0.1.5:\n- version \"0.1.5\"\n- resolved \"https:\/\/registry.yarnpkg.com\/base64-arraybuffer\/-\/base64-arraybuffer-0.1.5.tgz#73926771923b5a19747ad666aa5cd4bf9c6e9ce8\"\n- integrity sha1-c5JncZI7Whl0etZmqlzUv5xunOg=\n-\n base64-js@0.0.8:\n version \"0.0.8\"\n resolved \"https:\/\/registry.yarnpkg.com\/base64-js\/-\/base64-js-0.0.8.tgz#1101e9544f4a76b1bc3b26d452ca96d7a35e7978\"\n@@ -3788,13 +3783,6 @@ css-in-js-utils@^2.0.0:\n hyphenate-style-name \"^1.0.2\"\n isobject \"^3.0.1\"\n \n-css-line-break@1.0.1:\n- version \"1.0.1\"\n- resolved \"https:\/\/registry.yarnpkg.com\/css-line-break\/-\/css-line-break-1.0.1.tgz#19f2063a33e95fb2831b86446c0b80c188af450a\"\n- integrity sha1-GfIGOjPpX7KDG4ZEbAuAwYivRQo=\n- dependencies:\n- base64-arraybuffer \"^0.1.5\"\n-\n css-loader@^1.0.1:\n version \"1.0.1\"\n resolved \"https:\/\/registry.yarnpkg.com\/css-loader\/-\/css-loader-1.0.1.tgz#6885bb5233b35ec47b006057da01cc640b6b79fe\"\n@@ -6262,13 +6250,6 @@ html-entities@^1.2.1:\n resolved \"https:\/\/registry.yarnpkg.com\/html-entities\/-\/html-entities-1.2.1.tgz#0df29351f0721163515dfb9e5543e5f6eed5162f\"\n integrity sha1-DfKTUfByEWNRXfueVUPl9u7VFi8=\n \n-html2canvas@^1.0.0-alpha.12:\n- version \"1.0.0-alpha.12\"\n- resolved \"https:\/\/registry.yarnpkg.com\/html2canvas\/-\/html2canvas-1.0.0-alpha.12.tgz#3b1992e3c9b3f56063c35fd620494f37eba88513\"\n- integrity sha1-OxmS48mz9WBjw1\/WIElPN+uohRM=\n- dependencies:\n- css-line-break \"1.0.1\"\n-\n htmlparser2@^3.9.1:\n version \"3.10.1\"\n resolved \"https:\/\/registry.yarnpkg.com\/htmlparser2\/-\/htmlparser2-3.10.1.tgz#bd679dc3f59897b6a34bb10749c855bb53a9392f\"\n","commit":{"authorEmail":"bvaughn@fb.com","subject":"Removed the Profiler screenshot capture feature","authorName":"Brian Vaughn","revision":"271aa75cf2685ff62932863c1b1eaf08b1898d1a","shortRevision":"271aa75cf2","authoredAt":"2019-07-31T11:36:01-07:00"}}

dillon1000/react

Files changed