dillon1000/react
Commit
Browse files Remove Warning: prefix and toString on console Arguments (#29839)
Basically make `console.error` and `console.warn` behave like normal - when a component stack isn't appended. I need this because I need to be able to print rich logs with the component stack option and to be able to disable instrumentation completely in `console.createTask` environments that don't need it. Currently we can't print logs with richer objects because they're toString:ed first. In practice, pretty much all arguments we log are already toString:ed so it's not necessary anyway. Some might be like a number. So it would only be a problem if some environment can't handle proper consoles but then it's up to that environment to toString it before logging. The `Warning: ` prefix is historic and is both noisy and confusing. It's mostly unnecessary since the UI surrounding `console.error` and `console.warn` tend to have visual treatment around it anyway. However, it's actively misleading when `console.error` gets prefixed with a Warning that we consider an error level. There's an argument to be made that some of our `console.error` don't make the bar for an error but then the argument is to downgrade each of those to `console.warn` - not to brand all our actual error logging with `Warning: `. Apparently something needs to change in React Native before landing this because it depends on the prefix somehow which probably doesn't make sense already.
Changed paths77 files
First-parent comparisonpackages/internal-test-utils/shouldIgnoreConsoleError.js ModifiedM packages/react-cache/src/__tests__/ReactCacheOld-test.internal.js ModifiedM packages/react-devtools-shared/src/__tests__/inspectedElement-test.js ModifiedM packages/react-devtools-shared/src/__tests__/setupTests.js ModifiedM packages/react-devtools-shared/src/__tests__/store-test.js ModifiedM packages/react-devtools-shell/src/app/index.js ModifiedM packages/react-dom-bindings/src/client/validateDOMNesting.js ModifiedM packages/react-dom/src/__tests__/CSSPropertyOperations-test.js ModifiedM packages/react-dom/src/__tests__/DOMPropertyOperations-test.js ModifiedM packages/react-dom/src/__tests__/ReactComponent-test.js ModifiedM packages/react-dom/src/__tests__/ReactComponentLifeCycle-test.js ModifiedM packages/react-dom/src/__tests__/ReactCompositeComponent-test.js ModifiedM packages/react-dom/src/__tests__/ReactCompositeComponentState-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOM-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMAttribute-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMComponent-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMComponentTree-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMFizzServer-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMFloat-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMForm-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMHydrationDiff-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMInput-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMInvalidARIAHook-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMOption-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMSelect-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerIntegrationElements-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerIntegrationLegacyContext-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerIntegrationRefs-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerLifecycles-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMSingletonComponents-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMTextarea-test.js ModifiedM packages/react-dom/src/__tests__/ReactDeprecationWarnings-test.js ModifiedM packages/react-dom/src/__tests__/ReactFunctionComponent-test.js ModifiedM packages/react-dom/src/__tests__/ReactLegacyErrorBoundaries-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactLegacyMount-test.js ModifiedM packages/react-dom/src/__tests__/ReactLegacyUpdates-test.js ModifiedM packages/react-dom/src/__tests__/ReactMountDestruction-test.js ModifiedM packages/react-dom/src/__tests__/ReactMultiChildText-test.js ModifiedM packages/react-dom/src/__tests__/ReactRenderDocument-test.js ModifiedM packages/react-dom/src/__tests__/ReactServerRendering-test.js ModifiedM packages/react-dom/src/__tests__/ReactServerRenderingHydration-test.js ModifiedM packages/react-dom/src/__tests__/ReactUpdates-test.js ModifiedM packages/react-dom/src/__tests__/findDOMNodeFB-test.js ModifiedM packages/react-dom/src/__tests__/refs-test.js ModifiedM packages/react-dom/src/__tests__/validateDOMNesting-test.js ModifiedM packages/react-dom/src/client/__tests__/trustedTypes-test.internal.js ModifiedM packages/react-native-renderer/src/ReactNativeFiberHostComponent.js ModifiedM packages/react-native-renderer/src/__tests__/ReactFabric-test.internal.js ModifiedM packages/react-native-renderer/src/__tests__/ReactNativeMount-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/DebugTracing-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactHooks-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactHooksWithNoopRenderer-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalErrorHandling-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalSideEffects-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactIsomorphicAct-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactLazy-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactMemo-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspenseCallback-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspenseList-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactUse-test.js ModifiedM packages/react-server-dom-webpack/src/__tests__/ReactFlightDOMForm-test.js ModifiedM packages/react-test-renderer/src/__tests__/ReactTestRenderer-test.internal.js ModifiedM packages/react/src/__tests__/ReactChildren-test.js ModifiedM packages/react/src/__tests__/ReactCoffeeScriptClass-test.coffee ModifiedM packages/react/src/__tests__/ReactContextValidator-test.js ModifiedM packages/react/src/__tests__/ReactES6Class-test.js ModifiedM packages/react/src/__tests__/ReactElementClone-test.js ModifiedM packages/react/src/__tests__/ReactElementValidator-test.internal.js ModifiedM packages/react/src/__tests__/ReactJSXElementValidator-test.js ModifiedM packages/react/src/__tests__/ReactJSXRuntime-test.js ModifiedM packages/react/src/__tests__/ReactPureComponent-test.js ModifiedM packages/react/src/__tests__/ReactStrictMode-test.js ModifiedM packages/react/src/__tests__/ReactTypeScriptClass-test.ts ModifiedM packages/react/src/__tests__/createReactClassIntegration-test.js ModifiedM packages/react/src/__tests__/forwardRef-test.js ModifiedM packages/shared/consoleWithStackDev.js ModifiedPatch
Files changed
Rendering syntax-highlighted changes…