{"parents":["dc945f6b81fa075efd13e4945586f27f88772058"],"files":[{"status":"M","path":"src\/devtools\/views\/Components\/Tree.js"}],"body":"","patch":"diff --git a\/src\/devtools\/views\/Components\/Tree.js b\/src\/devtools\/views\/Components\/Tree.js\nindex a13d13e740..01fa9be260 100644\n--- a\/src\/devtools\/views\/Components\/Tree.js\n+++ b\/src\/devtools\/views\/Components\/Tree.js\n@@ -325,39 +325,39 @@ export default function Tree(props: Props) {\n \/\/ Indentation size can be adjusted but child width is fixed.\n \/\/ We need to adjust indentations so the widest child can fit without overflowing.\n \/\/ Sometimes the widest child is also the deepest in the tree:\n-\/\/ ┏━━━━━━━━━━━━┓\n-\/\/ ┃ ┃\n-\/\/ ┃ •••• ┃\n-\/\/ ┃ •••••••• ┃\n-\/\/ ┗━━━━━━━━━━━━┛\n+\/\/ ┏----------------------┓\n+\/\/ ┆ ┆\n+\/\/ ┆ •••• ┆\n+\/\/ ┆ •••••••• ┆\n+\/\/ ┗----------------------┛\n \/\/\n \/\/ But this is not always the case.\n \/\/ Even with the above example, a change in indentation may change the overall widest child:\n-\/\/ ┏━━━━━━━━━━━━┓\n-\/\/ ┃ ┃\n-\/\/ ┃ •• ┃\n-\/\/ ┃ •••• ┃\n-\/\/ ┗━━━━━━━━━━━━┛\n+\/\/ ┏----------------------┓\n+\/\/ ┆ ┆\n+\/\/ ┆ •• ┆\n+\/\/ ┆ •••• ┆\n+\/\/ ┗----------------------┛\n \/\/\n \/\/ In extreme cases this difference can be important:\n-\/\/ ┏━━━━━━━━━━━━┓\n-\/\/ ┃ ┃\n-\/\/ ┃ •• ┃\n-\/\/ ┃ •••• ┃\n-\/\/ ┃ •••••• ┃\n-\/\/ ┃ •••••••• ┃\n-\/\/ ┗━━━━━━━━━━━━┛\n+\/\/ ┏----------------------┓\n+\/\/ ┆ ┆\n+\/\/ ┆ •• ┆\n+\/\/ ┆ •••• ┆\n+\/\/ ┆ •••••• ┆\n+\/\/ ┆ •••••••• ┆\n+\/\/ ┗----------------------┛\n \/\/\n \/\/ In the above example, the current indentation is fine,\n \/\/ but if we naively assumed that the widest element is also the deepest element,\n \/\/ we would end up compressing the indentation unnecessarily:\n-\/\/ ┏━━━━━━━━━━━━┓\n-\/\/ ┃ ┃\n-\/\/ ┃ • ┃\n-\/\/ ┃ •• ┃\n-\/\/ ┃ ••• ┃\n-\/\/ ┃ •••• ┃\n-\/\/ ┗━━━━━━━━━━━━┛\n+\/\/ ┏----------------------┓\n+\/\/ ┆ ┆\n+\/\/ ┆ • ┆\n+\/\/ ┆ •• ┆\n+\/\/ ┆ ••• ┆\n+\/\/ ┆ •••• ┆\n+\/\/ ┗----------------------┛\n \/\/\n \/\/ The way we deal with this is to compute the max indentation size that can fit each child,\n \/\/ given the child's fixed width and depth within the tree.\n","commit":{"subject":"Fixed box drawing chars comment","authorName":"Brian Vaughn","authoredAt":"2019-06-02T10:40:10-07:00","shortRevision":"27d4f0b24d","revision":"27d4f0b24d0429ae7569cbc837e1bd3d1d895750","authorEmail":"bvaughn@fb.com"}}

dillon1000/react

Files changed