{"commit":{"subject":"Add test cases for context below and above setState","authoredAt":"2016-11-15T13:22:41+00:00","revision":"299009c41fb6a2dd92247f806bef32859e2b9336","authorEmail":"dan.abramov@gmail.com","authorName":"Dan Abramov","shortRevision":"299009c41f"},"files":[{"status":"M","path":"src\/renderers\/shared\/fiber\/__tests__\/ReactIncremental-test.js"}],"body":"","parents":["eedca6f641d2ea52fb1de5f12f61bc21b7c5f0d6"],"patch":"diff --git a\/src\/renderers\/shared\/fiber\/__tests__\/ReactIncremental-test.js b\/src\/renderers\/shared\/fiber\/__tests__\/ReactIncremental-test.js\nindex 96c1619d00..14cc145254 100644\n--- a\/src\/renderers\/shared\/fiber\/__tests__\/ReactIncremental-test.js\n+++ b\/src\/renderers\/shared\/fiber\/__tests__\/ReactIncremental-test.js\n@@ -1547,7 +1547,6 @@ describe('ReactIncremental', () => {\n static contextTypes = {\n locale: React.PropTypes.string,\n };\n-\n render() {\n ops.push('ShowLocale ' + JSON.stringify(this.context));\n return this.context.locale;\n@@ -1558,7 +1557,6 @@ describe('ReactIncremental', () => {\n static contextTypes = {\n route: React.PropTypes.string,\n };\n-\n render() {\n ops.push('ShowRoute ' + JSON.stringify(this.context));\n return this.context.route;\n@@ -1721,7 +1719,6 @@ describe('ReactIncremental', () => {\n static contextTypes = {\n locale: React.PropTypes.string,\n };\n-\n render() {\n ops.push('ShowLocale ' + JSON.stringify(this.context));\n return this.context.locale;\n@@ -1756,4 +1753,152 @@ describe('ReactIncremental', () => {\n 'ShowLocale {\"locale\":\"ru\"}',\n ]);\n });\n+\n+ it('reads context when setState is below the provider', () => {\n+ var ops = [];\n+ var statefulInst;\n+\n+ class Intl extends React.Component {\n+ static childContextTypes = {\n+ locale: React.PropTypes.string,\n+ };\n+ getChildContext() {\n+ const childContext = {\n+ locale: this.props.locale,\n+ };\n+ ops.push('Intl:provide ' + JSON.stringify(childContext));\n+ return childContext;\n+ }\n+ render() {\n+ ops.push('Intl:read ' + JSON.stringify(this.context));\n+ return this.props.children;\n+ }\n+ }\n+\n+ class ShowLocaleClass extends React.Component {\n+ static contextTypes = {\n+ locale: React.PropTypes.string,\n+ };\n+ render() {\n+ ops.push('ShowLocaleClass:read ' + JSON.stringify(this.context));\n+ return this.context.locale;\n+ }\n+ }\n+\n+ function ShowLocaleFn(props, context) {\n+ ops.push('ShowLocaleFn:read ' + JSON.stringify(context));\n+ return context.locale;\n+ }\n+ ShowLocaleFn.contextTypes = {\n+ locale: React.PropTypes.string,\n+ };\n+\n+ class Stateful extends React.Component {\n+ state = {x: 0};\n+ render() {\n+ statefulInst = this;\n+ return [\n+ ,\n+ ,\n+ ];\n+ }\n+ }\n+\n+ ops.length = 0;\n+ ReactNoop.render(\n+ \n+ \n+ <\/Intl>\n+ );\n+ ReactNoop.flush();\n+ expect(ops).toEqual([\n+ 'Intl:read null',\n+ 'Intl:provide {\"locale\":\"fr\"}',\n+ 'ShowLocaleClass:read {\"locale\":\"fr\"}',\n+ 'ShowLocaleFn:read {\"locale\":\"fr\"}',\n+ ]);\n+\n+ ops.length = 0;\n+ statefulInst.setState({x: 1});\n+ ReactNoop.flush();\n+ expect(ops).toEqual([\n+ \/\/ TODO: we should be able to reuse the previous child context.\n+ 'Intl:provide {\"locale\":\"fr\"}',\n+ 'ShowLocaleClass:read {\"locale\":\"fr\"}',\n+ 'ShowLocaleFn:read {\"locale\":\"fr\"}',\n+ ]);\n+ });\n+\n+ it('reads context when setState is above the provider', () => {\n+ var ops = [];\n+ var statefulInst;\n+\n+ class Intl extends React.Component {\n+ static childContextTypes = {\n+ locale: React.PropTypes.string,\n+ };\n+ getChildContext() {\n+ const childContext = {\n+ locale: this.props.locale,\n+ };\n+ ops.push('Intl:provide ' + JSON.stringify(childContext));\n+ return childContext;\n+ }\n+ render() {\n+ ops.push('Intl:read ' + JSON.stringify(this.context));\n+ return this.props.children;\n+ }\n+ }\n+\n+ class ShowLocaleClass extends React.Component {\n+ static contextTypes = {\n+ locale: React.PropTypes.string,\n+ };\n+ render() {\n+ ops.push('ShowLocaleClass:read ' + JSON.stringify(this.context));\n+ return this.context.locale;\n+ }\n+ }\n+\n+ function ShowLocaleFn(props, context) {\n+ ops.push('ShowLocaleFn:read ' + JSON.stringify(context));\n+ return context.locale;\n+ }\n+ ShowLocaleFn.contextTypes = {\n+ locale: React.PropTypes.string,\n+ };\n+\n+ class Stateful extends React.Component {\n+ state = {locale: 'fr'};\n+ render() {\n+ statefulInst = this;\n+ return (\n+ \n+ \n+ \n+ <\/Intl>\n+ );\n+ }\n+ }\n+\n+ ops.length = 0;\n+ ReactNoop.render();\n+ ReactNoop.flush();\n+ expect(ops).toEqual([\n+ 'Intl:read null',\n+ 'Intl:provide {\"locale\":\"fr\"}',\n+ 'ShowLocaleClass:read {\"locale\":\"fr\"}',\n+ 'ShowLocaleFn:read {\"locale\":\"fr\"}',\n+ ]);\n+\n+ ops.length = 0;\n+ statefulInst.setState({locale: 'gr'});\n+ ReactNoop.flush();\n+ expect(ops).toEqual([\n+ 'Intl:read null',\n+ 'Intl:provide {\"locale\":\"gr\"}',\n+ 'ShowLocaleClass:read {\"locale\":\"gr\"}',\n+ 'ShowLocaleFn:read {\"locale\":\"gr\"}',\n+ ]);\n+ });\n });\n"}

dillon1000/react

Files changed