{"files":[{"path":"packages\/react-dom-bindings\/src\/events\/plugins\/FormActionEventPlugin.js","status":"M"},{"path":"packages\/react-dom\/src\/__tests__\/ReactDOMForm-test.js","status":"M"}],"commit":{"authoredAt":"2024-05-02T06:06:28-05:00","revision":"29d3c83f0a84354b18ab3f064f2d43a4c116d6ed","shortRevision":"29d3c83f0a","authorName":"Juan Pinilla","subject":"ReactDOM: Fix missing form data when the submitter is outside the form (#28056)","authorEmail":"762112+jupapios@users.noreply.github.com"},"parents":["4508873393058e86bed308b56e49ec883ece59d1"],"body":"","patch":"diff --git a\/packages\/react-dom-bindings\/src\/events\/plugins\/FormActionEventPlugin.js b\/packages\/react-dom-bindings\/src\/events\/plugins\/FormActionEventPlugin.js\nindex d862ae678f..8f874e2cdb 100644\n--- a\/packages\/react-dom-bindings\/src\/events\/plugins\/FormActionEventPlugin.js\n+++ b\/packages\/react-dom-bindings\/src\/events\/plugins\/FormActionEventPlugin.js\n@@ -92,6 +92,9 @@ function extractEvents(\n const temp = submitter.ownerDocument.createElement('input');\n temp.name = submitter.name;\n temp.value = submitter.value;\n+ if (form.id) {\n+ temp.setAttribute('form', form.id);\n+ }\n (submitter.parentNode: any).insertBefore(temp, submitter);\n formData = new FormData(form);\n (temp.parentNode: any).removeChild(temp);\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactDOMForm-test.js b\/packages\/react-dom\/src\/__tests__\/ReactDOMForm-test.js\nindex 123619d290..5db3b2fd8a 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDOMForm-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDOMForm-test.js\n@@ -481,6 +481,7 @@ describe('ReactDOMForm', () => {\n it('can read the clicked button in the formdata event', async () => {\n const inputRef = React.createRef();\n const buttonRef = React.createRef();\n+ const outsideButtonRef = React.createRef();\n let button;\n let title;\n \n@@ -492,14 +493,27 @@ describe('ReactDOMForm', () => {\n const root = ReactDOMClient.createRoot(container);\n await act(async () => {\n root.render(\n-

\n- \n- \n- \n-

dillon1000/react

Files changed