{"body":"","parents":["e665f6b877ec5f6ce29ccac50c25ab30e9ad1165"],"files":[{"path":"compiler\/forget\/src\/HIR\/EnterSSA.ts","status":"M"},{"path":"compiler\/forget\/src\/HIR\/HIRBuilder.ts","status":"M"},{"path":"compiler\/forget\/src\/HIR\/InferReferenceEffects.ts","status":"M"},{"path":"compiler\/forget\/src\/HIR\/visitors.ts","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/component.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-break.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-on-mutable.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/hooks-freeze-possibly-mutable-arguments.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/independent-across-if.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/interdependent-across-if.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/logical-expression.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/mutable-lifetime-loops.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/mutable-liverange-loop.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/reassignment-conditional.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/reverse-postorder.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-call-jsx-2.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-complex-multiple-if.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-complex-single-if.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-for-of.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-if-else.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-objectexpression-phi.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-return.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-simple-phi.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-single-if.expect.md","status":"M"},{"path":"compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-throw.expect.md","status":"M"}],"commit":{"authorEmail":"joesavona@fb.com","subject":"Add and use eachTerminalSuccessor()","revision":"2a049044bbd0ed76ccc88f6c9d34783158b444b3","authorName":"Joe Savona","authoredAt":"2022-11-08T14:45:56-08:00","shortRevision":"2a049044bb"},"patch":"diff --git a\/compiler\/forget\/src\/HIR\/EnterSSA.ts b\/compiler\/forget\/src\/HIR\/EnterSSA.ts\nindex 9354a1c91b..e22d96606d 100644\n--- a\/compiler\/forget\/src\/HIR\/EnterSSA.ts\n+++ b\/compiler\/forget\/src\/HIR\/EnterSSA.ts\n@@ -2,7 +2,6 @@ import { assertExhaustive } from \"..\/Common\/utils\";\n import { invariant } from \"..\/CompilerError\";\n import {\n BasicBlock,\n- BlockId,\n HIRFunction,\n Identifier,\n Instruction,\n@@ -11,6 +10,7 @@ import {\n } from \".\/HIR\";\n import { Environment } from \".\/HIRBuilder\";\n import { printIdentifier } from \".\/PrintHIR\";\n+import { eachTerminalSuccessor } from \".\/visitors\";\n \n type IncompletePhi = {\n oldId: Identifier;\n@@ -186,7 +186,7 @@ export default function enterSSA(func: HIRFunction, env: Environment) {\n }\n \n for (const instr of block.instructions) {\n- rewriteUses(instr, builder);\n+ rewriteInstructionUses(instr, builder);\n \n if (instr.lvalue != null) {\n const oldPlace = instr.lvalue.place;\n@@ -200,9 +200,9 @@ export default function enterSSA(func: HIRFunction, env: Environment) {\n }\n }\n \n- const outputs = rewriteUsesAndCollectOutputs(block, builder);\n- const outputBlocks = outputs.map((id) => func.body.blocks.get(id)!);\n- for (const output of outputBlocks) {\n+ rewriteTerminalOperands(block, builder);\n+ for (const outputId of eachTerminalSuccessor(block.terminal)) {\n+ const output = func.body.blocks.get(outputId)!;\n let count;\n if (builder.unsealedPreds.has(output)) {\n count = builder.unsealedPreds.get(output)! - 1;\n@@ -218,11 +218,7 @@ export default function enterSSA(func: HIRFunction, env: Environment) {\n }\n }\n \n-function rewriteUsesAndCollectOutputs(\n- block: BasicBlock,\n- builder: SSABuilder\n-): Array {\n- const outputs: Array = [];\n+function rewriteTerminalOperands(block: BasicBlock, builder: SSABuilder): void {\n const { terminal } = block;\n switch (terminal.kind) {\n case \"return\":\n@@ -233,14 +229,11 @@ function rewriteUsesAndCollectOutputs(\n break;\n }\n case \"goto\": {\n- outputs.push(terminal.block);\n break;\n }\n case \"if\": {\n const { consequent, alternate } = terminal;\n terminal.test = builder.getPlace(terminal.test);\n- outputs.push(alternate);\n- outputs.push(consequent);\n break;\n }\n case \"switch\": {\n@@ -250,7 +243,6 @@ function rewriteUsesAndCollectOutputs(\n if (case_.test) {\n case_.test = builder.getPlace(case_.test);\n }\n- outputs.push(case_.block);\n }\n break;\n }\n@@ -261,11 +253,9 @@ function rewriteUsesAndCollectOutputs(\n );\n }\n }\n-\n- return outputs;\n }\n \n-function rewriteUses(instr: Instruction, builder: SSABuilder) {\n+function rewriteInstructionUses(instr: Instruction, builder: SSABuilder) {\n const instrValue = instr.value;\n \n switch (instrValue.kind) {\ndiff --git a\/compiler\/forget\/src\/HIR\/HIRBuilder.ts b\/compiler\/forget\/src\/HIR\/HIRBuilder.ts\nindex 425279f9a6..140ee9eba1 100644\n--- a\/compiler\/forget\/src\/HIR\/HIRBuilder.ts\n+++ b\/compiler\/forget\/src\/HIR\/HIRBuilder.ts\n@@ -19,7 +19,7 @@ import {\n Terminal,\n } from \".\/HIR\";\n import { printInstruction } from \".\/PrintHIR\";\n-import { mapTerminalSuccessors } from \".\/visitors\";\n+import { eachTerminalSuccessor, mapTerminalSuccessors } from \".\/visitors\";\n \n \/\/ *******************************************************************************************\n \/\/ *******************************************************************************************\n@@ -512,34 +512,8 @@ function markPredecessors(func: HIR) {\n \n const { terminal } = block;\n \n- switch (terminal.kind) {\n- case \"return\":\n- case \"throw\": {\n- break;\n- }\n- case \"goto\": {\n- visit(terminal.block, block);\n- break;\n- }\n- case \"if\": {\n- const { consequent, alternate } = terminal;\n- visit(alternate, block);\n- visit(consequent, block);\n- break;\n- }\n- case \"switch\": {\n- const { cases } = terminal;\n- for (const case_ of [...cases]) {\n- visit(case_.block, block);\n- }\n- break;\n- }\n- default: {\n- assertExhaustive(\n- terminal,\n- `Unexpected terminal kind '${(terminal as any).kind}'`\n- );\n- }\n+ for (const successor of eachTerminalSuccessor(terminal)) {\n+ visit(successor, block);\n }\n }\n visit(func.entry, null);\ndiff --git a\/compiler\/forget\/src\/HIR\/InferReferenceEffects.ts b\/compiler\/forget\/src\/HIR\/InferReferenceEffects.ts\nindex 909a225ef7..353c01e561 100644\n--- a\/compiler\/forget\/src\/HIR\/InferReferenceEffects.ts\n+++ b\/compiler\/forget\/src\/HIR\/InferReferenceEffects.ts\n@@ -16,15 +16,14 @@ import {\n InstructionValue,\n Phi,\n Place,\n- Terminal,\n ValueKind,\n } from \".\/HIR\";\n+import { printMixedHIR, printPlace, printSourceLocation } from \".\/PrintHIR\";\n import {\n eachInstructionOperand,\n eachTerminalOperand,\n- mapTerminalSuccessors,\n+ eachTerminalSuccessor,\n } from \".\/visitors\";\n-import { printMixedHIR, printPlace, printSourceLocation } from \".\/PrintHIR\";\n \n \/**\n * For every usage of a value in the given function, infers the effect or action\n@@ -137,17 +136,9 @@ export default function inferReferenceEffects(fn: HIRFunction) {\n const environment = incomingEnvironment.clone();\n inferBlock(environment, block);\n \n- \/\/ TODO: add a `forEachTerminalSuccessor` helper, we don't actually want the result\n- \/\/ here\n- const _ = mapTerminalSuccessors(\n- block.terminal,\n- (nextBlockId, isFallthrough) => {\n- if (!isFallthrough) {\n- queue(nextBlockId, environment);\n- }\n- return nextBlockId;\n- }\n- );\n+ for (const nextBlockId of eachTerminalSuccessor(block.terminal)) {\n+ queue(nextBlockId, environment);\n+ }\n }\n }\n }\ndiff --git a\/compiler\/forget\/src\/HIR\/visitors.ts b\/compiler\/forget\/src\/HIR\/visitors.ts\nindex 67b8b0091a..c85c8529d7 100644\n--- a\/compiler\/forget\/src\/HIR\/visitors.ts\n+++ b\/compiler\/forget\/src\/HIR\/visitors.ts\n@@ -129,6 +129,43 @@ export function mapTerminalSuccessors(\n }\n }\n \n+\/**\n+ * Iterates over the successor block ids of the provided terminal. The function is called\n+ * specifically for the successors that define the standard control flow, and not\n+ * pseduo-successors such as fallthroughs.\n+ *\/\n+export function* eachTerminalSuccessor(terminal: Terminal): Iterable {\n+ switch (terminal.kind) {\n+ case \"goto\": {\n+ yield terminal.block;\n+ break;\n+ }\n+ case \"if\": {\n+ yield terminal.consequent;\n+ yield terminal.alternate;\n+ break;\n+ }\n+ case \"switch\": {\n+ for (const case_ of terminal.cases) {\n+ yield case_.block;\n+ }\n+ break;\n+ }\n+ case \"return\": {\n+ break;\n+ }\n+ case \"throw\": {\n+ break;\n+ }\n+ default: {\n+ assertExhaustive(\n+ terminal,\n+ `Unexpected terminal kind '${(terminal as any as Terminal).kind}'`\n+ );\n+ }\n+ }\n+}\n+\n export function* eachTerminalOperand(terminal: Terminal): Iterable {\n switch (terminal.kind) {\n case \"if\": {\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/component.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/component.expect.md\nindex dec530f244..f641ac34dd 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/component.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/component.expect.md\n@@ -43,7 +43,7 @@ bb0:\n [6] Const mutate max$32 = Call mutate Math$8.max(read $31, read maxItems$28)\n Goto bb1\n bb1:\n- predecessor blocks: bb0 bb4 bb7\n+ predecessor blocks: bb0 bb7 bb4\n If (read items$27) then:bb3 else:bb2\n bb3:\n predecessor blocks: bb1\n@@ -59,8 +59,8 @@ bb9:\n [10] Const mutate $39 = Call mutate seen$30.has(mutate item$10)\n Goto bb7\n bb7:\n- predecessor blocks: bb9 bb8\n- $40: phi(bb9: $39, bb8: $37)\n+ predecessor blocks: bb8 bb9\n+ $40: phi(bb8: $37, bb9: $39)\n If (read $40) then:bb1 else:bb4\n bb4:\n predecessor blocks: bb7\n@@ -71,7 +71,7 @@ bb4:\n [15] Const mutate $49 = Binary read renderedItems$29.length >= read max$32\n If (read $49) then:bb2 else:bb1\n bb2:\n- predecessor blocks: bb1 bb4\n+ predecessor blocks: bb4 bb1\n [16] Const mutate count$52 = read renderedItems$29.length\n [17] Const mutate $53 = \"div\"\n [18] Const mutate $54 = \"\\n \"\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-break.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-break.expect.md\nindex a85337da08..3c62fd6bfa 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-break.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-break.expect.md\n@@ -118,7 +118,7 @@ bb2:\n [3] Call mutate a$4.push(read props$3.c)\n Goto bb1\n bb1:\n- predecessor blocks: bb0 bb2\n+ predecessor blocks: bb2 bb0\n [4] Call mutate a$4.push(read props$3.d)\n Return freeze a$4\n ```\n@@ -218,7 +218,7 @@ bb2:\n [3] Call mutate a$4.push(read props$3.c)\n Goto bb1\n bb1:\n- predecessor blocks: bb2 bb0\n+ predecessor blocks: bb0 bb2\n [4] Call mutate a$4.push(read props$3.d)\n Return freeze a$4\n ```\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-on-mutable.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-on-mutable.expect.md\nindex 2486702d44..59ac6c8e60 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-on-mutable.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/conditional-on-mutable.expect.md\n@@ -75,14 +75,14 @@ bb2:\n [3] Call mutate a$7.push(read props$6.p0)\n Goto bb1\n bb1:\n- predecessor blocks: bb0 bb2\n+ predecessor blocks: bb2 bb0\n If (read props$6.p1) then:bb4 else:bb3\n bb4:\n predecessor blocks: bb1\n [4] Call mutate b$8.push(read props$6.p2)\n Goto bb3\n bb3:\n- predecessor blocks: bb1 bb4\n+ predecessor blocks: bb4 bb1\n [5] Const mutate $16 = JSX <\/read Foo$4>\n Return read $16\n ```\n@@ -120,14 +120,14 @@ bb2:\n [4] Call mutate a$9.push(read props$8.p0)\n Goto bb1\n bb1:\n- predecessor blocks: bb0 bb2\n+ predecessor blocks: bb2 bb0\n If (read props$8.p1) then:bb4 else:bb3\n bb4:\n predecessor blocks: bb1\n [5] Call mutate b$10.push(read props$8.p2)\n Goto bb3\n bb3:\n- predecessor blocks: bb1 bb4\n+ predecessor blocks: bb4 bb1\n [6] Const mutate $19 = JSX <\/read Foo$6>\n Return read $19\n ```\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/hooks-freeze-possibly-mutable-arguments.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/hooks-freeze-possibly-mutable-arguments.expect.md\nindex 4572b6b99d..fef3216a20 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/hooks-freeze-possibly-mutable-arguments.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/hooks-freeze-possibly-mutable-arguments.expect.md\n@@ -39,8 +39,8 @@ bb3:\n [5] Reassign mutate a$12 = Array []\n Goto bb1\n bb1:\n- predecessor blocks: bb3 bb2\n- a$14: phi(bb3: a$12, bb2: a$11)\n+ predecessor blocks: bb2 bb3\n+ a$14: phi(bb2: a$11, bb3: a$12)\n [6] Call read useFreeze$5(freeze a$14)\n [7] Call read useFreeze$5(read a$14)\n [8] Call mutate call$6(read a$14)\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/independent-across-if.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/independent-across-if.expect.md\nindex f06f4eacbc..e0b43d1597 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/independent-across-if.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/independent-across-if.expect.md\n@@ -106,7 +106,7 @@ bb2:\n [4] Call mutate mutate$5(mutate b$10)\n Goto bb1\n bb1:\n- predecessor blocks: bb0 bb2\n+ predecessor blocks: bb2 bb0\n [5] Const mutate $14 = JSX <\/read Foo$6>\n Return read $14\n ```\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/interdependent-across-if.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/interdependent-across-if.expect.md\nindex e5c457b009..9fbe734999 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/interdependent-across-if.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/interdependent-across-if.expect.md\n@@ -84,7 +84,7 @@ bb2:\n [3] Call mutate foo$5(mutate a$9, mutate b$10)\n Goto bb1\n bb1:\n- predecessor blocks: bb0 bb2\n+ predecessor blocks: bb2 bb0\n [4] Const mutate $14 = JSX <\/read Foo$6>\n Return read $14\n ```\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/logical-expression.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/logical-expression.expect.md\nindex fd0ba8ce8a..99dc706b61 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/logical-expression.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/logical-expression.expect.md\n@@ -34,8 +34,8 @@ bb3:\n [3] Const mutate $7 = read $5\n Goto bb1\n bb1:\n- predecessor blocks: bb3 bb2\n- $8: phi(bb3: $7, bb2: $6)\n+ predecessor blocks: bb2 bb3\n+ $8: phi(bb2: $6, bb3: $7)\n Return freeze $8\n ```\n \n@@ -67,8 +67,8 @@ bb3:\n [3] Const mutate $7 = Call mutate g$4()\n Goto bb1\n bb1:\n- predecessor blocks: bb3 bb2\n- $8: phi(bb3: $7, bb2: $6)\n+ predecessor blocks: bb2 bb3\n+ $8: phi(bb2: $6, bb3: $7)\n Return freeze $8\n ```\n \n@@ -102,8 +102,8 @@ bb3:\n [5] Const mutate $13 = Call mutate g$7()\n Goto bb1\n bb1:\n- predecessor blocks: bb3 bb2\n- $14: phi(bb3: $13, bb2: $12)\n+ predecessor blocks: bb2 bb3\n+ $14: phi(bb2: $12, bb3: $13)\n Return freeze $14\n ```\n \ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/mutable-lifetime-loops.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/mutable-lifetime-loops.expect.md\nindex 097321fec6..954120c3ae 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/mutable-lifetime-loops.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/mutable-lifetime-loops.expect.md\n@@ -97,11 +97,11 @@ bb3:\n [12] Const mutate $29 = Call mutate cond$8(mutate a$21)\n If (read $29) then:bb2 else:bb1\n bb2:\n- predecessor blocks: bb1 bb3\n- a$30: phi(bb1: a$18, bb3: a$21)\n- b$31: phi(bb1: b$20, bb3: b$23)\n- c$32: phi(bb1: c$22, bb3: c$25)\n- d$33[-1:14]: phi(bb1: d$24, bb3: d$26)\n+ predecessor blocks: bb3 bb1\n+ a$30: phi(bb3: a$21, bb1: a$18)\n+ b$31: phi(bb3: b$23, bb1: b$20)\n+ c$32: phi(bb3: c$25, bb1: c$22)\n+ d$33[-1:14]: phi(bb3: d$26, bb1: d$24)\n If (read a$30) then:bb7 else:bb7\n bb7:\n predecessor blocks: bb2\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/mutable-liverange-loop.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/mutable-liverange-loop.expect.md\nindex 3525d20b4b..7c1f565124 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/mutable-liverange-loop.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/mutable-liverange-loop.expect.md\n@@ -83,7 +83,7 @@ bb3:\n [7] Const mutate $21 = Call mutate cond$7(mutate a$12)\n If (read $21) then:bb2 else:bb1\n bb2:\n- predecessor blocks: bb1 bb3\n+ predecessor blocks: bb3 bb1\n If (read a$12) then:bb7 else:bb7\n bb7:\n predecessor blocks: bb2\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/reassignment-conditional.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/reassignment-conditional.expect.md\nindex 35613a3c03..381a43c0f3 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/reassignment-conditional.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/reassignment-conditional.expect.md\n@@ -32,8 +32,8 @@ bb2:\n [4] Reassign mutate x$9 = Array []\n Goto bb1\n bb1:\n- predecessor blocks: bb0 bb2\n- x$11: phi(bb0: x$7, bb2: x$9)\n+ predecessor blocks: bb2 bb0\n+ x$11: phi(bb2: x$9, bb0: x$7)\n [5] Let mutate _$12 = JSX <\/read Component$0>\n [6] Call read y$8.push(read props$6.p2)\n [7] Const mutate $15 = JSX <\/read Component$0>\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/reverse-postorder.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/reverse-postorder.expect.md\nindex d086ca9225..0f68566208 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/reverse-postorder.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/reverse-postorder.expect.md\n@@ -72,8 +72,8 @@ bb13:\n [9] Reassign mutate x$15 = read props$6.c\n Goto bb1\n bb1:\n- predecessor blocks: bb13 bb12 bb8 bb6 bb4\n- x$16: phi(bb13: x$15, bb12: x$14, bb8: x$11, bb6: x$12, bb4: x$13)\n+ predecessor blocks: bb8 bb6 bb4 bb12 bb13\n+ x$16: phi(bb8: x$11, bb6: x$12, bb4: x$13, bb12: x$14, bb13: x$15)\n [10] read x$16\n Return\n ```\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-call-jsx-2.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-call-jsx-2.expect.md\nindex ae6089d562..f436bd8709 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-call-jsx-2.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-call-jsx-2.expect.md\n@@ -48,7 +48,7 @@ bb2:\n [6] Let mutate _$15 = JSX <\/read $14>\n Goto bb1\n bb1:\n- predecessor blocks: bb0 bb2\n+ predecessor blocks: bb2 bb0\n [7] Call mutate foo$4(read a$11, mutate b$12)\n [8] Const mutate $19 = \"div\"\n [9] Const mutate $20 = JSX <\/read $19>\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-complex-multiple-if.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-complex-multiple-if.expect.md\nindex 71d82b5c4d..549e167937 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-complex-multiple-if.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-complex-multiple-if.expect.md\n@@ -31,8 +31,8 @@ bb2:\n [5] Reassign mutate x$11 = 3\n Goto bb1\n bb1:\n- predecessor blocks: bb0 bb2\n- x$17: phi(bb0: x$7, bb2: x$11)\n+ predecessor blocks: bb2 bb0\n+ x$17: phi(bb2: x$11, bb0: x$7)\n [6] Const mutate $12 = 3\n [7] Const mutate $14 = Binary read y$8 === read $12\n If (read $14) then:bb4 else:bb3\n@@ -41,8 +41,8 @@ bb4:\n [8] Reassign mutate x$15 = 5\n Goto bb3\n bb3:\n- predecessor blocks: bb1 bb4\n- x$16: phi(bb1: x$17, bb4: x$15)\n+ predecessor blocks: bb4 bb1\n+ x$16: phi(bb4: x$15, bb1: x$17)\n [9] Reassign mutate y$18 = read x$16\n Return\n ```\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-complex-single-if.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-complex-single-if.expect.md\nindex 68bce41d37..02c4ad3059 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-complex-single-if.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-complex-single-if.expect.md\n@@ -28,8 +28,8 @@ bb2:\n [5] Reassign mutate x$9 = 3\n Goto bb1\n bb1:\n- predecessor blocks: bb0 bb2\n- x$10: phi(bb0: x$5, bb2: x$9)\n+ predecessor blocks: bb2 bb0\n+ x$10: phi(bb2: x$9, bb0: x$5)\n [6] Reassign mutate y$11 = read x$10\n Return\n ```\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-for-of.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-for-of.expect.md\nindex 1a77838fda..d4b10a2296 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-for-of.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-for-of.expect.md\n@@ -22,7 +22,7 @@ bb0:\n [1] Let mutate items$5 = Array []\n Goto bb1\n bb1:\n- predecessor blocks: bb0 bb3 bb5\n+ predecessor blocks: bb0 bb5 bb3\n If (read items$5) then:bb3 else:bb2\n bb3:\n predecessor blocks: bb1\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-if-else.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-if-else.expect.md\nindex 0e1063759b..84479fb53c 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-if-else.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-if-else.expect.md\n@@ -31,7 +31,7 @@ bb3:\n [4] Let mutate z$8 = read x$5\n Goto bb1\n bb1:\n- predecessor blocks: bb3 bb2\n+ predecessor blocks: bb2 bb3\n Return\n ```\n \ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-objectexpression-phi.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-objectexpression-phi.expect.md\nindex b9459ed34e..9960e3a350 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-objectexpression-phi.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-objectexpression-phi.expect.md\n@@ -36,9 +36,9 @@ bb3:\n [6] Reassign mutate y$11 = 3\n Goto bb1\n bb1:\n- predecessor blocks: bb3 bb2\n- x$12: phi(bb3: x$6, bb2: x$10)\n- y$13: phi(bb3: y$11, bb2: y$7)\n+ predecessor blocks: bb2 bb3\n+ x$12: phi(bb2: x$10, bb3: x$6)\n+ y$13: phi(bb2: y$7, bb3: y$11)\n [7] Let mutate t$14 = Object { x: read x$12, y: read y$13 }\n Return freeze t$14\n ```\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-return.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-return.expect.md\nindex 8c7c5be957..bdffb7a035 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-return.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-return.expect.md\n@@ -26,8 +26,8 @@ bb2:\n [4] Reassign mutate x$7 = 2\n Goto bb1\n bb1:\n- predecessor blocks: bb0 bb2\n- x$8: phi(bb0: x$4, bb2: x$7)\n+ predecessor blocks: bb2 bb0\n+ x$8: phi(bb2: x$7, bb0: x$4)\n Return read x$8\n ```\n \ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-simple-phi.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-simple-phi.expect.md\nindex 08c43662d3..2f0495755d 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-simple-phi.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-simple-phi.expect.md\n@@ -33,8 +33,8 @@ bb3:\n [5] Reassign mutate y$9 = 2\n Goto bb1\n bb1:\n- predecessor blocks: bb3 bb2\n- y$10: phi(bb3: y$9, bb2: y$8)\n+ predecessor blocks: bb2 bb3\n+ y$10: phi(bb2: y$8, bb3: y$9)\n [6] Let mutate x$11 = read y$10\n Return\n ```\ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-single-if.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-single-if.expect.md\nindex bbd0b8499c..85664e30cf 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-single-if.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-single-if.expect.md\n@@ -25,7 +25,7 @@ bb2:\n [3] Let mutate z$6 = Binary read x$4 + read y$5\n Goto bb1\n bb1:\n- predecessor blocks: bb0 bb2\n+ predecessor blocks: bb2 bb0\n Return\n ```\n \ndiff --git a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-throw.expect.md b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-throw.expect.md\nindex 504f6a72e4..7a199a5958 100644\n--- a\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-throw.expect.md\n+++ b\/compiler\/forget\/src\/__tests__\/fixtures\/hir\/ssa-throw.expect.md\n@@ -25,8 +25,8 @@ bb2:\n [4] Reassign mutate x$7 = 2\n Goto bb1\n bb1:\n- predecessor blocks: bb0 bb2\n- x$8: phi(bb0: x$4, bb2: x$7)\n+ predecessor blocks: bb2 bb0\n+ x$8: phi(bb2: x$7, bb0: x$4)\n Throw read x$8\n ```\n \n"}

dillon1000/react

Files changed