{"parents":["f4744f3a70f3c07e7dfa1e849adcefce4c4528e5","7d699f40638927375174746bd5e24abff0043512"],"commit":{"subject":"Merge pull request #5595 from remko\/select-bug","shortRevision":"2f77367863","authoredAt":"2015-12-04T11:12:23-08:00","authorName":"Ben Alpert","revision":"2f7736786303d3b6d845bea13a971700254a78a1","authorEmail":"ben@benalpert.com"},"files":[{"path":"src\/renderers\/dom\/client\/wrappers\/ReactDOMSelect.js","status":"M"},{"path":"src\/renderers\/dom\/client\/wrappers\/__tests__\/ReactDOMSelect-test.js","status":"M"}],"body":"Fix single select incorrectly updating","patch":"diff --git a\/src\/renderers\/dom\/client\/wrappers\/ReactDOMSelect.js b\/src\/renderers\/dom\/client\/wrappers\/ReactDOMSelect.js\nindex bf36fc19c2..6e75a9e3e2 100644\n--- a\/src\/renderers\/dom\/client\/wrappers\/ReactDOMSelect.js\n+++ b\/src\/renderers\/dom\/client\/wrappers\/ReactDOMSelect.js\n@@ -29,7 +29,7 @@ function updateOptionsIfPendingUpdateAndMounted() {\n var value = LinkedValueUtils.getValue(props);\n \n if (value != null) {\n- updateOptions(this, props, value);\n+ updateOptions(this, Boolean(props.multiple), value);\n }\n }\n }\ndiff --git a\/src\/renderers\/dom\/client\/wrappers\/__tests__\/ReactDOMSelect-test.js b\/src\/renderers\/dom\/client\/wrappers\/__tests__\/ReactDOMSelect-test.js\nindex 56ee48e11a..f3f3090c29 100644\n--- a\/src\/renderers\/dom\/client\/wrappers\/__tests__\/ReactDOMSelect-test.js\n+++ b\/src\/renderers\/dom\/client\/wrappers\/__tests__\/ReactDOMSelect-test.js\n@@ -475,4 +475,19 @@ describe('ReactDOMSelect', function() {\n ReactTestUtils.renderIntoDocument(\n+

dillon1000/react

Files changed