{"body":"Cleans up this experiment. After some internal experimentation we are\ndeprioritizing this project for now and may revisit it at a later point.","files":[{"path":"packages\/react-debug-tools\/src\/ReactDebugHooks.js","status":"M"},{"path":"packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationHooks-test.js","status":"M"},{"path":"packages\/react-reconciler\/src\/ReactFiberCallUserSpace.js","status":"M"},{"path":"packages\/react-reconciler\/src\/ReactFiberCommitEffects.js","status":"M"},{"path":"packages\/react-reconciler\/src\/ReactFiberHooks.js","status":"M"},{"path":"packages\/react-reconciler\/src\/ReactInternalTypes.js","status":"M"},{"path":"packages\/react-reconciler\/src\/__tests__\/ReactHooksWithNoopRenderer-test.js","status":"M"},{"path":"packages\/react\/src\/ReactHooks.js","status":"M"},{"path":"packages\/shared\/ReactFeatureFlags.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.native-fb-dynamic.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.native-fb.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.native-oss.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.native-fb.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.test-renderer.www.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.www-dynamic.js","status":"M"},{"path":"packages\/shared\/forks\/ReactFeatureFlags.www.js","status":"M"}],"parents":["f99c9feaf786fbdad0ad8d2d81196a247302dd3c"],"patch":"diff --git a\/packages\/react-debug-tools\/src\/ReactDebugHooks.js b\/packages\/react-debug-tools\/src\/ReactDebugHooks.js\nindex 798cdec438..5cf93c587d 100644\n--- a\/packages\/react-debug-tools\/src\/ReactDebugHooks.js\n+++ b\/packages\/react-debug-tools\/src\/ReactDebugHooks.js\n@@ -374,11 +374,8 @@ function useInsertionEffect(\n }\n \n function useEffect(\n- create: (() => (() => void) | void) | (() => {...} | void | null),\n- createDeps: Array | void | null,\n- update?: ((resource: {...} | void | null) => void) | void,\n- updateDeps?: Array | void | null,\n- destroy?: ((resource: {...} | void | null) => void) | void,\n+ create: () => (() => void) | void,\n+ deps: Array | void | null,\n ): void {\n nextHook();\n hookLog.push({\ndiff --git a\/packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationHooks-test.js b\/packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationHooks-test.js\nindex 840d6c5b15..e1aeea70fd 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationHooks-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactDOMServerIntegrationHooks-test.js\n@@ -653,52 +653,6 @@ describe('ReactDOMServerHooks', () => {\n });\n });\n \n- describe('useEffect with CRUD overload', () => {\n- gate(flags => {\n- if (flags.enableUseEffectCRUDOverload) {\n- const yields = [];\n- itRenders(\n- 'should ignore resource effects on the server',\n- async render => {\n- function Counter(props) {\n- useEffect(\n- () => {\n- yieldValue('created on client');\n- return {resource_counter: props.count};\n- },\n- [props.count],\n- resource => {\n- resource.resource_counter = props.count;\n- yieldValue('updated on client');\n- },\n- [props.count],\n- () => {\n- yieldValue('cleanup on client');\n- },\n- );\n- return ;\n- }\n-\n- const domNode = await render();\n- yields.push(clearLog());\n- expect(domNode.tagName).toEqual('SPAN');\n- expect(domNode.textContent).toEqual('Count: 0');\n- },\n- );\n-\n- it('verifies yields in order', () => {\n- expect(yields).toEqual([\n- ['Count: 0'], \/\/ server render\n- ['Count: 0'], \/\/ server stream\n- ['Count: 0', 'created on client'], \/\/ clean render\n- ['Count: 0', 'created on client'], \/\/ hydrated render\n- \/\/ nothing yielded for bad markup\n- ]);\n- });\n- }\n- });\n- });\n-\n describe('useContext', () => {\n itThrowsWhenRendering(\n 'if used inside a class component',\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberCallUserSpace.js b\/packages\/react-reconciler\/src\/ReactFiberCallUserSpace.js\nindex a9b5590f38..b48933fe3c 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberCallUserSpace.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberCallUserSpace.js\n@@ -14,11 +14,6 @@ import type {CapturedValue} from '.\/ReactCapturedValue';\n \n import {isRendering, setIsRendering} from '.\/ReactCurrentFiber';\n import {captureCommitPhaseError} from '.\/ReactFiberWorkLoop';\n-import {\n- ResourceEffectIdentityKind,\n- ResourceEffectUpdateKind,\n-} from '.\/ReactFiberHooks';\n-import {enableUseEffectCRUDOverload} from 'shared\/ReactFeatureFlags';\n \n \/\/ These indirections exists so we can exclude its stack frame in DEV (and anything below it).\n \/\/ TODO: Consider marking the whole bundle instead of these boundaries.\n@@ -184,51 +179,11 @@ const callCreate = {\n 'react-stack-bottom-frame': function (\n effect: Effect,\n ): (() => void) | {...} | void | null {\n- if (!enableUseEffectCRUDOverload) {\n- if (effect.resourceKind != null) {\n- if (__DEV__) {\n- console.error(\n- 'Expected only SimpleEffects when enableUseEffectCRUDOverload is disabled, ' +\n- 'got %s',\n- effect.resourceKind,\n- );\n- }\n- }\n- const create = effect.create;\n- const inst = effect.inst;\n- \/\/ $FlowFixMe[not-a-function] (@poteto)\n- const destroy = create();\n- \/\/ $FlowFixMe[incompatible-type] (@poteto)\n- inst.destroy = destroy;\n- return destroy;\n- } else {\n- if (effect.resourceKind == null) {\n- const create = effect.create;\n- const inst = effect.inst;\n- const destroy = create();\n- inst.destroy = destroy;\n- return destroy;\n- }\n- switch (effect.resourceKind) {\n- case ResourceEffectIdentityKind: {\n- return effect.create();\n- }\n- case ResourceEffectUpdateKind: {\n- if (typeof effect.update === 'function') {\n- effect.update(effect.inst.resource);\n- }\n- break;\n- }\n- default: {\n- if (__DEV__) {\n- console.error(\n- 'Unhandled Effect kind %s. This is a bug in React.',\n- effect.kind,\n- );\n- }\n- }\n- }\n- }\n+ const create = effect.create;\n+ const inst = effect.inst;\n+ const destroy = create();\n+ inst.destroy = destroy;\n+ return destroy;\n },\n };\n \ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberCommitEffects.js b\/packages\/react-reconciler\/src\/ReactFiberCommitEffects.js\nindex a0f6b54780..cc393b5899 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberCommitEffects.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberCommitEffects.js\n@@ -23,7 +23,6 @@ import {\n enableProfilerCommitHooks,\n enableProfilerNestedUpdatePhase,\n enableSchedulingProfiler,\n- enableUseEffectCRUDOverload,\n enableViewTransition,\n enableFragmentRefs,\n } from 'shared\/ReactFeatureFlags';\n@@ -62,7 +61,6 @@ import {\n Layout as HookLayout,\n Insertion as HookInsertion,\n Passive as HookPassive,\n- HasEffect as HookHasEffect,\n } from '.\/ReactHookEffectTags';\n import {didWarnAboutReassigningProps} from '.\/ReactFiberBeginWork';\n import {\n@@ -84,10 +82,6 @@ import {\n } from '.\/ReactFiberCallUserSpace';\n \n import {runWithFiberInDEV} from '.\/ReactCurrentFiber';\n-import {\n- ResourceEffectIdentityKind,\n- ResourceEffectUpdateKind,\n-} from '.\/ReactFiberHooks';\n \n function shouldProfile(current: Fiber): boolean {\n return (\n@@ -164,91 +158,19 @@ export function commitHookEffectListMount(\n \n \/\/ Mount\n let destroy;\n- if (enableUseEffectCRUDOverload) {\n- if (effect.resourceKind === ResourceEffectIdentityKind) {\n- if (__DEV__) {\n- effect.inst.resource = runWithFiberInDEV(\n- finishedWork,\n- callCreateInDEV,\n- effect,\n- );\n- if (effect.inst.resource == null) {\n- console.error(\n- 'useEffect must provide a callback which returns a resource. ' +\n- 'If a managed resource is not needed here, do not provide an updater or ' +\n- 'destroy callback. Received %s',\n- effect.inst.resource,\n- );\n- }\n- } else {\n- effect.inst.resource = effect.create();\n- }\n- destroy = effect.inst.destroy;\n- }\n- if (effect.resourceKind === ResourceEffectUpdateKind) {\n- if (\n- \/\/ We don't want to fire updates on remount during Activity\n- (flags & HookHasEffect) > 0 &&\n- typeof effect.update === 'function' &&\n- effect.inst.resource != null\n- ) {\n- \/\/ TODO(@poteto) what about multiple updates?\n- if (__DEV__) {\n- runWithFiberInDEV(finishedWork, callCreateInDEV, effect);\n- } else {\n- effect.update(effect.inst.resource);\n- }\n- }\n- }\n- }\n if (__DEV__) {\n if ((flags & HookInsertion) !== NoHookEffect) {\n setIsRunningInsertionEffect(true);\n }\n- if (enableUseEffectCRUDOverload) {\n- if (effect.resourceKind == null) {\n- destroy = runWithFiberInDEV(\n- finishedWork,\n- callCreateInDEV,\n- effect,\n- );\n- }\n- } else {\n- destroy = runWithFiberInDEV(\n- finishedWork,\n- callCreateInDEV,\n- effect,\n- );\n- }\n+ destroy = runWithFiberInDEV(finishedWork, callCreateInDEV, effect);\n if ((flags & HookInsertion) !== NoHookEffect) {\n setIsRunningInsertionEffect(false);\n }\n } else {\n- if (enableUseEffectCRUDOverload) {\n- if (effect.resourceKind == null) {\n- const create = effect.create;\n- const inst = effect.inst;\n- destroy = create();\n- inst.destroy = destroy;\n- }\n- } else {\n- if (effect.resourceKind != null) {\n- if (__DEV__) {\n- console.error(\n- 'Expected only SimpleEffects when enableUseEffectCRUDOverload is disabled, ' +\n- 'got %s',\n- effect.resourceKind,\n- );\n- }\n- }\n- const create = effect.create;\n- const inst = effect.inst;\n- \/\/ $FlowFixMe[incompatible-type] (@poteto)\n- \/\/ $FlowFixMe[not-a-function] (@poteto)\n- destroy = create();\n- \/\/ $FlowFixMe[incompatible-type] (@poteto)\n- inst.destroy = destroy;\n- }\n+ const create = effect.create;\n+ const inst = effect.inst;\n+ destroy = create();\n+ inst.destroy = destroy;\n }\n \n if (enableSchedulingProfiler) {\n@@ -338,13 +260,7 @@ export function commitHookEffectListUnmount(\n const inst = effect.inst;\n const destroy = inst.destroy;\n if (destroy !== undefined) {\n- if (enableUseEffectCRUDOverload) {\n- if (effect.resourceKind == null) {\n- inst.destroy = undefined;\n- }\n- } else {\n- inst.destroy = undefined;\n- }\n+ inst.destroy = undefined;\n if (enableSchedulingProfiler) {\n if ((flags & HookPassive) !== NoHookEffect) {\n markComponentPassiveEffectUnmountStarted(finishedWork);\n@@ -358,41 +274,7 @@ export function commitHookEffectListUnmount(\n setIsRunningInsertionEffect(true);\n }\n }\n- if (enableUseEffectCRUDOverload) {\n- if (\n- effect.resourceKind === ResourceEffectIdentityKind &&\n- effect.inst.resource != null\n- ) {\n- safelyCallDestroy(\n- finishedWork,\n- nearestMountedAncestor,\n- destroy,\n- effect.inst.resource,\n- );\n- if (effect.next.resourceKind === ResourceEffectUpdateKind) {\n- \/\/ $FlowFixMe[prop-missing] (@poteto)\n- effect.next.update = undefined;\n- } else {\n- if (__DEV__) {\n- console.error(\n- 'Expected a ResourceEffectUpdateKind to follow ResourceEffectIdentityKind, ' +\n- 'got %s. This is a bug in React.',\n- effect.next.resourceKind,\n- );\n- }\n- }\n- effect.inst.resource = null;\n- }\n- if (effect.resourceKind == null) {\n- safelyCallDestroy(\n- finishedWork,\n- nearestMountedAncestor,\n- destroy,\n- );\n- }\n- } else {\n- safelyCallDestroy(finishedWork, nearestMountedAncestor, destroy);\n- }\n+ safelyCallDestroy(finishedWork, nearestMountedAncestor, destroy);\n if (__DEV__) {\n if ((flags & HookInsertion) !== NoHookEffect) {\n setIsRunningInsertionEffect(false);\ndiff --git a\/packages\/react-reconciler\/src\/ReactFiberHooks.js b\/packages\/react-reconciler\/src\/ReactFiberHooks.js\nindex 270cd87d49..30dc3f9138 100644\n--- a\/packages\/react-reconciler\/src\/ReactFiberHooks.js\n+++ b\/packages\/react-reconciler\/src\/ReactFiberHooks.js\n@@ -43,7 +43,6 @@ import {\n enableSchedulingProfiler,\n enableTransitionTracing,\n enableUseEffectEventHook,\n- enableUseEffectCRUDOverload,\n enableLegacyCache,\n disableLegacyMode,\n enableNoCloningMemoCache,\n@@ -219,43 +218,16 @@ export type Hook = {\n \/\/ the additional memory and we can follow up with performance\n \/\/ optimizations later.\n type EffectInstance = {\n- resource: {...} | void | null,\n- destroy: void | (() => void) | ((resource: {...} | void | null) => void),\n+ destroy: void | (() => void),\n };\n \n-export const ResourceEffectIdentityKind: 0 = 0;\n-export const ResourceEffectUpdateKind: 1 = 1;\n-export type EffectKind =\n- | typeof ResourceEffectIdentityKind\n- | typeof ResourceEffectUpdateKind;\n-export type Effect =\n- | SimpleEffect\n- | ResourceEffectIdentity\n- | ResourceEffectUpdate;\n-export type SimpleEffect = {\n+export type Effect = {\n tag: HookFlags,\n inst: EffectInstance,\n create: () => (() => void) | void,\n deps: Array | void | null,\n next: Effect,\n };\n-export type ResourceEffectIdentity = {\n- resourceKind: typeof ResourceEffectIdentityKind,\n- tag: HookFlags,\n- inst: EffectInstance,\n- create: () => {...} | void | null,\n- deps: Array | void | null,\n- next: Effect,\n-};\n-export type ResourceEffectUpdate = {\n- resourceKind: typeof ResourceEffectUpdateKind,\n- tag: HookFlags,\n- inst: EffectInstance,\n- update: ((resource: {...} | void | null) => void) | void,\n- deps: Array | void | null,\n- next: Effect,\n- identity: ResourceEffectIdentity,\n-};\n \n type StoreInstance = {\n value: T,\n@@ -377,23 +349,6 @@ function checkDepsAreArrayDev(deps: mixed): void {\n }\n }\n \n-function checkDepsAreNonEmptyArrayDev(deps: mixed): void {\n- if (__DEV__) {\n- if (\n- deps !== undefined &&\n- deps !== null &&\n- isArray(deps) &&\n- deps.length === 0\n- ) {\n- console.error(\n- '%s received a dependency array with no dependencies. When ' +\n- 'specified, the dependency array must have at least one dependency.',\n- currentHookNameInDev,\n- );\n- }\n- }\n-}\n-\n function warnOnHookMismatchInDev(currentHookName: HookType): void {\n if (__DEV__) {\n const componentName = getComponentNameFromFiber(currentlyRenderingFiber);\n@@ -2540,15 +2495,12 @@ function pushSimpleEffect(\n tag: HookFlags,\n inst: EffectInstance,\n create: () => (() => void) | void,\n- createDeps: Array | void | null,\n- update?: ((resource: {...} | void | null) => void) | void,\n- updateDeps?: Array | void | null,\n- destroy?: ((resource: {...} | void | null) => void) | void,\n+ deps: Array | void | null,\n ): Effect {\n const effect: Effect = {\n tag,\n create,\n- deps: createDeps,\n+ deps,\n inst,\n \/\/ Circular\n next: (null: any),\n@@ -2556,39 +2508,6 @@ function pushSimpleEffect(\n return pushEffectImpl(effect);\n }\n \n-function pushResourceEffect(\n- identityTag: HookFlags,\n- updateTag: HookFlags,\n- inst: EffectInstance,\n- create: () => {...} | void | null,\n- createDeps: Array | void | null,\n- update: ((resource: {...} | void | null) => void) | void,\n- updateDeps: Array | void | null,\n-): Effect {\n- const effectIdentity: ResourceEffectIdentity = {\n- resourceKind: ResourceEffectIdentityKind,\n- tag: identityTag,\n- create,\n- deps: createDeps,\n- inst,\n- \/\/ Circular\n- next: (null: any),\n- };\n- pushEffectImpl(effectIdentity);\n-\n- const effectUpdate: ResourceEffectUpdate = {\n- resourceKind: ResourceEffectUpdateKind,\n- tag: updateTag,\n- update,\n- deps: updateDeps,\n- inst,\n- identity: effectIdentity,\n- \/\/ Circular\n- next: (null: any),\n- };\n- return pushEffectImpl(effectUpdate);\n-}\n-\n function pushEffectImpl(effect: Effect): Effect {\n let componentUpdateQueue: null | FunctionComponentUpdateQueue =\n (currentlyRenderingFiber.updateQueue: any);\n@@ -2609,7 +2528,7 @@ function pushEffectImpl(effect: Effect): Effect {\n }\n \n function createEffectInstance(): EffectInstance {\n- return {destroy: undefined, resource: undefined};\n+ return {destroy: undefined};\n }\n \n function mountRef(initialValue: T): {current: T} {\n@@ -2628,13 +2547,10 @@ function mountEffectImpl(\n fiberFlags: Flags,\n hookFlags: HookFlags,\n create: () => (() => void) | void,\n- createDeps: Array | void | null,\n- update?: ((resource: {...} | void | null) => void) | void,\n- updateDeps?: Array | void | null,\n- destroy?: ((resource: {...} | void | null) => void) | void,\n+ deps: Array | void | null,\n ): void {\n const hook = mountWorkInProgressHook();\n- const nextDeps = createDeps === undefined ? null : createDeps;\n+ const nextDeps = deps === undefined ? null : deps;\n currentlyRenderingFiber.flags |= fiberFlags;\n hook.memoizedState = pushSimpleEffect(\n HookHasEffect | hookFlags,\n@@ -2685,223 +2601,35 @@ function updateEffectImpl(\n }\n \n function mountEffect(\n- create: (() => (() => void) | void) | (() => {...} | void | null),\n- createDeps: Array | void | null,\n- update?: ((resource: {...} | void | null) => void) | void,\n- updateDeps?: Array | void | null,\n- destroy?: ((resource: {...} | void | null) => void) | void,\n+ create: () => (() => void) | void,\n+ deps: Array | void | null,\n ): void {\n if (\n __DEV__ &&\n (currentlyRenderingFiber.mode & StrictEffectsMode) !== NoMode &&\n (currentlyRenderingFiber.mode & NoStrictPassiveEffectsMode) === NoMode\n ) {\n- if (\n- enableUseEffectCRUDOverload &&\n- (typeof update === 'function' || typeof destroy === 'function')\n- ) {\n- mountResourceEffectImpl(\n- MountPassiveDevEffect | PassiveEffect | PassiveStaticEffect,\n- HookPassive,\n- create,\n- createDeps,\n- update,\n- updateDeps,\n- destroy,\n- );\n- } else {\n- mountEffectImpl(\n- MountPassiveDevEffect | PassiveEffect | PassiveStaticEffect,\n- HookPassive,\n- \/\/ $FlowFixMe[incompatible-call] @poteto it's not possible to narrow `create` without calling it.\n- create,\n- createDeps,\n- );\n- }\n- } else {\n- if (\n- enableUseEffectCRUDOverload &&\n- (typeof update === 'function' || typeof destroy === 'function')\n- ) {\n- mountResourceEffectImpl(\n- PassiveEffect | PassiveStaticEffect,\n- HookPassive,\n- create,\n- createDeps,\n- update,\n- updateDeps,\n- destroy,\n- );\n- } else {\n- mountEffectImpl(\n- PassiveEffect | PassiveStaticEffect,\n- HookPassive,\n- \/\/ $FlowFixMe[incompatible-call] @poteto it's not possible to narrow `create` without calling it.\n- create,\n- createDeps,\n- );\n- }\n- }\n-}\n-\n-function updateEffect(\n- create: (() => (() => void) | void) | (() => {...} | void | null),\n- createDeps: Array | void | null,\n- update?: ((resource: {...} | void | null) => void) | void,\n- updateDeps?: Array | void | null,\n- destroy?: ((resource: {...} | void | null) => void) | void,\n-): void {\n- if (\n- enableUseEffectCRUDOverload &&\n- (typeof update === 'function' || typeof destroy === 'function')\n- ) {\n- updateResourceEffectImpl(\n- PassiveEffect,\n+ mountEffectImpl(\n+ MountPassiveDevEffect | PassiveEffect | PassiveStaticEffect,\n HookPassive,\n create,\n- createDeps,\n- update,\n- updateDeps,\n- destroy,\n+ deps,\n );\n } else {\n- \/\/ $FlowFixMe[incompatible-call] @poteto it's not possible to narrow `create` without calling it.\n- updateEffectImpl(PassiveEffect, HookPassive, create, createDeps);\n- }\n-}\n-\n-function mountResourceEffect(\n- create: () => {...} | void | null,\n- createDeps: Array | void | null,\n- update: ((resource: {...} | void | null) => void) | void,\n- updateDeps: Array | void | null,\n- destroy: ((resource: {...} | void | null) => void) | void,\n-) {\n- if (\n- __DEV__ &&\n- (currentlyRenderingFiber.mode & StrictEffectsMode) !== NoMode &&\n- (currentlyRenderingFiber.mode & NoStrictPassiveEffectsMode) === NoMode\n- ) {\n- } else {\n- mountResourceEffectImpl(\n+ mountEffectImpl(\n PassiveEffect | PassiveStaticEffect,\n HookPassive,\n create,\n- createDeps,\n- update,\n- updateDeps,\n- destroy,\n+ deps,\n );\n }\n }\n \n-function mountResourceEffectImpl(\n- fiberFlags: Flags,\n- hookFlags: HookFlags,\n- create: () => {...} | void | null,\n- createDeps: Array | void | null,\n- update: ((resource: {...} | void | null) => void) | void,\n- updateDeps: Array | void | null,\n- destroy: ((resource: {...} | void | null) => void) | void,\n-) {\n- const hook = mountWorkInProgressHook();\n- currentlyRenderingFiber.flags |= fiberFlags;\n- const inst = createEffectInstance();\n- inst.destroy = destroy;\n- hook.memoizedState = pushResourceEffect(\n- HookHasEffect | hookFlags,\n- hookFlags,\n- inst,\n- create,\n- createDeps,\n- update,\n- updateDeps,\n- );\n-}\n-\n-function updateResourceEffect(\n- create: () => {...} | void | null,\n- createDeps: Array | void | null,\n- update: ((resource: {...} | void | null) => void) | void,\n- updateDeps: Array | void | null,\n- destroy: ((resource: {...} | void | null) => void) | void,\n-) {\n- updateResourceEffectImpl(\n- PassiveEffect,\n- HookPassive,\n- create,\n- createDeps,\n- update,\n- updateDeps,\n- destroy,\n- );\n-}\n-\n-function updateResourceEffectImpl(\n- fiberFlags: Flags,\n- hookFlags: HookFlags,\n- create: () => {...} | void | null,\n- createDeps: Array | void | null,\n- update: ((resource: {...} | void | null) => void) | void,\n- updateDeps: Array | void | null,\n- destroy: ((resource: {...} | void | null) => void) | void,\n-) {\n- const hook = updateWorkInProgressHook();\n- const effect: Effect = hook.memoizedState;\n- const inst = effect.inst;\n- inst.destroy = destroy;\n-\n- const nextCreateDeps = createDeps === undefined ? null : createDeps;\n- const nextUpdateDeps = updateDeps === undefined ? null : updateDeps;\n- let isCreateDepsSame: boolean;\n- let isUpdateDepsSame: boolean;\n-\n- if (currentHook !== null) {\n- const prevEffect: Effect = currentHook.memoizedState;\n- if (nextCreateDeps !== null) {\n- let prevCreateDeps;\n- if (\n- prevEffect.resourceKind != null &&\n- prevEffect.resourceKind === ResourceEffectUpdateKind\n- ) {\n- prevCreateDeps =\n- prevEffect.identity.deps != null ? prevEffect.identity.deps : null;\n- } else {\n- throw new Error(\n- `Expected a ResourceEffectUpdate to be pushed together with ResourceEffectIdentity. This is a bug in React.`,\n- );\n- }\n- isCreateDepsSame = areHookInputsEqual(nextCreateDeps, prevCreateDeps);\n- }\n- if (nextUpdateDeps !== null) {\n- let prevUpdateDeps;\n- if (\n- prevEffect.resourceKind != null &&\n- prevEffect.resourceKind === ResourceEffectUpdateKind\n- ) {\n- prevUpdateDeps = prevEffect.deps != null ? prevEffect.deps : null;\n- } else {\n- throw new Error(\n- `Expected a ResourceEffectUpdate to be pushed together with ResourceEffectIdentity. This is a bug in React.`,\n- );\n- }\n- isUpdateDepsSame = areHookInputsEqual(nextUpdateDeps, prevUpdateDeps);\n- }\n- }\n-\n- if (!(isCreateDepsSame && isUpdateDepsSame)) {\n- currentlyRenderingFiber.flags |= fiberFlags;\n- }\n-\n- hook.memoizedState = pushResourceEffect(\n- isCreateDepsSame ? hookFlags : HookHasEffect | hookFlags,\n- isUpdateDepsSame ? hookFlags : HookHasEffect | hookFlags,\n- inst,\n- create,\n- nextCreateDeps,\n- update,\n- nextUpdateDeps,\n- );\n+function updateEffect(\n+ create: () => (() => void) | void,\n+ deps: Array | void | null,\n+): void {\n+ updateEffectImpl(PassiveEffect, HookPassive, create, deps);\n }\n \n function useEffectEventImpl) => Return>(\n@@ -4339,30 +4067,13 @@ if (__DEV__) {\n return readContext(context);\n },\n useEffect(\n- create: (() => (() => void) | void) | (() => {...} | void | null),\n- createDeps: Array | void | null,\n- update?: ((resource: {...} | void | null) => void) | void,\n- updateDeps?: Array | void | null,\n- destroy?: ((resource: {...} | void | null) => void) | void,\n+ create: () => (() => void) | void,\n+ deps: Array | void | null,\n ): void {\n currentHookNameInDev = 'useEffect';\n mountHookTypesDev();\n- if (\n- enableUseEffectCRUDOverload &&\n- (typeof update === 'function' || typeof destroy === 'function')\n- ) {\n- checkDepsAreNonEmptyArrayDev(updateDeps);\n- return mountResourceEffect(\n- create,\n- createDeps,\n- update,\n- updateDeps,\n- destroy,\n- );\n- } else {\n- checkDepsAreArrayDev(createDeps);\n- return mountEffect(create, createDeps);\n- }\n+ checkDepsAreArrayDev(deps);\n+ return mountEffect(create, deps);\n },\n useImperativeHandle(\n ref: {current: T | null} | ((inst: T | null) => mixed) | null | void,\n@@ -4540,28 +4251,12 @@ if (__DEV__) {\n return readContext(context);\n },\n useEffect(\n- create: (() => (() => void) | void) | (() => {...} | void | null),\n- createDeps: Array | void | null,\n- update?: ((resource: {...} | void | null) => void) | void,\n- updateDeps?: Array | void | null,\n- destroy?: ((resource: {...} | void | null) => void) | void,\n+ create: () => (() => void) | void,\n+ deps: Array | void | null,\n ): void {\n currentHookNameInDev = 'useEffect';\n updateHookTypesDev();\n- if (\n- enableUseEffectCRUDOverload &&\n- (typeof update === 'function' || typeof destroy === 'function')\n- ) {\n- return mountResourceEffect(\n- create,\n- createDeps,\n- update,\n- updateDeps,\n- destroy,\n- );\n- } else {\n- return mountEffect(create, createDeps);\n- }\n+ return mountEffect(create, deps);\n },\n useImperativeHandle(\n ref: {current: T | null} | ((inst: T | null) => mixed) | null | void,\n@@ -4735,28 +4430,12 @@ if (__DEV__) {\n return readContext(context);\n },\n useEffect(\n- create: (() => (() => void) | void) | (() => {...} | void | null),\n- createDeps: Array | void | null,\n- update?: ((resource: {...} | void | null) => void) | void,\n- updateDeps?: Array | void | null,\n- destroy?: ((resource: {...} | void | null) => void) | void,\n+ create: () => (() => void) | void,\n+ deps: Array | void | null,\n ): void {\n currentHookNameInDev = 'useEffect';\n updateHookTypesDev();\n- if (\n- enableUseEffectCRUDOverload &&\n- (typeof update === 'function' || typeof destroy === 'function')\n- ) {\n- return updateResourceEffect(\n- create,\n- createDeps,\n- update,\n- updateDeps,\n- destroy,\n- );\n- } else {\n- return updateEffect(create, createDeps);\n- }\n+ return updateEffect(create, deps);\n },\n useImperativeHandle(\n ref: {current: T | null} | ((inst: T | null) => mixed) | null | void,\n@@ -4930,28 +4609,12 @@ if (__DEV__) {\n return readContext(context);\n },\n useEffect(\n- create: (() => (() => void) | void) | (() => {...} | void | null),\n- createDeps: Array | void | null,\n- update?: ((resource: {...} | void | null) => void) | void,\n- updateDeps?: Array | void | null,\n- destroy?: ((resource: {...} | void | null) => void) | void,\n+ create: () => (() => void) | void,\n+ deps: Array | void | null,\n ): void {\n currentHookNameInDev = 'useEffect';\n updateHookTypesDev();\n- if (\n- enableUseEffectCRUDOverload &&\n- (typeof update === 'function' || typeof destroy === 'function')\n- ) {\n- return updateResourceEffect(\n- create,\n- createDeps,\n- update,\n- updateDeps,\n- destroy,\n- );\n- } else {\n- return updateEffect(create, createDeps);\n- }\n+ return updateEffect(create, deps);\n },\n useImperativeHandle(\n ref: {current: T | null} | ((inst: T | null) => mixed) | null | void,\n@@ -5131,29 +4794,13 @@ if (__DEV__) {\n return readContext(context);\n },\n useEffect(\n- create: (() => (() => void) | void) | (() => {...} | void | null),\n- createDeps: Array | void | null,\n- update?: ((resource: {...} | void | null) => void) | void,\n- updateDeps?: Array | void | null,\n- destroy?: ((resource: {...} | void | null) => void) | void,\n+ create: () => (() => void) | void,\n+ deps: Array | void | null,\n ): void {\n currentHookNameInDev = 'useEffect';\n warnInvalidHookAccess();\n mountHookTypesDev();\n- if (\n- enableUseEffectCRUDOverload &&\n- (typeof update === 'function' || typeof destroy === 'function')\n- ) {\n- return mountResourceEffect(\n- create,\n- createDeps,\n- update,\n- updateDeps,\n- destroy,\n- );\n- } else {\n- return mountEffect(create, createDeps);\n- }\n+ return mountEffect(create, deps);\n },\n useImperativeHandle(\n ref: {current: T | null} | ((inst: T | null) => mixed) | null | void,\n@@ -5352,29 +4999,13 @@ if (__DEV__) {\n return readContext(context);\n },\n useEffect(\n- create: (() => (() => void) | void) | (() => {...} | void | null),\n- createDeps: Array | void | null,\n- update?: ((resource: {...} | void | null) => void) | void,\n- updateDeps?: Array | void | null,\n- destroy?: ((resource: {...} | void | null) => void) | void,\n+ create: () => (() => void) | void,\n+ deps: Array | void | null,\n ): void {\n currentHookNameInDev = 'useEffect';\n warnInvalidHookAccess();\n updateHookTypesDev();\n- if (\n- enableUseEffectCRUDOverload &&\n- (typeof update === 'function' || typeof destroy === 'function')\n- ) {\n- return updateResourceEffect(\n- create,\n- createDeps,\n- update,\n- updateDeps,\n- destroy,\n- );\n- } else {\n- return updateEffect(create, createDeps);\n- }\n+ return updateEffect(create, deps);\n },\n useImperativeHandle(\n ref: {current: T | null} | ((inst: T | null) => mixed) | null | void,\n@@ -5573,29 +5204,13 @@ if (__DEV__) {\n return readContext(context);\n },\n useEffect(\n- create: (() => (() => void) | void) | (() => {...} | void | null),\n- createDeps: Array | void | null,\n- update?: ((resource: {...} | void | null) => void) | void,\n- updateDeps?: Array | void | null,\n- destroy?: ((resource: {...} | void | null) => void) | void,\n+ create: () => (() => void) | void,\n+ deps: Array | void | null,\n ): void {\n currentHookNameInDev = 'useEffect';\n warnInvalidHookAccess();\n updateHookTypesDev();\n- if (\n- enableUseEffectCRUDOverload &&\n- (typeof update === 'function' || typeof destroy === 'function')\n- ) {\n- return updateResourceEffect(\n- create,\n- createDeps,\n- update,\n- updateDeps,\n- destroy,\n- );\n- } else {\n- return updateEffect(create, createDeps);\n- }\n+ return updateEffect(create, deps);\n },\n useImperativeHandle(\n ref: {current: T | null} | ((inst: T | null) => mixed) | null | void,\ndiff --git a\/packages\/react-reconciler\/src\/ReactInternalTypes.js b\/packages\/react-reconciler\/src\/ReactInternalTypes.js\nindex 1452746089..4de46988db 100644\n--- a\/packages\/react-reconciler\/src\/ReactInternalTypes.js\n+++ b\/packages\/react-reconciler\/src\/ReactInternalTypes.js\n@@ -399,11 +399,8 @@ export type Dispatcher = {\n useContext(context: ReactContext): T,\n useRef(initialValue: T): {current: T},\n useEffect(\n- create: (() => (() => void) | void) | (() => {...} | void | null),\n- createDeps: Array | void | null,\n- update?: ((resource: {...} | void | null) => void) | void,\n- updateDeps?: Array | void | null,\n- destroy?: ((resource: {...} | void | null) => void) | void,\n+ create: () => (() => void) | void,\n+ deps: Array | void | null,\n ): void,\n \/\/ TODO: Non-nullable once `enableUseEffectEventHook` is on everywhere.\n useEffectEvent?: ) => mixed>(callback: F) => F,\ndiff --git a\/packages\/react-reconciler\/src\/__tests__\/ReactHooksWithNoopRenderer-test.js b\/packages\/react-reconciler\/src\/__tests__\/ReactHooksWithNoopRenderer-test.js\nindex 47fd534e68..f72b738cf6 100644\n--- a\/packages\/react-reconciler\/src\/__tests__\/ReactHooksWithNoopRenderer-test.js\n+++ b\/packages\/react-reconciler\/src\/__tests__\/ReactHooksWithNoopRenderer-test.js\n@@ -3309,760 +3309,6 @@ describe('ReactHooksWithNoopRenderer', () => {\n });\n });\n \n- \/\/ @gate enableUseEffectCRUDOverload\n- describe('useEffect CRUD overload', () => {\n- class Resource {\n- isDeleted: false;\n- id: string;\n- opts: mixed;\n- constructor(id, opts) {\n- this.id = id;\n- this.opts = opts;\n- }\n- update(opts) {\n- if (this.isDeleted) {\n- console.error('Cannot update deleted resource');\n- return;\n- }\n- this.opts = opts;\n- }\n- destroy() {\n- this.isDeleted = true;\n- }\n- }\n-\n- \/\/ @gate !enableUseEffectCRUDOverload\n- it('is null when flag is disabled', async () => {\n- function App({id}) {\n- useEffect(\n- () => {\n- Scheduler.log(`create(${id})`);\n- return {};\n- },\n- [id],\n- () => {\n- Scheduler.log('update');\n- },\n- [],\n- );\n- return null;\n- }\n-\n- await expect(async () => {\n- await act(() => {\n- ReactNoop.render();\n- });\n- }).rejects.toThrow(\n- 'useEffect CRUD overload is not enabled in this build of React.',\n- );\n- });\n-\n- \/\/ @gate enableUseEffectCRUDOverload\n- it('validates non-empty update deps', async () => {\n- function App({id}) {\n- useEffect(\n- () => {\n- Scheduler.log(`create(${id})`);\n- return {};\n- },\n- [id],\n- () => {\n- Scheduler.log('update');\n- },\n- [],\n- );\n- return null;\n- }\n-\n- await act(() => {\n- ReactNoop.render();\n- });\n- assertConsoleErrorDev([\n- 'useEffect received a dependency array with no dependencies. ' +\n- 'When specified, the dependency array must have at least one dependency.\\n' +\n- ' in App (at **)',\n- ]);\n- });\n-\n- \/\/ @gate enableUseEffectCRUDOverload\n- it('simple mount and update', async () => {\n- function App({id, username}) {\n- const opts = useMemo(() => {\n- return {username};\n- }, [username]);\n- useEffect(\n- () => {\n- const resource = new Resource(id, opts);\n- Scheduler.log(`create(${resource.id}, ${resource.opts.username})`);\n- return resource;\n- },\n- [id],\n- resource => {\n- resource.update(opts);\n- Scheduler.log(`update(${resource.id}, ${resource.opts.username})`);\n- },\n- [opts],\n- resource => {\n- resource.destroy();\n- Scheduler.log(`destroy(${resource.id}, ${resource.opts.username})`);\n- },\n- );\n- return null;\n- }\n-\n- await act(() => {\n- ReactNoop.render();\n- });\n- assertLog(['create(1, Jack)']);\n-\n- await act(() => {\n- ReactNoop.render();\n- });\n- assertLog(['update(1, Lauren)']);\n-\n- await act(() => {\n- ReactNoop.render();\n- });\n- assertLog([]);\n-\n- await act(() => {\n- ReactNoop.render();\n- });\n- assertLog(['update(1, Jordan)']);\n-\n- await act(() => {\n- ReactNoop.render();\n- });\n- assertLog(['destroy(1, Jordan)', 'create(2, Jack)']);\n-\n- await act(() => {\n- ReactNoop.render(null);\n- });\n- assertLog(['destroy(2, Jack)']);\n- });\n-\n- \/\/ @gate enableUseEffectCRUDOverload\n- it('simple mount with no update', async () => {\n- function App({id, username}) {\n- const opts = useMemo(() => {\n- return {username};\n- }, [username]);\n- useEffect(\n- () => {\n- const resource = new Resource(id, opts);\n- Scheduler.log(`create(${resource.id}, ${resource.opts.username})`);\n- return resource;\n- },\n- [id],\n- resource => {\n- resource.update(opts);\n- Scheduler.log(`update(${resource.id}, ${resource.opts.username})`);\n- },\n- [opts],\n- resource => {\n- resource.destroy();\n- Scheduler.log(`destroy(${resource.id}, ${resource.opts.username})`);\n- },\n- );\n- return null;\n- }\n-\n- await act(() => {\n- ReactNoop.render();\n- });\n- assertLog(['create(1, Jack)']);\n-\n- await act(() => {\n- ReactNoop.render(null);\n- });\n- assertLog(['destroy(1, Jack)']);\n- });\n-\n- \/\/ @gate enableUseEffectCRUDOverload\n- it('calls update on every render if no deps are specified', async () => {\n- function App({id, username}) {\n- const opts = useMemo(() => {\n- return {username};\n- }, [username]);\n- useEffect(\n- () => {\n- const resource = new Resource(id, opts);\n- Scheduler.log(`create(${resource.id}, ${resource.opts.username})`);\n- return resource;\n- },\n- [id],\n- resource => {\n- resource.update(opts);\n- Scheduler.log(`update(${resource.id}, ${resource.opts.username})`);\n- },\n- );\n- return null;\n- }\n-\n- await act(() => {\n- ReactNoop.render();\n- });\n- assertLog(['create(1, Jack)']);\n-\n- await act(() => {\n- ReactNoop.render();\n- });\n- assertLog(['update(1, Jack)']);\n-\n- await act(() => {\n- ReactNoop.render();\n- });\n- assertLog(['create(2, Jack)', 'update(2, Jack)']);\n-\n- await act(() => {\n- ReactNoop.render();\n- });\n-\n- assertLog(['update(2, Lauren)']);\n- });\n-\n- \/\/ @gate enableUseEffectCRUDOverload\n- it('does not unmount previous useEffect between updates', async () => {\n- function App({id}) {\n- useEffect(\n- () => {\n- const resource = new Resource(id);\n- Scheduler.log(`create(${resource.id})`);\n- return resource;\n- },\n- [],\n- resource => {\n- Scheduler.log(`update(${resource.id})`);\n- },\n- undefined,\n- resource => {\n- Scheduler.log(`destroy(${resource.id})`);\n- resource.destroy();\n- },\n- );\n- return ;\n- }\n-\n- await act(async () => {\n- ReactNoop.render(, () => Scheduler.log('Sync effect'));\n- await waitFor(['Id: 0', 'Sync effect']);\n- expect(ReactNoop).toMatchRenderedOutput();\n- });\n-\n- assertLog(['create(0)']);\n-\n- await act(async () => {\n- ReactNoop.render(, () => Scheduler.log('Sync effect'));\n- await waitFor(['Id: 1', 'Sync effect']);\n- expect(ReactNoop).toMatchRenderedOutput();\n- });\n-\n- assertLog(['update(0)']);\n- });\n-\n- \/\/ @gate enableUseEffectCRUDOverload\n- it('unmounts only on deletion', async () => {\n- function App({id}) {\n- useEffect(\n- () => {\n- const resource = new Resource(id);\n- Scheduler.log(`create(${resource.id})`);\n- return resource;\n- },\n- undefined,\n- resource => {\n- Scheduler.log(`update(${resource.id})`);\n- },\n- undefined,\n- resource => {\n- Scheduler.log(`destroy(${resource.id})`);\n- resource.destroy();\n- },\n- );\n- return ;\n- }\n- await act(async () => {\n- ReactNoop.render(, () => Scheduler.log('Sync effect'));\n- await waitFor(['Id: 0', 'Sync effect']);\n- expect(ReactNoop).toMatchRenderedOutput();\n- });\n-\n- assertLog(['create(0)']);\n-\n- ReactNoop.render(null);\n- await waitForAll(['destroy(0)']);\n- expect(ReactNoop).toMatchRenderedOutput(null);\n- });\n-\n- \/\/ @gate enableUseEffectCRUDOverload\n- it('unmounts on deletion', async () => {\n- function Wrapper(props) {\n- return ;\n- }\n- function App({id, username}) {\n- const opts = useMemo(() => {\n- return {username};\n- }, [username]);\n- useEffect(\n- () => {\n- const resource = new Resource(id, opts);\n- Scheduler.log(`create(${resource.id}, ${resource.opts.username})`);\n- return resource;\n- },\n- [id],\n- resource => {\n- resource.update(opts);\n- Scheduler.log(`update(${resource.id}, ${resource.opts.username})`);\n- },\n- [opts],\n- resource => {\n- resource.destroy();\n- Scheduler.log(`destroy(${resource.id}, ${resource.opts.username})`);\n- },\n- );\n- return ;\n- }\n-\n- await act(async () => {\n- ReactNoop.render(, () =>\n- Scheduler.log('Sync effect'),\n- );\n- await waitFor(['Id: 0', 'Sync effect']);\n- expect(ReactNoop).toMatchRenderedOutput();\n- });\n-\n- assertLog(['create(0, Sathya)']);\n-\n- await act(async () => {\n- ReactNoop.render(, () =>\n- Scheduler.log('Sync effect'),\n- );\n- await waitFor(['Id: 0', 'Sync effect']);\n- expect(ReactNoop).toMatchRenderedOutput();\n- });\n-\n- assertLog(['update(0, Lauren)']);\n-\n- ReactNoop.render(null);\n- await waitForAll(['destroy(0, Lauren)']);\n- expect(ReactNoop).toMatchRenderedOutput(null);\n- });\n-\n- \/\/ @gate enableUseEffectCRUDOverload\n- it('handles errors in create on mount', async () => {\n- function App({id}) {\n- useEffect(\n- () => {\n- Scheduler.log(`Mount A [${id}]`);\n- return {};\n- },\n- undefined,\n- undefined,\n- undefined,\n- resource => {\n- Scheduler.log(`Unmount A [${id}]`);\n- },\n- );\n- useEffect(\n- () => {\n- Scheduler.log('Oops!');\n- throw new Error('Oops!');\n- \/\/ eslint-disable-next-line no-unreachable\n- Scheduler.log(`Mount B [${id}]`);\n- return {};\n- },\n- undefined,\n- undefined,\n- undefined,\n- resource => {\n- Scheduler.log(`Unmount B [${id}]`);\n- },\n- );\n- return ;\n- }\n- await expect(async () => {\n- await act(async () => {\n- ReactNoop.render(, () => Scheduler.log('Sync effect'));\n- await waitFor(['Id: 0', 'Sync effect']);\n- expect(ReactNoop).toMatchRenderedOutput();\n- });\n- }).rejects.toThrow('Oops');\n-\n- assertLog([\n- 'Mount A [0]',\n- 'Oops!',\n- \/\/ Clean up effect A. There's no effect B to clean-up, because it\n- \/\/ never mounted.\n- 'Unmount A [0]',\n- ]);\n- expect(ReactNoop).toMatchRenderedOutput(null);\n- });\n-\n- \/\/ @gate enableUseEffectCRUDOverload\n- it('handles errors in create on update', async () => {\n- function App({id}) {\n- useEffect(\n- () => {\n- Scheduler.log(`Mount A [${id}]`);\n- return {};\n- },\n- [],\n- () => {\n- if (id === 1) {\n- Scheduler.log('Oops!');\n- throw new Error('Oops error!');\n- }\n- Scheduler.log(`Update A [${id}]`);\n- },\n- [id],\n- () => {\n- Scheduler.log(`Unmount A [${id}]`);\n- },\n- );\n- return ;\n- }\n- await act(async () => {\n- ReactNoop.render(, () => Scheduler.log('Sync effect'));\n- await waitFor(['Id: 0', 'Sync effect']);\n- expect(ReactNoop).toMatchRenderedOutput();\n- ReactNoop.flushPassiveEffects();\n- assertLog(['Mount A [0]']);\n- });\n-\n- await expect(async () => {\n- await act(async () => {\n- \/\/ This update will trigger an error\n- ReactNoop.render(, () => Scheduler.log('Sync effect'));\n- await waitFor(['Id: 1', 'Sync effect']);\n- expect(ReactNoop).toMatchRenderedOutput();\n- ReactNoop.flushPassiveEffects();\n- assertLog(['Oops!', 'Unmount A [1]']);\n- expect(ReactNoop).toMatchRenderedOutput(null);\n- });\n- }).rejects.toThrow('Oops error!');\n- });\n-\n- \/\/ @gate enableUseEffectCRUDOverload\n- it('handles errors in destroy on update', async () => {\n- function App({id, username}) {\n- const opts = useMemo(() => {\n- return {username};\n- }, [username]);\n- useEffect(\n- () => {\n- const resource = new Resource(id, opts);\n- Scheduler.log(`Mount A [${id}, ${resource.opts.username}]`);\n- return resource;\n- },\n- [id],\n- resource => {\n- resource.update(opts);\n- Scheduler.log(`Update A [${id}, ${resource.opts.username}]`);\n- },\n- [opts],\n- resource => {\n- Scheduler.log(`Oops, ${resource.opts.username}!`);\n- if (id === 1) {\n- throw new Error(`Oops ${resource.opts.username} error!`);\n- }\n- Scheduler.log(`Unmount A [${id}, ${resource.opts.username}]`);\n- },\n- );\n- return ;\n- }\n- await act(async () => {\n- ReactNoop.render(, () =>\n- Scheduler.log('Sync effect'),\n- );\n- await waitFor(['Id: 0', 'Sync effect']);\n- expect(ReactNoop).toMatchRenderedOutput();\n- ReactNoop.flushPassiveEffects();\n- assertLog(['Mount A [0, Lauren]']);\n- });\n-\n- await expect(async () => {\n- await act(async () => {\n- \/\/ This update will trigger an error during passive effect unmount\n- ReactNoop.render(, () =>\n- Scheduler.log('Sync effect'),\n- );\n- await waitFor(['Id: 1', 'Sync effect']);\n- expect(ReactNoop).toMatchRenderedOutput();\n- ReactNoop.flushPassiveEffects();\n- assertLog(['Oops, Lauren!', 'Mount A [1, Sathya]', 'Oops, Sathya!']);\n- });\n- \/\/ TODO(lauren) more explicit assertions. this is weird because we\n- \/\/ destroy both the first and second resource\n- }).rejects.toThrow();\n-\n- expect(ReactNoop).toMatchRenderedOutput(null);\n- });\n-\n- \/\/ @gate enableUseEffectCRUDOverload && enableActivity\n- it('composes with activity', async () => {\n- function App({id, username}) {\n- const opts = useMemo(() => {\n- return {username};\n- }, [username]);\n- useEffect(\n- () => {\n- const resource = new Resource(id, opts);\n- Scheduler.log(`create(${resource.id}, ${resource.opts.username})`);\n- return resource;\n- },\n- [id],\n- resource => {\n- resource.update(opts);\n- Scheduler.log(`update(${resource.id}, ${resource.opts.username})`);\n- },\n- [opts],\n- resource => {\n- resource.destroy();\n- Scheduler.log(`destroy(${resource.id}, ${resource.opts.username})`);\n- },\n- );\n- return null;\n- }\n-\n- const root = ReactNoop.createRoot();\n- await act(() => {\n- root.render(\n- \n- \n- <\/Activity>,\n- );\n- });\n- assertLog([]);\n-\n- await act(() => {\n- root.render(\n- \n- \n- <\/Activity>,\n- );\n- });\n- assertLog([]);\n-\n- await act(() => {\n- root.render(\n- \n- \n- <\/Activity>,\n- );\n- });\n- assertLog(['create(0, Rick)']);\n-\n- await act(() => {\n- root.render(\n- \n- \n- <\/Activity>,\n- );\n- });\n- assertLog(['update(0, Lauren)']);\n-\n- await act(() => {\n- root.render(\n- \n- \n- <\/Activity>,\n- );\n- });\n- assertLog(['destroy(0, Lauren)']);\n- });\n-\n- \/\/ @gate enableUseEffectCRUDOverload\n- it('composes with suspense', async () => {\n- function TextBox({text}) {\n- return ;\n- }\n- let setUsername_;\n- function App({id}) {\n- const [username, setUsername] = useState('Mofei');\n- setUsername_ = setUsername;\n- const opts = useMemo(() => {\n- return {username};\n- }, [username]);\n- useEffect(\n- () => {\n- const resource = new Resource(id, opts);\n- Scheduler.log(`create(${resource.id}, ${resource.opts.username})`);\n- return resource;\n- },\n- [id],\n- resource => {\n- resource.update(opts);\n- Scheduler.log(`update(${resource.id}, ${resource.opts.username})`);\n- },\n- [opts],\n- resource => {\n- resource.destroy();\n- Scheduler.log(`destroy(${resource.id}, ${resource.opts.username})`);\n- },\n- );\n- return (\n- <>\n- \n- }>\n- \n- <\/Suspense>\n- <\/>\n- );\n- }\n-\n- await act(async () => {\n- ReactNoop.render();\n- await waitFor([\n- 'Sync: Mofei',\n- 'Suspend! [Mofei]',\n- 'Loading',\n- 'create(0, Mofei)',\n- ]);\n- expect(ReactNoop).toMatchRenderedOutput(\n- <>\n- \n- \n- <\/>,\n- );\n- ReactNoop.flushPassiveEffects();\n- assertLog([]);\n-\n- Scheduler.unstable_advanceTime(10);\n- await advanceTimers(10);\n- assertLog(['Promise resolved [Mofei]']);\n- });\n- assertLog(['Mofei']);\n- expect(ReactNoop).toMatchRenderedOutput(\n- <>\n- \n- \n- <\/>,\n- );\n-\n- await act(async () => {\n- ReactNoop.render(, () => Scheduler.log('Sync effect'));\n- await waitFor([\n- 'Sync: Mofei',\n- 'Mofei',\n- 'Sync effect',\n- 'destroy(0, Mofei)',\n- 'create(1, Mofei)',\n- ]);\n- expect(ReactNoop).toMatchRenderedOutput(\n- <>\n- \n- \n- <\/>,\n- );\n- ReactNoop.flushPassiveEffects();\n- assertLog([]);\n- });\n-\n- await act(async () => {\n- setUsername_('Lauren');\n- await waitFor([\n- 'Sync: Lauren',\n- 'Suspend! [Lauren]',\n- 'Loading',\n- 'update(1, Lauren)',\n- ]);\n- expect(ReactNoop).toMatchRenderedOutput(\n- <>\n- \n-

dillon1000/react

Files changed