{"body":"","commit":{"authorEmail":"bvaughn@fb.com","authoredAt":"2020-04-06T09:47:15-07:00","revision":"3498f1366987977659b37e099aef79f05170fed0","shortRevision":"3498f13669","authorName":"Brian Vaughn","subject":"Profiler tooltip shows self duration (#18510)"},"parents":["c781156163f014d15eeb464296a17aba4406d2ec"],"files":[{"path":"packages\/react-devtools-shared\/src\/devtools\/views\/Profiler\/HoveredFiberInfo.css","status":"M"},{"path":"packages\/react-devtools-shared\/src\/devtools\/views\/Profiler\/HoveredFiberInfo.js","status":"M"}],"patch":"diff --git a\/packages\/react-devtools-shared\/src\/devtools\/views\/Profiler\/HoveredFiberInfo.css b\/packages\/react-devtools-shared\/src\/devtools\/views\/Profiler\/HoveredFiberInfo.css\nindex d50e36935f..3255b321d3 100644\n--- a\/packages\/react-devtools-shared\/src\/devtools\/views\/Profiler\/HoveredFiberInfo.css\n+++ b\/packages\/react-devtools-shared\/src\/devtools\/views\/Profiler\/HoveredFiberInfo.css\n@@ -27,7 +27,7 @@\n }\n \n .CurrentCommit {\n- margin-top: 0.25rem;\n+ margin: 0.25rem 0;\n display: block;\n width: 100%;\n text-align: left;\ndiff --git a\/packages\/react-devtools-shared\/src\/devtools\/views\/Profiler\/HoveredFiberInfo.js b\/packages\/react-devtools-shared\/src\/devtools\/views\/Profiler\/HoveredFiberInfo.js\nindex fa07d02b1d..78f6c5c6ae 100644\n--- a\/packages\/react-devtools-shared\/src\/devtools\/views\/Profiler\/HoveredFiberInfo.js\n+++ b\/packages\/react-devtools-shared\/src\/devtools\/views\/Profiler\/HoveredFiberInfo.js\n@@ -10,7 +10,7 @@\n import * as React from 'react';\n import {Fragment, useContext} from 'react';\n import {ProfilerContext} from '.\/ProfilerContext';\n-import {formatDuration, formatTime} from '.\/utils';\n+import {formatDuration} from '.\/utils';\n import WhatChanged from '.\/WhatChanged';\n import {StoreContext} from '..\/context';\n \n@@ -44,18 +44,17 @@ export default function HoveredFiberInfo({fiberData}: Props) {\n for (i = 0; i < commitIndices.length; i++) {\n const commitIndex = commitIndices[i];\n if (selectedCommitIndex === commitIndex) {\n- const {duration, timestamp} = profilerStore.getCommitData(\n- ((rootID: any): number),\n- commitIndex,\n- );\n+ const {\n+ fiberActualDurations,\n+ fiberSelfDurations,\n+ } = profilerStore.getCommitData(((rootID: any): number), commitIndex);\n+ const actualDuration = fiberActualDurations.get(id) || 0;\n+ const selfDuration = fiberSelfDurations.get(id) || 0;\n \n renderDurationInfo = (\n- \n- Rendered at:<\/label>\n-

\n- {formatTime(timestamp)}s for {formatDuration(duration)}ms\n- <\/div>\n- <\/Fragment>\n+

\n+ {formatDuration(selfDuration)}ms of {formatDuration(actualDuration)}ms\n+ <\/div>\n );\n \n break;\n@@ -68,10 +67,10 @@ export default function HoveredFiberInfo({fiberData}: Props) {\n

{name}<\/div>\n <\/div>\n

\n- \n {renderDurationInfo || (\n

Did not render during this profiling session.<\/div>\n )}\n+ \n <\/div>\n <\/Fragment>\n );\n"}

dillon1000/react

Files changed