dillon1000/react

Commit

Allow extraneous effect dependencies (#14967)

This makes cases like

  useEffect(() => {
    window.scrollTo(0, 0);
  }, [activeTab]);

not warn.

However, it still warns for unused useCallback/useMemo deps.
Browse files
Dan Abramov authored 3ada82b7416c51290535a054f345b99378c38dcb Parent 00748c5
Changed paths2 files
First-parent comparison
M packages/eslint-plugin-react-hooks/__tests__/ESLintRuleExhaustiveDeps-test.js ModifiedM packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…