dillon1000/react
Commit
Browse files Fix download-build script (#25493)
The download-build script works by scraping the CircleCI job number from the GitHub status API. Yes, I know this is super hacky but last I checked this was the least bad of not a lot of options. Because the response is paginated, sometimes the status for the build job exceeds the page size. This increases the page size to 100 so this is less likely to happen. It'd be great to find a better way to download the artifacts. I don't love how brittle this solution is. I think switching to the GitHub Checks API might be worth trying, but last I looked into it, it has other flaws.
Changed paths1 file
First-parent comparisonscripts/release/shared-commands/get-build-id-for-commit.js ModifiedPatch
Files changed
Rendering syntax-highlighted changes…