{"commit":{"authorEmail":"rapha850@gmail.com","subject":"react: convert var to let\/const (#11715)","shortRevision":"3c977dea6b","authorName":"Raphael Amorim","authoredAt":"2017-11-30T10:08:58-02:00","revision":"3c977dea6b96f6a9bb39f09886848da870748441"},"patch":"diff --git a\/packages\/react\/index.js b\/packages\/react\/index.js\nindex 5793d0669e..2591bb0d23 100644\n--- a\/packages\/react\/index.js\n+++ b\/packages\/react\/index.js\n@@ -9,7 +9,7 @@\n \n 'use strict';\n \n-var React = require('.\/src\/React');\n+const React = require('.\/src\/React');\n \n \/\/ TODO: decide on the top-level export form.\n \/\/ This is hacky but makes it work with both Rollup and Jest.\ndiff --git a\/packages\/react\/src\/React.js b\/packages\/react\/src\/React.js\nindex 6f345c8862..61a59f83c5 100644\n--- a\/packages\/react\/src\/React.js\n+++ b\/packages\/react\/src\/React.js\n@@ -25,7 +25,7 @@ import {\n } from '.\/ReactElementValidator';\n import ReactDebugCurrentFrame from '.\/ReactDebugCurrentFrame';\n \n-var React = {\n+const React = {\n Children: {\n map,\n forEach,\ndiff --git a\/packages\/react\/src\/ReactBaseClasses.js b\/packages\/react\/src\/ReactBaseClasses.js\nindex 85b8ab863c..13d4ab999b 100644\n--- a\/packages\/react\/src\/ReactBaseClasses.js\n+++ b\/packages\/react\/src\/ReactBaseClasses.js\n@@ -85,7 +85,7 @@ Component.prototype.forceUpdate = function(callback) {\n * modern base class. Instead, we define a getter that warns if it's accessed.\n *\/\n if (__DEV__) {\n- var deprecatedAPIs = {\n+ const deprecatedAPIs = {\n isMounted: [\n 'isMounted',\n 'Instead, make sure to clean up subscriptions and pending requests in ' +\n@@ -97,7 +97,7 @@ if (__DEV__) {\n 'https:\/\/github.com\/facebook\/react\/issues\/3236).',\n ],\n };\n- var defineDeprecationWarning = function(methodName, info) {\n+ const defineDeprecationWarning = function(methodName, info) {\n Object.defineProperty(Component.prototype, methodName, {\n get: function() {\n lowPriorityWarning(\n@@ -110,7 +110,7 @@ if (__DEV__) {\n },\n });\n };\n- for (var fnName in deprecatedAPIs) {\n+ for (const fnName in deprecatedAPIs) {\n if (deprecatedAPIs.hasOwnProperty(fnName)) {\n defineDeprecationWarning(fnName, deprecatedAPIs[fnName]);\n }\n@@ -132,7 +132,7 @@ function PureComponent(props, context, updater) {\n \n function ComponentDummy() {}\n ComponentDummy.prototype = Component.prototype;\n-var pureComponentPrototype = (PureComponent.prototype = new ComponentDummy());\n+const pureComponentPrototype = (PureComponent.prototype = new ComponentDummy());\n pureComponentPrototype.constructor = PureComponent;\n \/\/ Avoid an extra prototype jump for these methods.\n Object.assign(pureComponentPrototype, Component.prototype);\n@@ -148,7 +148,7 @@ function AsyncComponent(props, context, updater) {\n this.updater = updater || ReactNoopUpdateQueue;\n }\n \n-var asyncComponentPrototype = (AsyncComponent.prototype = new ComponentDummy());\n+const asyncComponentPrototype = (AsyncComponent.prototype = new ComponentDummy());\n asyncComponentPrototype.constructor = AsyncComponent;\n \/\/ Avoid an extra prototype jump for these methods.\n Object.assign(asyncComponentPrototype, Component.prototype);\ndiff --git a\/packages\/react\/src\/ReactChildren.js b\/packages\/react\/src\/ReactChildren.js\nindex 26bd88f8c6..efb9a2a84b 100644\n--- a\/packages\/react\/src\/ReactChildren.js\n+++ b\/packages\/react\/src\/ReactChildren.js\n@@ -19,8 +19,8 @@ import {\n import {isValidElement, cloneAndReplaceKey} from '.\/ReactElement';\n import ReactDebugCurrentFrame from '.\/ReactDebugCurrentFrame';\n \n-var SEPARATOR = '.';\n-var SUBSEPARATOR = ':';\n+const SEPARATOR = '.';\n+const SUBSEPARATOR = ':';\n \n \/**\n * Escape and wrap key so it is safe to use as a reactid\n@@ -29,12 +29,12 @@ var SUBSEPARATOR = ':';\n * @return {string} the escaped key.\n *\/\n function escape(key) {\n- var escapeRegex = \/[=:]\/g;\n- var escaperLookup = {\n+ const escapeRegex = \/[=:]\/g;\n+ const escaperLookup = {\n '=': '=0',\n ':': '=2',\n };\n- var escapedString = ('' + key).replace(escapeRegex, function(match) {\n+ const escapedString = ('' + key).replace(escapeRegex, function(match) {\n return escaperLookup[match];\n });\n \n@@ -46,15 +46,15 @@ function escape(key) {\n * pattern.\n *\/\n \n-var didWarnAboutMaps = false;\n+let didWarnAboutMaps = false;\n \n-var userProvidedKeyEscapeRegex = \/\\\/+\/g;\n+const userProvidedKeyEscapeRegex = \/\\\/+\/g;\n function escapeUserProvidedKey(text) {\n return ('' + text).replace(userProvidedKeyEscapeRegex, '$&\/');\n }\n \n-var POOL_SIZE = 10;\n-var traverseContextPool = [];\n+const POOL_SIZE = 10;\n+const traverseContextPool = [];\n function getPooledTraverseContext(\n mapResult,\n keyPrefix,\n@@ -62,7 +62,7 @@ function getPooledTraverseContext(\n mapContext,\n ) {\n if (traverseContextPool.length) {\n- var traverseContext = traverseContextPool.pop();\n+ const traverseContext = traverseContextPool.pop();\n traverseContext.result = mapResult;\n traverseContext.keyPrefix = keyPrefix;\n traverseContext.func = mapFunction;\n@@ -105,7 +105,7 @@ function traverseAllChildrenImpl(\n callback,\n traverseContext,\n ) {\n- var type = typeof children;\n+ const type = typeof children;\n \n if (type === 'undefined' || type === 'boolean') {\n \/\/ All of the above are perceived as null.\n@@ -144,13 +144,14 @@ function traverseAllChildrenImpl(\n return 1;\n }\n \n- var child;\n- var nextName;\n- var subtreeCount = 0; \/\/ Count of children found in the current subtree.\n- var nextNamePrefix = nameSoFar === '' ? SEPARATOR : nameSoFar + SUBSEPARATOR;\n+ let child;\n+ let nextName;\n+ let subtreeCount = 0; \/\/ Count of children found in the current subtree.\n+ const nextNamePrefix =\n+ nameSoFar === '' ? SEPARATOR : nameSoFar + SUBSEPARATOR;\n \n if (Array.isArray(children)) {\n- for (var i = 0; i < children.length; i++) {\n+ for (let i = 0; i < children.length; i++) {\n child = children[i];\n nextName = nextNamePrefix + getComponentKey(child, i);\n subtreeCount += traverseAllChildrenImpl(\n@@ -161,7 +162,7 @@ function traverseAllChildrenImpl(\n );\n }\n } else {\n- var iteratorFn = getIteratorFn(children);\n+ const iteratorFn = getIteratorFn(children);\n if (typeof iteratorFn === 'function') {\n if (__DEV__) {\n \/\/ Warn about using Maps as children\n@@ -177,9 +178,9 @@ function traverseAllChildrenImpl(\n }\n }\n \n- var iterator = iteratorFn.call(children);\n- var step;\n- var ii = 0;\n+ const iterator = iteratorFn.call(children);\n+ let step;\n+ let ii = 0;\n while (!(step = iterator.next()).done) {\n child = step.value;\n nextName = nextNamePrefix + getComponentKey(child, ii++);\n@@ -191,14 +192,14 @@ function traverseAllChildrenImpl(\n );\n }\n } else if (type === 'object') {\n- var addendum = '';\n+ let addendum = '';\n if (__DEV__) {\n addendum =\n ' If you meant to render a collection of children, use an array ' +\n 'instead.' +\n ReactDebugCurrentFrame.getStackAddendum();\n }\n- var childrenString = '' + children;\n+ const childrenString = '' + children;\n invariant(\n false,\n 'Objects are not valid as a React child (found: %s).%s',\n@@ -260,7 +261,7 @@ function getComponentKey(component, index) {\n }\n \n function forEachSingleChild(bookKeeping, child, name) {\n- var {func, context} = bookKeeping;\n+ const {func, context} = bookKeeping;\n func.call(context, child, bookKeeping.count++);\n }\n \n@@ -280,7 +281,7 @@ function forEachChildren(children, forEachFunc, forEachContext) {\n if (children == null) {\n return children;\n }\n- var traverseContext = getPooledTraverseContext(\n+ const traverseContext = getPooledTraverseContext(\n null,\n null,\n forEachFunc,\n@@ -291,9 +292,9 @@ function forEachChildren(children, forEachFunc, forEachContext) {\n }\n \n function mapSingleChildIntoContext(bookKeeping, child, childKey) {\n- var {result, keyPrefix, func, context} = bookKeeping;\n+ const {result, keyPrefix, func, context} = bookKeeping;\n \n- var mappedChild = func.call(context, child, bookKeeping.count++);\n+ let mappedChild = func.call(context, child, bookKeeping.count++);\n if (Array.isArray(mappedChild)) {\n mapIntoWithKeyPrefixInternal(\n mappedChild,\n@@ -319,11 +320,11 @@ function mapSingleChildIntoContext(bookKeeping, child, childKey) {\n }\n \n function mapIntoWithKeyPrefixInternal(children, array, prefix, func, context) {\n- var escapedPrefix = '';\n+ let escapedPrefix = '';\n if (prefix != null) {\n escapedPrefix = escapeUserProvidedKey(prefix) + '\/';\n }\n- var traverseContext = getPooledTraverseContext(\n+ const traverseContext = getPooledTraverseContext(\n array,\n escapedPrefix,\n func,\n@@ -350,7 +351,7 @@ function mapChildren(children, func, context) {\n if (children == null) {\n return children;\n }\n- var result = [];\n+ const result = [];\n mapIntoWithKeyPrefixInternal(children, result, null, func, context);\n return result;\n }\n@@ -375,7 +376,7 @@ function countChildren(children, context) {\n * See https:\/\/reactjs.org\/docs\/react-api.html#react.children.toarray\n *\/\n function toArray(children) {\n- var result = [];\n+ const result = [];\n mapIntoWithKeyPrefixInternal(\n children,\n result,\ndiff --git a\/packages\/react\/src\/ReactCurrentOwner.js b\/packages\/react\/src\/ReactCurrentOwner.js\nindex 8795ff03db..72ed4e2eb8 100644\n--- a\/packages\/react\/src\/ReactCurrentOwner.js\n+++ b\/packages\/react\/src\/ReactCurrentOwner.js\n@@ -15,7 +15,7 @@ import type {Fiber} from 'react-reconciler\/src\/ReactFiber';\n * The current owner is the component who should own any components that are\n * currently being constructed.\n *\/\n-var ReactCurrentOwner = {\n+const ReactCurrentOwner = {\n \/**\n * @internal\n * @type {ReactComponent}\ndiff --git a\/packages\/react\/src\/ReactElement.js b\/packages\/react\/src\/ReactElement.js\nindex 979494b3ab..a2914b78fc 100644\n--- a\/packages\/react\/src\/ReactElement.js\n+++ b\/packages\/react\/src\/ReactElement.js\n@@ -10,21 +10,21 @@ import {REACT_ELEMENT_TYPE} from 'shared\/ReactSymbols';\n \n import ReactCurrentOwner from '.\/ReactCurrentOwner';\n \n-var hasOwnProperty = Object.prototype.hasOwnProperty;\n+const hasOwnProperty = Object.prototype.hasOwnProperty;\n \n-var RESERVED_PROPS = {\n+const RESERVED_PROPS = {\n key: true,\n ref: true,\n __self: true,\n __source: true,\n };\n \n-var specialPropKeyWarningShown, specialPropRefWarningShown;\n+let specialPropKeyWarningShown, specialPropRefWarningShown;\n \n function hasValidRef(config) {\n if (__DEV__) {\n if (hasOwnProperty.call(config, 'ref')) {\n- var getter = Object.getOwnPropertyDescriptor(config, 'ref').get;\n+ const getter = Object.getOwnPropertyDescriptor(config, 'ref').get;\n if (getter && getter.isReactWarning) {\n return false;\n }\n@@ -36,7 +36,7 @@ function hasValidRef(config) {\n function hasValidKey(config) {\n if (__DEV__) {\n if (hasOwnProperty.call(config, 'key')) {\n- var getter = Object.getOwnPropertyDescriptor(config, 'key').get;\n+ const getter = Object.getOwnPropertyDescriptor(config, 'key').get;\n if (getter && getter.isReactWarning) {\n return false;\n }\n@@ -46,7 +46,7 @@ function hasValidKey(config) {\n }\n \n function defineKeyPropWarningGetter(props, displayName) {\n- var warnAboutAccessingKey = function() {\n+ const warnAboutAccessingKey = function() {\n if (!specialPropKeyWarningShown) {\n specialPropKeyWarningShown = true;\n warning(\n@@ -67,7 +67,7 @@ function defineKeyPropWarningGetter(props, displayName) {\n }\n \n function defineRefPropWarningGetter(props, displayName) {\n- var warnAboutAccessingRef = function() {\n+ const warnAboutAccessingRef = function() {\n if (!specialPropRefWarningShown) {\n specialPropRefWarningShown = true;\n warning(\n@@ -107,8 +107,8 @@ function defineRefPropWarningGetter(props, displayName) {\n * @param {*} props\n * @internal\n *\/\n-var ReactElement = function(type, key, ref, self, source, owner, props) {\n- var element = {\n+const ReactElement = function(type, key, ref, self, source, owner, props) {\n+ const element = {\n \/\/ This tag allow us to uniquely identify this as a React Element\n $$typeof: REACT_ELEMENT_TYPE,\n \n@@ -168,15 +168,15 @@ var ReactElement = function(type, key, ref, self, source, owner, props) {\n * See https:\/\/reactjs.org\/docs\/react-api.html#createelement\n *\/\n export function createElement(type, config, children) {\n- var propName;\n+ let propName;\n \n \/\/ Reserved names are extracted\n- var props = {};\n+ const props = {};\n \n- var key = null;\n- var ref = null;\n- var self = null;\n- var source = null;\n+ let key = null;\n+ let ref = null;\n+ let self = null;\n+ let source = null;\n \n if (config != null) {\n if (hasValidRef(config)) {\n@@ -201,12 +201,12 @@ export function createElement(type, config, children) {\n \n \/\/ Children can be more than one argument, and those are transferred onto\n \/\/ the newly allocated props object.\n- var childrenLength = arguments.length - 2;\n+ const childrenLength = arguments.length - 2;\n if (childrenLength === 1) {\n props.children = children;\n } else if (childrenLength > 1) {\n- var childArray = Array(childrenLength);\n- for (var i = 0; i < childrenLength; i++) {\n+ const childArray = Array(childrenLength);\n+ for (let i = 0; i < childrenLength; i++) {\n childArray[i] = arguments[i + 2];\n }\n if (__DEV__) {\n@@ -219,7 +219,7 @@ export function createElement(type, config, children) {\n \n \/\/ Resolve default props\n if (type && type.defaultProps) {\n- var defaultProps = type.defaultProps;\n+ const defaultProps = type.defaultProps;\n for (propName in defaultProps) {\n if (props[propName] === undefined) {\n props[propName] = defaultProps[propName];\n@@ -232,7 +232,7 @@ export function createElement(type, config, children) {\n typeof props.$$typeof === 'undefined' ||\n props.$$typeof !== REACT_ELEMENT_TYPE\n ) {\n- var displayName =\n+ const displayName =\n typeof type === 'function'\n ? type.displayName || type.name || 'Unknown'\n : type;\n@@ -261,7 +261,7 @@ export function createElement(type, config, children) {\n * See https:\/\/reactjs.org\/docs\/react-api.html#createfactory\n *\/\n export function createFactory(type) {\n- var factory = createElement.bind(null, type);\n+ const factory = createElement.bind(null, type);\n \/\/ Expose the type on the factory and the prototype so that it can be\n \/\/ easily accessed on elements. E.g. `.type === Foo`.\n \/\/ This should not be named `constructor` since this may not be the function\n@@ -272,7 +272,7 @@ export function createFactory(type) {\n }\n \n export function cloneAndReplaceKey(oldElement, newKey) {\n- var newElement = ReactElement(\n+ const newElement = ReactElement(\n oldElement.type,\n newKey,\n oldElement.ref,\n@@ -290,23 +290,23 @@ export function cloneAndReplaceKey(oldElement, newKey) {\n * See https:\/\/reactjs.org\/docs\/react-api.html#cloneelement\n *\/\n export function cloneElement(element, config, children) {\n- var propName;\n+ let propName;\n \n \/\/ Original props are copied\n- var props = Object.assign({}, element.props);\n+ const props = Object.assign({}, element.props);\n \n \/\/ Reserved names are extracted\n- var key = element.key;\n- var ref = element.ref;\n+ let key = element.key;\n+ let ref = element.ref;\n \/\/ Self is preserved since the owner is preserved.\n- var self = element._self;\n+ const self = element._self;\n \/\/ Source is preserved since cloneElement is unlikely to be targeted by a\n \/\/ transpiler, and the original source is probably a better indicator of the\n \/\/ true owner.\n- var source = element._source;\n+ const source = element._source;\n \n \/\/ Owner will be preserved, unless ref is overridden\n- var owner = element._owner;\n+ let owner = element._owner;\n \n if (config != null) {\n if (hasValidRef(config)) {\n@@ -319,7 +319,7 @@ export function cloneElement(element, config, children) {\n }\n \n \/\/ Remaining properties override existing props\n- var defaultProps;\n+ let defaultProps;\n if (element.type && element.type.defaultProps) {\n defaultProps = element.type.defaultProps;\n }\n@@ -340,12 +340,12 @@ export function cloneElement(element, config, children) {\n \n \/\/ Children can be more than one argument, and those are transferred onto\n \/\/ the newly allocated props object.\n- var childrenLength = arguments.length - 2;\n+ const childrenLength = arguments.length - 2;\n if (childrenLength === 1) {\n props.children = children;\n } else if (childrenLength > 1) {\n- var childArray = Array(childrenLength);\n- for (var i = 0; i < childrenLength; i++) {\n+ const childArray = Array(childrenLength);\n+ for (let i = 0; i < childrenLength; i++) {\n childArray[i] = arguments[i + 2];\n }\n props.children = childArray;\ndiff --git a\/packages\/react\/src\/ReactElementValidator.js b\/packages\/react\/src\/ReactElementValidator.js\nindex 8fb5d2e6c5..abc6054d04 100644\n--- a\/packages\/react\/src\/ReactElementValidator.js\n+++ b\/packages\/react\/src\/ReactElementValidator.js\n@@ -43,10 +43,10 @@ if (__DEV__) {\n };\n \n var getStackAddendum = function(): string {\n- var stack = '';\n+ let stack = '';\n if (currentlyValidatingElement) {\n- var name = getDisplayName(currentlyValidatingElement);\n- var owner = currentlyValidatingElement._owner;\n+ const name = getDisplayName(currentlyValidatingElement);\n+ const owner = currentlyValidatingElement._owner;\n stack += describeComponentFrame(\n name,\n currentlyValidatingElement._source,\n@@ -62,7 +62,7 @@ if (__DEV__) {\n \n function getDeclarationErrorAddendum() {\n if (ReactCurrentOwner.current) {\n- var name = getComponentName(ReactCurrentOwner.current);\n+ const name = getComponentName(ReactCurrentOwner.current);\n if (name) {\n return '\\n\\nCheck the render method of `' + name + '`.';\n }\n@@ -76,9 +76,9 @@ function getSourceInfoErrorAddendum(elementProps) {\n elementProps !== undefined &&\n elementProps.__source !== undefined\n ) {\n- var source = elementProps.__source;\n- var fileName = source.fileName.replace(\/^.*[\\\\\\\/]\/, '');\n- var lineNumber = source.lineNumber;\n+ const source = elementProps.__source;\n+ const fileName = source.fileName.replace(\/^.*[\\\\\\\/]\/, '');\n+ const lineNumber = source.lineNumber;\n return '\\n\\nCheck your code at ' + fileName + ':' + lineNumber + '.';\n }\n return '';\n@@ -89,13 +89,13 @@ function getSourceInfoErrorAddendum(elementProps) {\n * object keys are not valid. This allows us to keep track of children between\n * updates.\n *\/\n-var ownerHasKeyUseWarning = {};\n+const ownerHasKeyUseWarning = {};\n \n function getCurrentComponentErrorInfo(parentType) {\n- var info = getDeclarationErrorAddendum();\n+ let info = getDeclarationErrorAddendum();\n \n if (!info) {\n- var parentName =\n+ const parentName =\n typeof parentType === 'string'\n ? parentType\n : parentType.displayName || parentType.name;\n@@ -123,7 +123,7 @@ function validateExplicitKey(element, parentType) {\n }\n element._store.validated = true;\n \n- var currentComponentErrorInfo = getCurrentComponentErrorInfo(parentType);\n+ const currentComponentErrorInfo = getCurrentComponentErrorInfo(parentType);\n if (ownerHasKeyUseWarning[currentComponentErrorInfo]) {\n return;\n }\n@@ -132,7 +132,7 @@ function validateExplicitKey(element, parentType) {\n \/\/ Usually the current owner is the offender, but if it accepts children as a\n \/\/ property, it may be the creator of the child that's responsible for\n \/\/ assigning it a key.\n- var childOwner = '';\n+ let childOwner = '';\n if (\n element &&\n element._owner &&\n@@ -172,8 +172,8 @@ function validateChildKeys(node, parentType) {\n return;\n }\n if (Array.isArray(node)) {\n- for (var i = 0; i < node.length; i++) {\n- var child = node[i];\n+ for (let i = 0; i < node.length; i++) {\n+ const child = node[i];\n if (isValidElement(child)) {\n validateExplicitKey(child, parentType);\n }\n@@ -184,13 +184,13 @@ function validateChildKeys(node, parentType) {\n node._store.validated = true;\n }\n } else if (node) {\n- var iteratorFn = getIteratorFn(node);\n+ const iteratorFn = getIteratorFn(node);\n if (typeof iteratorFn === 'function') {\n \/\/ Entry iterators used to provide implicit keys,\n \/\/ but now we print a separate warning for them later.\n if (iteratorFn !== node.entries) {\n- var iterator = iteratorFn.call(node);\n- var step;\n+ const iterator = iteratorFn.call(node);\n+ let step;\n while (!(step = iterator.next()).done) {\n if (isValidElement(step.value)) {\n validateExplicitKey(step.value, parentType);\n@@ -208,12 +208,12 @@ function validateChildKeys(node, parentType) {\n * @param {ReactElement} element\n *\/\n function validatePropTypes(element) {\n- var componentClass = element.type;\n+ const componentClass = element.type;\n if (typeof componentClass !== 'function') {\n return;\n }\n- var name = componentClass.displayName || componentClass.name;\n- var propTypes = componentClass.propTypes;\n+ const name = componentClass.displayName || componentClass.name;\n+ const propTypes = componentClass.propTypes;\n if (propTypes) {\n currentlyValidatingElement = element;\n checkPropTypes(propTypes, element.props, 'prop', name, getStackAddendum);\n@@ -270,7 +270,7 @@ function validateFragmentProps(fragment) {\n }\n \n export function createElementWithValidation(type, props, children) {\n- var validType =\n+ const validType =\n typeof type === 'string' ||\n typeof type === 'function' ||\n typeof type === 'symbol' ||\n@@ -278,7 +278,7 @@ export function createElementWithValidation(type, props, children) {\n \/\/ We warn in this case but don't throw. We expect the element creation to\n \/\/ succeed and there will likely be errors in render.\n if (!validType) {\n- var info = '';\n+ let info = '';\n if (\n type === undefined ||\n (typeof type === 'object' &&\n@@ -290,7 +290,7 @@ export function createElementWithValidation(type, props, children) {\n \"it's defined in, or you might have mixed up default and named imports.\";\n }\n \n- var sourceInfo = getSourceInfoErrorAddendum(props);\n+ const sourceInfo = getSourceInfoErrorAddendum(props);\n if (sourceInfo) {\n info += sourceInfo;\n } else {\n@@ -309,7 +309,7 @@ export function createElementWithValidation(type, props, children) {\n );\n }\n \n- var element = createElement.apply(this, arguments);\n+ const element = createElement.apply(this, arguments);\n \n \/\/ The result can be nullish if a mock or a custom function is used.\n \/\/ TODO: Drop this when these are no longer allowed as the type argument.\n@@ -323,7 +323,7 @@ export function createElementWithValidation(type, props, children) {\n \/\/ (Rendering will throw with a helpful message and as soon as the type is\n \/\/ fixed, the key warnings will appear.)\n if (validType) {\n- for (var i = 2; i < arguments.length; i++) {\n+ for (let i = 2; i < arguments.length; i++) {\n validateChildKeys(arguments[i], type);\n }\n }\n@@ -338,7 +338,7 @@ export function createElementWithValidation(type, props, children) {\n }\n \n export function createFactoryWithValidation(type) {\n- var validatedFactory = createElementWithValidation.bind(null, type);\n+ const validatedFactory = createElementWithValidation.bind(null, type);\n \/\/ Legacy hook TODO: Warn if this is accessed\n validatedFactory.type = type;\n \n@@ -363,8 +363,8 @@ export function createFactoryWithValidation(type) {\n }\n \n export function cloneElementWithValidation(element, props, children) {\n- var newElement = cloneElement.apply(this, arguments);\n- for (var i = 2; i < arguments.length; i++) {\n+ const newElement = cloneElement.apply(this, arguments);\n+ for (let i = 2; i < arguments.length; i++) {\n validateChildKeys(arguments[i], newElement.type);\n }\n validatePropTypes(newElement);\ndiff --git a\/packages\/react\/src\/ReactNoopUpdateQueue.js b\/packages\/react\/src\/ReactNoopUpdateQueue.js\nindex 9fe6f7e485..5aa1ccf915 100644\n--- a\/packages\/react\/src\/ReactNoopUpdateQueue.js\n+++ b\/packages\/react\/src\/ReactNoopUpdateQueue.js\n@@ -7,11 +7,11 @@\n \n import warning from 'fbjs\/lib\/warning';\n \n-var didWarnStateUpdateForUnmountedComponent = {};\n+const didWarnStateUpdateForUnmountedComponent = {};\n \n function warnNoop(publicInstance, callerName) {\n if (__DEV__) {\n- var constructor = publicInstance.constructor;\n+ const constructor = publicInstance.constructor;\n const componentName =\n (constructor && (constructor.displayName || constructor.name)) ||\n 'ReactClass';\n@@ -35,7 +35,7 @@ function warnNoop(publicInstance, callerName) {\n \/**\n * This is the abstract API for an update queue.\n *\/\n-var ReactNoopUpdateQueue = {\n+const ReactNoopUpdateQueue = {\n \/**\n * Checks whether or not this composite component is mounted.\n * @param {ReactClass} publicInstance The instance we want to test.\ndiff --git a\/packages\/react\/src\/__tests__\/ReactAsyncClassComponent-test.internal.js b\/packages\/react\/src\/__tests__\/ReactAsyncClassComponent-test.internal.js\nindex 0bdd9e3152..19ce44d41c 100644\n--- a\/packages\/react\/src\/__tests__\/ReactAsyncClassComponent-test.internal.js\n+++ b\/packages\/react\/src\/__tests__\/ReactAsyncClassComponent-test.internal.js\n@@ -9,9 +9,9 @@\n \n 'use strict';\n \n-var React;\n-var ReactFeatureFlags;\n-var ReactTestRenderer;\n+let React;\n+let ReactFeatureFlags;\n+let ReactTestRenderer;\n \n describe('ReactAsyncClassComponent', () => {\n describe('debugRenderPhaseSideEffects', () => {\ndiff --git a\/packages\/react\/src\/__tests__\/ReactChildren-test.js b\/packages\/react\/src\/__tests__\/ReactChildren-test.js\nindex 057008e125..952807851c 100644\n--- a\/packages\/react\/src\/__tests__\/ReactChildren-test.js\n+++ b\/packages\/react\/src\/__tests__\/ReactChildren-test.js\n@@ -10,8 +10,8 @@\n 'use strict';\n \n describe('ReactChildren', () => {\n- var React;\n- var ReactTestUtils;\n+ let React;\n+ let ReactTestUtils;\n \n function normalizeCodeLocInfo(str) {\n return str && str.replace(\/at .+?:\\d+\/g, 'at **');\n@@ -24,22 +24,22 @@ describe('ReactChildren', () => {\n });\n \n it('should support identity for simple', () => {\n- var context = {};\n- var callback = jasmine.createSpy().and.callFake(function(kid, index) {\n+ const context = {};\n+ const callback = jasmine.createSpy().and.callFake(function(kid, index) {\n expect(this).toBe(context);\n return kid;\n });\n \n- var simpleKid = ;\n+ const simpleKid = ;\n \n \/\/ First pass children into a component to fully simulate what happens when\n \/\/ using structures that arrive from transforms.\n \n- var instance =

{simpleKid}<\/div>;\n+ const instance =

{simpleKid}<\/div>;\n React.Children.forEach(instance.props.children, callback, context);\n expect(callback).toHaveBeenCalledWith(simpleKid, 0);\n callback.calls.reset();\n- var mappedChildren = React.Children.map(\n+ const mappedChildren = React.Children.map(\n instance.props.children,\n callback,\n context,\n@@ -123,18 +123,18 @@ describe('ReactChildren', () => {\n });\n \n it('should treat single arrayless child as being in array', () => {\n- var context = {};\n- var callback = jasmine.createSpy().and.callFake(function(kid, index) {\n+ const context = {};\n+ const callback = jasmine.createSpy().and.callFake(function(kid, index) {\n expect(this).toBe(context);\n return kid;\n });\n \n- var simpleKid = ;\n- var instance =

{simpleKid}<\/div>;\n+ const simpleKid = ;\n+ const instance =

{simpleKid}<\/div>;\n React.Children.forEach(instance.props.children, callback, context);\n expect(callback).toHaveBeenCalledWith(simpleKid, 0);\n callback.calls.reset();\n- var mappedChildren = React.Children.map(\n+ const mappedChildren = React.Children.map(\n instance.props.children,\n callback,\n context,\n@@ -144,18 +144,18 @@ describe('ReactChildren', () => {\n });\n \n it('should treat single child in array as expected', () => {\n- var context = {};\n- var callback = jasmine.createSpy().and.callFake(function(kid, index) {\n+ const context = {};\n+ const callback = jasmine.createSpy().and.callFake(function(kid, index) {\n expect(this).toBe(context);\n return kid;\n });\n \n- var simpleKid = ;\n- var instance =

{[simpleKid]}<\/div>;\n+ const simpleKid = ;\n+ const instance =

{[simpleKid]}<\/div>;\n React.Children.forEach(instance.props.children, callback, context);\n expect(callback).toHaveBeenCalledWith(simpleKid, 0);\n callback.calls.reset();\n- var mappedChildren = React.Children.map(\n+ const mappedChildren = React.Children.map(\n instance.props.children,\n callback,\n context,\n@@ -165,19 +165,19 @@ describe('ReactChildren', () => {\n });\n \n it('should be called for each child', () => {\n- var zero =

;\n- var one = null;\n- var two =

;\n- var three = null;\n- var four =

;\n- var context = {};\n-\n- var callback = jasmine.createSpy().and.callFake(function(kid) {\n+ const zero =

;\n+ const one = null;\n+ const two =

;\n+ const three = null;\n+ const four =

;\n+ const context = {};\n+\n+ const callback = jasmine.createSpy().and.callFake(function(kid) {\n expect(this).toBe(context);\n return kid;\n });\n \n- var instance = (\n+ const instance = (\n

\n {zero}\n {one}\n@@ -199,7 +199,7 @@ describe('ReactChildren', () => {\n React.Children.forEach(instance.props.children, callback, context);\n assertCalls();\n \n- var mappedChildren = React.Children.map(\n+ const mappedChildren = React.Children.map(\n instance.props.children,\n callback,\n context,\n@@ -213,17 +213,17 @@ describe('ReactChildren', () => {\n });\n \n it('should traverse children of different kinds', () => {\n- var div =

dillon1000/react

Files changed