{"parents":["457ea7b9d67b7b6ef32021a7a0ab7834d2d9dbbf"],"body":"","files":[{"path":"packages\/react-dom\/src\/__tests__\/ReactChildReconciler-test.js","status":"M"}],"commit":{"revision":"3cfe0cc0c2916352b8f18d14251be27f6d484eac","authoredAt":"2024-02-02T09:15:10+01:00","authorName":"Sebastian Silbermann","subject":"Convert ReactChildReconciler to createRoot (#28192)","shortRevision":"3cfe0cc0c2","authorEmail":"silbermann.sebastian@gmail.com"},"patch":"diff --git a\/packages\/react-dom\/src\/__tests__\/ReactChildReconciler-test.js b\/packages\/react-dom\/src\/__tests__\/ReactChildReconciler-test.js\nindex 08d81f72ae..ef584a7856 100644\n--- a\/packages\/react-dom\/src\/__tests__\/ReactChildReconciler-test.js\n+++ b\/packages\/react-dom\/src\/__tests__\/ReactChildReconciler-test.js\n@@ -13,14 +13,16 @@\n 'use strict';\n \n let React;\n-let ReactTestUtils;\n+let ReactDOMClient;\n+let act;\n \n describe('ReactChildReconciler', () => {\n beforeEach(() => {\n jest.resetModules();\n \n React = require('react');\n- ReactTestUtils = require('react-dom\/test-utils');\n+ ReactDOMClient = require('react-dom\/client');\n+ act = require('internal-test-utils').act;\n });\n \n function createIterable(array) {\n@@ -55,29 +57,39 @@ describe('ReactChildReconciler', () => {\n return fn;\n }\n \n- it('does not treat functions as iterables', () => {\n- let node;\n+ it('does not treat functions as iterables', async () => {\n const iterableFunction = makeIterableFunction('foo');\n \n- expect(() => {\n- node = ReactTestUtils.renderIntoDocument(\n-

\n-

{iterableFunction}<\/h1>\n- <\/div>,\n- );\n+ const container = document.createElement('div');\n+ const root = ReactDOMClient.createRoot(container);\n+ await expect(async () => {\n+ await act(() => {\n+ root.render(\n+
\n+
{iterableFunction}<\/h1>\n+ <\/div>,\n+ );\n+ });\n }).toErrorDev('Functions are not valid as a React child');\n+ const node = container.firstChild;\n \n expect(node.innerHTML).toContain(''); \/\/ h1\n });\n \n- it('warns for duplicated array keys', () => {\n+ it('warns for duplicated array keys', async () => {\n class Component extends React.Component {\n render() {\n return
{[
,
]}<\/div>;\n }\n }\n \n- expect(() => ReactTestUtils.renderIntoDocument()).toErrorDev(\n+ const container = document.createElement('div');\n+ const root = ReactDOMClient.createRoot(container);\n+ await expect(async () => {\n+ await act(() => {\n+ root.render();\n+ });\n+ }).toErrorDev(\n 'Keys should be unique so that components maintain their identity ' +\n 'across updates. Non-unique keys may cause children to be ' +\n 'duplicated and\/or omitted — the behavior is unsupported and ' +\n@@ -85,7 +97,7 @@ describe('ReactChildReconciler', () => {\n );\n });\n \n- it('warns for duplicated array keys with component stack info', () => {\n+ it('warns for duplicated array keys with component stack info', async () => {\n class Component extends React.Component {\n render() {\n return
{[
,
]}<\/div>;\n@@ -104,7 +116,13 @@ describe('ReactChildReconciler', () => {\n }\n }\n \n- expect(() => ReactTestUtils.renderIntoDocument()).toErrorDev(\n+ const container = document.createElement('div');\n+ const root = ReactDOMClient.createRoot(container);\n+ await expect(async () => {\n+ await act(() => {\n+ root.render();\n+ });\n+ }).toErrorDev(\n 'Encountered two children with the same key, `1`. ' +\n 'Keys should be unique so that components maintain their identity ' +\n 'across updates. Non-unique keys may cause children to be ' +\n@@ -117,14 +135,20 @@ describe('ReactChildReconciler', () => {\n );\n });\n \n- it('warns for duplicated iterable keys', () => {\n+ it('warns for duplicated iterable keys', async () => {\n class Component extends React.Component {\n render() {\n return
{createIterable([
,
])}<\/div>;\n }\n }\n \n- expect(() => ReactTestUtils.renderIntoDocument()).toErrorDev(\n+ const container = document.createElement('div');\n+ const root = ReactDOMClient.createRoot(container);\n+ await expect(async () => {\n+ await act(() => {\n+ root.render();\n+ });\n+ }).toErrorDev(\n 'Keys should be unique so that components maintain their identity ' +\n 'across updates. Non-unique keys may cause children to be ' +\n 'duplicated and\/or omitted — the behavior is unsupported and ' +\n@@ -132,7 +156,7 @@ describe('ReactChildReconciler', () => {\n );\n });\n \n- it('warns for duplicated iterable keys with component stack info', () => {\n+ it('warns for duplicated iterable keys with component stack info', async () => {\n class Component extends React.Component {\n render() {\n return
{createIterable([
,
])}<\/div>;\n@@ -151,7 +175,13 @@ describe('ReactChildReconciler', () => {\n }\n }\n \n- expect(() => ReactTestUtils.renderIntoDocument()).toErrorDev(\n+ const container = document.createElement('div');\n+ const root = ReactDOMClient.createRoot(container);\n+ await expect(async () => {\n+ await act(() => {\n+ root.render();\n+ });\n+ }).toErrorDev(\n 'Encountered two children with the same key, `1`. ' +\n 'Keys should be unique so that components maintain their identity ' +\n 'across updates. Non-unique keys may cause children to be ' +\n"}

dillon1000/react

Files changed