dillon1000/react

Commit

Enable prefer-const lint rules (#18451)

* Enable prefer-const rule

Stylistically I don't like this but Closure Compiler takes advantage of
this information.

* Auto-fix lints

* Manually fix the remaining callsites
Browse files
Changed paths215 files
First-parent comparison
M .eslintrc.js ModifiedM packages/babel-plugin-react-jsx/src/TransformJSXToReactBabelPlugin.js ModifiedM packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js ModifiedM packages/eslint-plugin-react-hooks/src/RulesOfHooks.js ModifiedM packages/jest-react/src/JestReact.js ModifiedM packages/legacy-events/getListener.js ModifiedM packages/react-art/src/ReactARTHostConfig.js ModifiedM packages/react-cache/src/ReactCache.js ModifiedM packages/react-cache/src/__tests__/ReactCache-test.internal.js ModifiedM packages/react-client/src/ReactFlightClient.js ModifiedM packages/react-client/src/ReactFlightClientStream.js ModifiedM packages/react-client/src/__tests__/ReactFlight-test.js ModifiedM packages/react-debug-tools/src/ReactDebugHooks.js ModifiedM packages/react-debug-tools/src/__tests__/ReactHooksInspection-test.internal.js ModifiedM packages/react-debug-tools/src/__tests__/ReactHooksInspection-test.js ModifiedM packages/react-debug-tools/src/__tests__/ReactHooksInspectionIntegration-test.js ModifiedM packages/react-devtools-core/src/editor.js ModifiedM packages/react-devtools-extensions/src/main.js ModifiedM packages/react-devtools-extensions/src/panel.js ModifiedM packages/react-devtools-shared/src/__tests__/profilingCache-test.js ModifiedM packages/react-devtools-shared/src/__tests__/storeStressSync-test.js ModifiedM packages/react-devtools-shared/src/__tests__/storeStressTestConcurrent-test.js ModifiedM packages/react-devtools-shared/src/__tests__/treeContext-test.js ModifiedM packages/react-devtools-shared/src/backend/NativeStyleEditor/setupNativeStyleEditor.js ModifiedM packages/react-devtools-shared/src/backend/agent.js ModifiedM packages/react-devtools-shared/src/backend/console.js ModifiedM packages/react-devtools-shared/src/backend/describeComponentFrame.js ModifiedM packages/react-devtools-shared/src/backend/legacy/renderer.js ModifiedM packages/react-devtools-shared/src/backend/legacy/utils.js ModifiedM packages/react-devtools-shared/src/backend/renderer.js ModifiedM packages/react-devtools-shared/src/backend/views/Highlighter/Overlay.js ModifiedM packages/react-devtools-shared/src/backend/views/TraceUpdates/index.js ModifiedM packages/react-devtools-shared/src/devtools/ProfilerStore.js ModifiedM packages/react-devtools-shared/src/devtools/store.js ModifiedM packages/react-devtools-shared/src/devtools/utils.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/InspectedElementContext.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/KeyValue.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/NativeStyleEditor/context.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/OwnersListContext.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/Tree.js ModifiedM packages/react-devtools-shared/src/devtools/views/Components/TreeContext.js ModifiedM packages/react-devtools-shared/src/devtools/views/DevTools.js ModifiedM packages/react-devtools-shared/src/devtools/views/Profiler/CommitFlamegraphListItem.js ModifiedM packages/react-devtools-shared/src/events.js ModifiedM packages/react-devtools-shared/src/hydration.js ModifiedM packages/react-devtools-shared/src/utils.js ModifiedM packages/react-devtools-shell/src/app/SuspenseTree/index.js ModifiedM packages/react-dom/src/__tests__/ReactCompositeComponentState-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMComponent-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMEventListener-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMFiber-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMFiberAsync-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactDOMFizzServerBrowser-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMFizzServerNode-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMHooks-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMInput-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMOption-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMSelect-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMSelection-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerIntegrationBasic-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerIntegrationClassContextType-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerIntegrationElements-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerIntegrationFragment-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerIntegrationHooks-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerIntegrationLegacyContextDisabled-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerIntegrationModes-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerIntegrationNewContext-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerIntegrationUntrustedURL-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerPartialHydration-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactDOMServerSelectiveHydration-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactDOMSuspensePlaceholder-test.js ModifiedM packages/react-dom/src/__tests__/ReactDOMTextComponent-test.js ModifiedM packages/react-dom/src/__tests__/ReactErrorBoundaries-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactErrorLoggingRecovery-test.js ModifiedM packages/react-dom/src/__tests__/ReactLegacyContextDisabled-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactLegacyErrorBoundaries-test.internal.js ModifiedM packages/react-dom/src/__tests__/ReactServerRendering-test.js ModifiedM packages/react-dom/src/__tests__/ReactServerRenderingHydration-test.js ModifiedM packages/react-dom/src/__tests__/ReactTestUtilsAct-test.js ModifiedM packages/react-dom/src/__tests__/ReactTestUtilsActUnmockedScheduler-test.js ModifiedM packages/react-dom/src/__tests__/ReactTreeTraversal-test.js ModifiedM packages/react-dom/src/__tests__/ReactUpdates-test.js ModifiedM packages/react-dom/src/__tests__/utils/ReactDOMServerIntegrationTestUtils.js ModifiedM packages/react-dom/src/client/ReactDOMComponentTree.js ModifiedM packages/react-dom/src/client/ReactDOMHostConfig.js ModifiedM packages/react-dom/src/client/ReactDOMLegacy.js ModifiedM packages/react-dom/src/client/ReactDOMSelect.js ModifiedM packages/react-dom/src/client/ReactDOMSelection.js ModifiedM packages/react-dom/src/client/ReactInputSelection.js ModifiedM packages/react-dom/src/client/__tests__/trustedTypes-test.internal.js ModifiedM packages/react-dom/src/client/setTextContent.js ModifiedM packages/react-dom/src/client/validateDOMNesting.js ModifiedM packages/react-dom/src/events/ChangeEventPlugin.js ModifiedM packages/react-dom/src/events/DOMModernPluginEventSystem.js ModifiedM packages/react-dom/src/events/DeprecatedDOMEventResponderSystem.js ModifiedM packages/react-dom/src/events/ReactDOMEventListener.js ModifiedM packages/react-dom/src/events/ReactDOMEventReplaying.js ModifiedM packages/react-dom/src/events/__tests__/DOMModernPluginEventSystem-test.internal.js ModifiedM packages/react-dom/src/events/__tests__/DeprecatedDOMEventResponderSystem-test.internal.js ModifiedM packages/react-dom/src/events/__tests__/EnterLeaveEventPlugin-test.js ModifiedM packages/react-dom/src/events/__tests__/SimpleEventPlugin-test.internal.js ModifiedM packages/react-dom/src/events/__tests__/SyntheticEvent-test.js ModifiedM packages/react-dom/src/events/__tests__/SyntheticKeyboardEvent-test.js ModifiedM packages/react-dom/src/server/ReactDOMFizzServerNode.js ModifiedM packages/react-dom/src/server/ReactPartialRenderer.js ModifiedM packages/react-dom/src/server/ReactPartialRendererContext.js ModifiedM packages/react-dom/src/server/ReactPartialRendererHooks.js ModifiedM packages/react-dom/src/server/ReactThreadIDAllocator.js ModifiedM packages/react-dom/src/test-utils/ReactTestUtils.js ModifiedM packages/react-dom/src/test-utils/ReactTestUtilsAct.js ModifiedM packages/react-flight-dom-relay/src/ReactFlightDOMRelayClient.js ModifiedM packages/react-flight-dom-relay/src/ReactFlightDOMRelayServer.js ModifiedM packages/react-flight-dom-relay/src/ReactFlightDOMRelayServerHostConfig.js ModifiedM packages/react-flight-dom-relay/src/__tests__/ReactFlightDOMRelay-test.internal.js ModifiedM packages/react-flight-dom-webpack/src/ReactFlightClientWebpackBundlerConfig.js ModifiedM packages/react-flight-dom-webpack/src/ReactFlightDOMClient.js ModifiedM packages/react-flight-dom-webpack/src/ReactFlightDOMServerNode.js ModifiedM packages/react-flight-dom-webpack/src/__tests__/ReactFlightDOM-test.js ModifiedM packages/react-flight-dom-webpack/src/__tests__/ReactFlightDOMBrowser-test.js ModifiedM packages/react-interactions/events/src/dom/PressLegacy.js ModifiedM packages/react-interactions/events/src/dom/__tests__/FocusWithin-test.internal.js ModifiedM packages/react-interactions/events/src/dom/__tests__/PressLegacy-test.internal.js ModifiedM packages/react-native-renderer/src/ReactFabricComponentTree.js ModifiedM packages/react-native-renderer/src/ReactNativeFiberHostComponent.js ModifiedM packages/react-native-renderer/src/ReactNativeRenderer.js ModifiedM packages/react-native-renderer/src/__mocks__/react-native/Libraries/ReactPrivate/InitializeNativeFabricUIManager.js ModifiedM packages/react-native-renderer/src/__mocks__/react-native/Libraries/ReactPrivate/UIManager.js ModifiedM packages/react-native-renderer/src/__tests__/ReactFabric-test.internal.js ModifiedM packages/react-native-renderer/src/__tests__/ReactFabricAndNative-test.internal.js ModifiedM packages/react-native-renderer/src/__tests__/ReactNativeError-test.internal.js ModifiedM packages/react-native-renderer/src/__tests__/ReactNativeMount-test.internal.js ModifiedM packages/react-noop-renderer/flight-modules.js ModifiedM packages/react-noop-renderer/src/ReactNoopFlightClient.js ModifiedM packages/react-noop-renderer/src/ReactNoopFlightServer.js ModifiedM packages/react-noop-renderer/src/ReactNoopServer.js ModifiedM packages/react-noop-renderer/src/createReactNoop.js ModifiedM packages/react-reconciler/src/ReactChildFiber.js ModifiedM packages/react-reconciler/src/ReactFiber.js ModifiedM packages/react-reconciler/src/ReactFiberBeginWork.js ModifiedM packages/react-reconciler/src/ReactFiberClassComponent.js ModifiedM packages/react-reconciler/src/ReactFiberCommitWork.js ModifiedM packages/react-reconciler/src/ReactFiberCompleteWork.js ModifiedM packages/react-reconciler/src/ReactFiberContext.js ModifiedM packages/react-reconciler/src/ReactFiberHooks.js ModifiedM packages/react-reconciler/src/ReactFiberHostContext.js ModifiedM packages/react-reconciler/src/ReactFiberHotReloading.js ModifiedM packages/react-reconciler/src/ReactFiberHydrationContext.js ModifiedM packages/react-reconciler/src/ReactFiberLazyComponent.js ModifiedM packages/react-reconciler/src/ReactFiberNewContext.js ModifiedM packages/react-reconciler/src/ReactFiberReconciler.old.js ModifiedM packages/react-reconciler/src/ReactFiberSuspenseComponent.js ModifiedM packages/react-reconciler/src/ReactFiberThrow.js ModifiedM packages/react-reconciler/src/ReactFiberTreeReflection.js ModifiedM packages/react-reconciler/src/ReactFiberWorkLoop.js ModifiedM packages/react-reconciler/src/ReactMutableSource.js ModifiedM packages/react-reconciler/src/ReactUpdateQueue.js ModifiedM packages/react-reconciler/src/SchedulerWithReactIntegration.js ModifiedM packages/react-reconciler/src/__tests__/ReactBlocks-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactDisableSchedulerTimeoutBasedOnReactExpirationTime-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactExpiration-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactFiberHostContext-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactHooks-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactHooksWithNoopRenderer-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncremental-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalErrorHandling-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalErrorReplay-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalReflection-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalScheduling-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalTriangle-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalUpdates-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactNewContext-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactNoopRendererAct-test.js ModifiedM packages/react-reconciler/src/__tests__/ReactScope-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspense-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspenseCallback-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspenseFuzz-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspenseList-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactSuspenseWithNoopRenderer-test.internal.js ModifiedM packages/react-reconciler/src/__tests__/ReactTransition-test.internal.js ModifiedM packages/react-refresh/src/ReactFreshBabelPlugin.js ModifiedM packages/react-refresh/src/ReactFreshRuntime.js ModifiedM packages/react-refresh/src/__tests__/ReactFresh-test.js ModifiedM packages/react-refresh/src/__tests__/ReactFreshBabelPlugin-test.js ModifiedM packages/react-refresh/src/__tests__/ReactFreshIntegration-test.js ModifiedM packages/react-refresh/src/__tests__/ReactFreshMultipleRenderer-test.internal.js ModifiedM packages/react-server/src/ReactFizzServer.js ModifiedM packages/react-server/src/ReactFlightServer.js ModifiedM packages/react-server/src/ReactFlightServerConfigStream.js ModifiedM packages/react-server/src/ReactFlightServerRuntime.js ModifiedM packages/react-server/src/ReactServerStreamConfigNode.js ModifiedM packages/react-server/src/__tests__/ReactServer-test.js ModifiedM packages/react-test-renderer/src/__tests__/ReactShallowRenderer-test.js ModifiedM packages/react-test-renderer/src/__tests__/ReactShallowRendererHooks-test.js ModifiedM packages/react-test-renderer/src/__tests__/ReactShallowRendererMemo-test.js ModifiedM packages/react-test-renderer/src/__tests__/ReactTestRendererAct-test.js ModifiedM packages/react/src/ReactBlock.js ModifiedM packages/react/src/ReactChildren.js ModifiedM packages/react/src/ReactLazy.js ModifiedM packages/react/src/__tests__/ReactDOMTracing-test.internal.js ModifiedM packages/react/src/__tests__/ReactProfiler-test.internal.js ModifiedM packages/scheduler/src/Scheduler.js ModifiedM packages/scheduler/src/__tests__/SchedulerBrowser-test.js ModifiedM packages/scheduler/src/__tests__/SchedulerNoDOM-test.js ModifiedM packages/scheduler/src/forks/SchedulerHostConfig.default.js ModifiedM packages/shared/__tests__/ReactErrorUtils-test.internal.js ModifiedM packages/shared/__tests__/describeComponentFrame-test.js ModifiedM packages/shared/checkPropTypes.js ModifiedM packages/shared/describeComponentFrame.js ModifiedM packages/shared/enqueueTask.js ModifiedM packages/shared/forks/invokeGuardedCallbackImpl.www.js ModifiedM packages/shared/forks/object-assign.inline-umd.js ModifiedM packages/shared/getComponentName.js ModifiedM packages/shared/invokeGuardedCallbackImpl.js ModifiedM packages/use-subscription/src/__tests__/useSubscription-test.internal.js ModifiedM scripts/flow/createFlowConfigs.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…