dillon1000/react

Commit

Refactor CompilerErrorDetails

- Made most static methods on CompilerError take a single options object   as an 
argument. With the exception of invariant which takes a condition and an options 
object. - Added a new `suggestions` field on CompilerErrorDetail, which we'll   
use to provide eslint suggestions - Updated eslint-plugin-react-forget to handle 
suggestions
Browse files
Lauren Tan authored 448ed2b67b7bbfe2882aadf9eb92e252a0ff4b1f Parent c3d6789
Changed paths39 files
First-parent comparison
M compiler/forget/packages/babel-plugin-react-forget/src/CompilerError.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/Entrypoint/Program.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/HIR/AssertConsistentIdentifiers.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/HIR/AssertTerminalSuccessorsExist.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/HIR/BuildHIR.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/HIR/Dominator.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/HIR/Environment.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/HIR/FindContextIdentifiers.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/HIR/HIR.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/HIR/HIRBuilder.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/HIR/MergeConsecutiveBlocks.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/HIR/ObjectShape.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/HIR/PrintHIR.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/HIR/Types.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/Inference/AnalyseFunctions.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/Inference/InferMutableLifetimes.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/Inference/InferReferenceEffects.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/Inference/InlineUseMemo.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/ReactiveScopes/BuildReactiveBlocks.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/ReactiveScopes/BuildReactiveFunction.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/ReactiveScopes/CodegenReactiveFunction.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/ReactiveScopes/DeriveMinimalDependencies.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/ReactiveScopes/InferReactiveIdentifiers.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/ReactiveScopes/PrintReactiveFunction.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/ReactiveScopes/PromoteUsedTemporaries.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/ReactiveScopes/PropagateScopeDependencies.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/ReactiveScopes/PruneNonEscapingScopes.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/ReactiveScopes/RenameVariables.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/SSA/EliminateRedundantPhi.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/SSA/EnterSSA.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/SSA/LeaveSSA.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/TypeInference/InferTypes.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/Utils/DisjointSet.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/Validation/ValidateFrozenLambdas.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/Validation/ValidateHooksUsage.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/Validation/ValidateNoRefAccesInRender.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/Validation/ValidateUnconditionalHooks.ts ModifiedM compiler/forget/packages/babel-plugin-react-forget/src/index.ts ModifiedM compiler/forget/packages/eslint-plugin-react-forget/src/rules/ReactForgetDiagnostics.ts Modified
Patch

Files changed

Rendering syntax-highlighted changes…