dillon1000/react

Commit

Deprecate findDOMNode in StrictMode (#13841)

* Deprecate findDOMNode in StrictMode

There are two scenarios. One is that we pass a component instance that is
already in strict mode or the node that we find is in strict mode if
an outer component renders into strict mode.

I use a separate method findHostInstanceWithWarning for this so that
a) I can pass the method name (findDOMNode/findNodeHandle).
b) Can ignore this warning in React Native mixins/NativeComponent that use this helper.

I don't want to expose the fiber to the renderers themselves.
Browse files
Changed paths9 files
First-parent comparison
M packages/react-dom/src/__tests__/findDOMNode-test.js ModifiedM packages/react-dom/src/client/ReactDOM.js ModifiedM packages/react-native-renderer/src/ReactFabric.js ModifiedM packages/react-native-renderer/src/ReactNativeRenderer.js ModifiedM packages/react-native-renderer/src/__tests__/ReactFabric-test.internal.js ModifiedM packages/react-native-renderer/src/__tests__/ReactNativeMount-test.internal.js ModifiedM packages/react-noop-renderer/src/createReactNoop.js ModifiedM packages/react-reconciler/src/ReactFiberReconciler.js ModifiedM packages/react-reconciler/src/__tests__/ReactIncrementalReflection-test.internal.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…