dillon1000/react

Commit

Resolve host configs at build time (#12792)

* Extract base Jest config

This makes it easier to change the source config without affecting the build test config.

* Statically import the host config

This changes react-reconciler to import HostConfig instead of getting it through a function argument.

Rather than start with packages like ReactDOM that want to inline it, I started with React Noop and ensured that *custom* renderers using react-reconciler package still work. To do this, I'm making HostConfig module in the reconciler look at a global variable by default (which, in case of the react-reconciler npm package, ends up being the host config argument in the top-level scope).

This is still very broken.

* Add scaffolding for importing an inlined renderer

* Fix the build

* ES exports for renderer methods

* ES modules for host configs

* Remove closures from the reconciler

* Check each renderer's config with Flow

* Fix uncovered Flow issue

We know nextHydratableInstance doesn't get mutated inside this function, but Flow doesn't so it thinks it may be null.
Help Flow.

* Prettier

* Get rid of enable*Reconciler flags

They are not as useful anymore because for almost all cases (except third party renderers) we *know* whether it supports mutation or persistence.

This refactoring means react-reconciler and react-reconciler/persistent third-party packages now ship the same thing.
Not ideal, but this seems worth how simpler the code becomes. We can later look into addressing it by having a single toggle instead.

* Prettier again

* Fix Flow config creation issue

* Fix imprecise Flow typing

* Revert accidental changes
Browse files
Changed paths76 files
First-parent comparison
M packages/react-art/src/ReactART.js ModifiedM packages/react-art/src/ReactARTHostConfig.js ModifiedM packages/react-art/src/__tests__/ReactART-test.js ModifiedM packages/react-dom/src/client/ReactDOM.js ModifiedM packages/react-dom/src/client/ReactDOMHostConfig.js ModifiedM packages/react-native-renderer/src/ReactFabric.js ModifiedM packages/react-native-renderer/src/ReactFabricHostConfig.js ModifiedD packages/react-native-renderer/src/ReactFabricRenderer.js DeletedM packages/react-native-renderer/src/ReactNativeFrameScheduling.js ModifiedM packages/react-native-renderer/src/ReactNativeHostConfig.js ModifiedM packages/react-native-renderer/src/ReactNativeRenderer.js ModifiedM packages/react-noop-renderer/src/ReactNoop.js ModifiedM packages/react-noop-renderer/src/ReactNoopPersistent.js ModifiedM packages/react-noop-renderer/src/createReactNoop.js ModifiedM packages/react-reconciler/index.js ModifiedA packages/react-reconciler/inline-typed.js AddedA packages/react-reconciler/inline.art.js AddedA packages/react-reconciler/inline.dom.js AddedA packages/react-reconciler/inline.fabric.js AddedA packages/react-reconciler/inline.native.js AddedA packages/react-reconciler/inline.test.js AddedM packages/react-reconciler/persistent.js ModifiedM packages/react-reconciler/src/ReactFiberBeginWork.js ModifiedM packages/react-reconciler/src/ReactFiberClassComponent.js ModifiedM packages/react-reconciler/src/ReactFiberCommitWork.js ModifiedM packages/react-reconciler/src/ReactFiberCompleteWork.js ModifiedM packages/react-reconciler/src/ReactFiberContext.js ModifiedA packages/react-reconciler/src/ReactFiberHostConfig.js AddedM packages/react-reconciler/src/ReactFiberHostContext.js ModifiedM packages/react-reconciler/src/ReactFiberHydrationContext.js ModifiedM packages/react-reconciler/src/ReactFiberNewContext.js ModifiedM packages/react-reconciler/src/ReactFiberReconciler.js ModifiedM packages/react-reconciler/src/ReactFiberScheduler.js ModifiedM packages/react-reconciler/src/ReactFiberStack.js ModifiedM packages/react-reconciler/src/ReactFiberUnwindWork.js ModifiedM packages/react-reconciler/src/ReactProfilerTimer.js ModifiedM packages/react-reconciler/src/__tests__/ReactFiberHostContext-test.js ModifiedR packages/react-reconciler/src/__tests__/ReactPersistent-test.internal.js →packages/react-reconciler/src/__tests__/ReactPersistent-test.js RenamedA packages/react-reconciler/src/forks/ReactFiberHostConfig.art.js AddedA packages/react-reconciler/src/forks/ReactFiberHostConfig.custom.js AddedA packages/react-reconciler/src/forks/ReactFiberHostConfig.dom.js AddedA packages/react-reconciler/src/forks/ReactFiberHostConfig.fabric.js AddedA packages/react-reconciler/src/forks/ReactFiberHostConfig.native.js AddedA packages/react-reconciler/src/forks/ReactFiberHostConfig.test.js AddedM packages/react-scheduler/src/ReactScheduler.js ModifiedM packages/react-test-renderer/src/ReactTestHostConfig.js ModifiedM packages/react-test-renderer/src/ReactTestRenderer.js ModifiedM packages/react-test-renderer/src/ReactTestRendererScheduling.js ModifiedA packages/shared/HostConfigWithNoHydration.js AddedA packages/shared/HostConfigWithNoMutation.js AddedA packages/shared/HostConfigWithNoPersistence.js AddedM packages/shared/ReactFeatureFlags.js ModifiedM packages/shared/forks/ReactFeatureFlags.native-fabric-fb.js ModifiedM packages/shared/forks/ReactFeatureFlags.native-fabric-oss.js ModifiedM packages/shared/forks/ReactFeatureFlags.native-fb.js ModifiedM packages/shared/forks/ReactFeatureFlags.native-oss.js ModifiedM packages/shared/forks/ReactFeatureFlags.persistent.js ModifiedM packages/shared/forks/ReactFeatureFlags.test-renderer.js ModifiedM packages/shared/forks/ReactFeatureFlags.www.js ModifiedM scripts/flow/config/flowconfig ModifiedM scripts/flow/createFlowConfigs.js ModifiedM scripts/flow/runFlow.js ModifiedD scripts/flow/typedRenderers.js DeletedA scripts/jest/config.base.js AddedM scripts/jest/config.build.js ModifiedM scripts/jest/config.source.js ModifiedM scripts/jest/setupEnvironment.js ModifiedA scripts/jest/setupHostConfigs.js AddedM scripts/rollup/build.js ModifiedM scripts/rollup/bundles.js ModifiedM scripts/rollup/forks.js ModifiedM scripts/rollup/modules.js ModifiedM scripts/rollup/wrappers.js ModifiedA scripts/shared/inlinedHostConfigs.js AddedM scripts/tasks/flow-ci.js ModifiedM scripts/tasks/flow.js Modified
Patch

Files changed

Rendering syntax-highlighted changes…