{"commit":{"revision":"47de0a8ce646641048b1195c9affbcdb2e827e3b","shortRevision":"47de0a8ce6","authorEmail":"balpert@fb.com","authoredAt":"2015-09-27T14:25:31-07:00","subject":"Add unit test to ensure DOM mutations are instrumented","authorName":"Ben Alpert"},"files":[{"path":"src\/test\/__tests__\/ReactDefaultPerf-test.js","status":"A"}],"body":"","patch":"diff --git a\/src\/test\/__tests__\/ReactDefaultPerf-test.js b\/src\/test\/__tests__\/ReactDefaultPerf-test.js\nnew file mode 100644\nindex 0000000000..b2a0e50572\n--- \/dev\/null\n+++ b\/src\/test\/__tests__\/ReactDefaultPerf-test.js\n@@ -0,0 +1,191 @@\n+\/**\n+ * Copyright 2013-2015, Facebook, Inc.\n+ * All rights reserved.\n+ *\n+ * This source code is licensed under the BSD-style license found in the\n+ * LICENSE file in the root directory of this source tree. An additional grant\n+ * of patent rights can be found in the PATENTS file in the same directory.\n+ *\n+ * @emails react-core\n+ *\/\n+\n+'use strict';\n+\n+describe('ReactDefaultPerf', function() {\n+ var React;\n+ var ReactDOM;\n+ var ReactDefaultPerf;\n+ var ReactTestUtils;\n+\n+ var App;\n+ var Box;\n+ var Div;\n+\n+ beforeEach(function() {\n+ var now = 0;\n+ require('mock-modules').setMock('performanceNow', function() {\n+ return now++;\n+ });\n+\n+ React = require('React');\n+ ReactDOM = require('ReactDOM');\n+ ReactDefaultPerf = require('ReactDefaultPerf');\n+ ReactTestUtils = require('ReactTestUtils');\n+\n+ App = React.createClass({\n+ render: function() {\n+ return

<\/div>;\n+ },\n+ });\n+\n+ Box = React.createClass({\n+ render: function() {\n+ return

<\/div>;\n+ },\n+ });\n+\n+ \/\/ ReactPerf only measures composites, so we put everything in one.\n+ Div = React.createClass({\n+ render: function() {\n+ return

;\n+ },\n+ });\n+ });\n+\n+ function measure(fn) {\n+ ReactDefaultPerf.start();\n+ fn();\n+ ReactDefaultPerf.stop();\n+ return ReactDefaultPerf.getLastMeasurements();\n+ }\n+\n+ it('should count no-op update as waste', function() {\n+ var container = document.createElement('div');\n+ ReactDOM.render(, container);\n+ var measurements = measure(() => {\n+ ReactDOM.render(, container);\n+ });\n+\n+ var summary = ReactDefaultPerf.getMeasurementsSummaryMap(measurements);\n+ expect(summary.length).toBe(2);\n+\n+ \/*eslint-disable dot-notation *\/\n+\n+ expect(summary[0]['Owner > component']).toBe(' > App');\n+ expect(summary[0]['Wasted time (ms)']).not.toBe(0);\n+ expect(summary[0]['Instances']).toBe(1);\n+\n+ expect(summary[1]['Owner > component']).toBe('App > Box');\n+ expect(summary[1]['Wasted time (ms)']).not.toBe(0);\n+ expect(summary[1]['Instances']).toBe(2);\n+\n+ \/*eslint-enable dot-notation *\/\n+ });\n+\n+ function expectNoWaste(fn) {\n+ var measurements = measure(fn);\n+ var summary = ReactDefaultPerf.getMeasurementsSummaryMap(measurements);\n+ expect(summary).toEqual([]);\n+ }\n+\n+ it('should not count initial render as waste', function() {\n+ expectNoWaste(() => {\n+ ReactTestUtils.renderIntoDocument();\n+ });\n+ });\n+\n+ it('should not count unmount as waste', function() {\n+ var container = document.createElement('div');\n+ ReactDOM.render(

hello<\/Div>, container);\n+ expectNoWaste(() => {\n+ ReactDOM.unmountComponentAtNode(container);\n+ });\n+ });\n+\n+ it('should not count content update as waste', function() {\n+ var container = document.createElement('div');\n+ ReactDOM.render(

hello<\/Div>, container);\n+ expectNoWaste(() => {\n+ ReactDOM.render(

hello world<\/Div>, container);\n+ });\n+ });\n+\n+ it('should not count child addition as waste', function() {\n+ var container = document.createElement('div');\n+ ReactDOM.render(

<\/Div>, container);\n+ expectNoWaste(() => {\n+ ReactDOM.render(

<\/Div>, container);\n+ });\n+ });\n+\n+ it('should not count child removal as waste', function() {\n+ var container = document.createElement('div');\n+ ReactDOM.render(

<\/Div>, container);\n+ expectNoWaste(() => {\n+ ReactDOM.render(

<\/Div>, container);\n+ });\n+ });\n+\n+ it('should not count property update as waste', function() {\n+ var container = document.createElement('div');\n+ ReactDOM.render(

hey<\/Div>, container);\n+ expectNoWaste(() => {\n+ ReactDOM.render(

hey<\/Div>, container);\n+ });\n+ });\n+\n+ it('should not count style update as waste', function() {\n+ var container = document.createElement('div');\n+ ReactDOM.render(

hey<\/Div>, container);\n+ expectNoWaste(() => {\n+ ReactDOM.render(

hey<\/Div>, container);\n+ });\n+ });\n+\n+ it('should not count listener update as waste', function() {\n+ var container = document.createElement('div');\n+ ReactDOM.render(

hey<\/Div>, container);\n+ expectNoWaste(() => {\n+ ReactDOM.render(

hey<\/Div>, container);\n+ });\n+ });\n+\n+ it('should not count property removal as waste', function() {\n+ var container = document.createElement('div');\n+ ReactDOM.render(

hey<\/Div>, container);\n+ expectNoWaste(() => {\n+ ReactDOM.render(

hey<\/Div>, container);\n+ });\n+ });\n+\n+ it('should not count raw HTML update as waste', function() {\n+ var container = document.createElement('div');\n+ ReactDOM.render(\n+

,\n+ container\n+ );\n+ expectNoWaste(() => {\n+ ReactDOM.render(\n+

,\n+ container\n+ );\n+ });\n+ });\n+\n+ it('should not count child reordering as waste', function() {\n+ var container = document.createElement('div');\n+ ReactDOM.render(

<\/Div>, container);\n+ expectNoWaste(() => {\n+ ReactDOM.render(

<\/Div>, container);\n+ });\n+ });\n+\n+ it('should not count text update as waste', function() {\n+ var container = document.createElement('div');\n+ ReactDOM.render(

{'hello'}{'world'}<\/Div>, container);\n+ expectNoWaste(() => {\n+ ReactDOM.render(

{'hello'}{'friend'}<\/Div>, container);\n+ });\n+ });\n+\n+});\n","parents":["b82f3ab55dd833d1288b06b34af7ad3296ba5b4d"]}

dillon1000/react

Files changed