{"parents":["e6979aa14299f8119bbe858d767e71b88c4c8f64"],"files":[{"path":"packages\/react-devtools-shared\/src\/__tests__\/profilerStore-test.js","status":"M"}],"patch":"diff --git a\/packages\/react-devtools-shared\/src\/__tests__\/profilerStore-test.js b\/packages\/react-devtools-shared\/src\/__tests__\/profilerStore-test.js\nindex e933964935..3b375c5d98 100644\n--- a\/packages\/react-devtools-shared\/src\/__tests__\/profilerStore-test.js\n+++ b\/packages\/react-devtools-shared\/src\/__tests__\/profilerStore-test.js\n@@ -9,10 +9,10 @@\n \n import type Store from 'react-devtools-shared\/src\/devtools\/store';\n \n+import {getVersionedRenderImplementation} from '.\/utils';\n+\n describe('ProfilerStore', () => {\n let React;\n- let ReactDOM;\n- let legacyRender;\n let store: Store;\n let utils;\n \n@@ -20,16 +20,17 @@ describe('ProfilerStore', () => {\n utils = require('.\/utils');\n utils.beforeEachProfiling();\n \n- legacyRender = utils.legacyRender;\n-\n store = global.store;\n store.collapseNodesByDefault = false;\n store.recordChangeDescriptions = true;\n \n React = require('react');\n- ReactDOM = require('react-dom');\n });\n \n+ const {render, unmount} = getVersionedRenderImplementation();\n+ const {render: renderOther, unmount: unmountOther} =\n+ getVersionedRenderImplementation();\n+\n \/\/ @reactVersion >= 16.9\n it('should not remove profiling data when roots are unmounted', async () => {\n const Parent = ({count}) =>\n@@ -38,19 +39,16 @@ describe('ProfilerStore', () => {\n .map((_, index) => );\n const Child = () =>

Hi!<\/div>;\n \n- const containerA = document.createElement('div');\n- const containerB = document.createElement('div');\n-\n utils.act(() => {\n- legacyRender(, containerA);\n- legacyRender(, containerB);\n+ render();\n+ renderOther();\n });\n \n utils.act(() => store.profilerStore.startProfiling());\n \n utils.act(() => {\n- legacyRender(, containerA);\n- legacyRender(, containerB);\n+ render();\n+ renderOther();\n });\n \n utils.act(() => store.profilerStore.stopProfiling());\n@@ -58,12 +56,10 @@ describe('ProfilerStore', () => {\n const rootA = store.roots[0];\n const rootB = store.roots[1];\n \n- utils.act(() => ReactDOM.unmountComponentAtNode(containerB));\n-\n+ utils.act(() => unmountOther());\n expect(store.profilerStore.getDataForRoot(rootA)).not.toBeNull();\n \n- utils.act(() => ReactDOM.unmountComponentAtNode(containerA));\n-\n+ utils.act(() => unmount());\n expect(store.profilerStore.getDataForRoot(rootB)).not.toBeNull();\n });\n \n@@ -95,14 +91,9 @@ describe('ProfilerStore', () => {\n return ;\n };\n \n- const container = document.createElement('div');\n-\n- \/\/ This element has to be in the for the event system to work.\n- document.body.appendChild(container);\n-\n \/\/ It's important that this test uses legacy sync mode.\n \/\/ The root API does not trigger this particular failing case.\n- legacyRender(, container);\n+ utils.act(() => render());\n \n utils.act(() => store.profilerStore.startProfiling());\n \n@@ -148,14 +139,9 @@ describe('ProfilerStore', () => {\n return ;\n };\n \n- const container = document.createElement('div');\n-\n- \/\/ This element has to be in the for the event system to work.\n- document.body.appendChild(container);\n-\n \/\/ It's important that this test uses legacy sync mode.\n \/\/ The root API does not trigger this particular failing case.\n- legacyRender(, container);\n+ utils.act(() => render());\n \n expect(commitCount).toBe(1);\n commitCount = 0;\n@@ -164,10 +150,10 @@ describe('ProfilerStore', () => {\n \n \/\/ Focus and blur.\n const target = inputRef.current;\n- target.focus();\n- target.blur();\n- target.focus();\n- target.blur();\n+ utils.act(() => target.focus());\n+ utils.act(() => target.blur());\n+ utils.act(() => target.focus());\n+ utils.act(() => target.blur());\n expect(commitCount).toBe(1);\n \n utils.act(() => store.profilerStore.stopProfiling());\n@@ -204,14 +190,9 @@ describe('ProfilerStore', () => {\n return state.hasOwnProperty;\n };\n \n- const container = document.createElement('div');\n-\n- \/\/ This element has to be in the for the event system to work.\n- document.body.appendChild(container);\n-\n \/\/ It's important that this test uses legacy sync mode.\n \/\/ The root API does not trigger this particular failing case.\n- legacyRender(, container);\n+ utils.act(() => render());\n \n utils.act(() => store.profilerStore.startProfiling());\n utils.act(() =>\n@@ -243,9 +224,7 @@ describe('ProfilerStore', () => {\n );\n };\n \n- const container = document.createElement('div');\n-\n- utils.act(() => legacyRender(, container));\n+ utils.act(() => render());\n utils.act(() => store.profilerStore.startProfiling());\n });\n });\n","commit":{"authorName":"Ruslan Lesiutin","authorEmail":"rdlesyutin@gmail.com","revision":"49d89b149746094c18da7f24c42b906aceb4e040","subject":"chore: use versioned render in profilerStore test (#28238)","shortRevision":"49d89b1497","authoredAt":"2024-02-05T17:20:05+00:00"},"body":""}

dillon1000/react

Files changed