dillon1000/react

Commit

[hir] Check for globals while lowering UpdateExpression

lowerIdentifierForAssignment does extra checks such as checking if globals are 
lvalues. 

UpdateExpression lowers into an assignment and previously we missed out on such 
checks.
Browse files
Sathya Gunasekaran authored 4a8b36b8b12d4df5aa930c7adeaafc66d924cd3b Parent 8eca031
Changed paths4 files
First-parent comparison
M compiler/forget/packages/babel-plugin-react-forget/src/HIR/BuildHIR.ts ModifiedA compiler/forget/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.mutate-global-increment-op-invalid-react.expect.md AddedR compiler/forget/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/mutate-global-increment-op-invalid-react.js →compiler/forget/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.mutate-global-increment-op-invalid-react.js RenamedD compiler/forget/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/mutate-global-increment-op-invalid-react.expect.md Deleted
Patch

Files changed

Rendering syntax-highlighted changes…