dillon1000/react

Commit

Convert current build system to Rollup and adopt flat bundles (#9327)

* WIP

* fbjs support

* WIP

* dev/prod mode WIP

* More WIP

* builds a cjs bundle

* adding forwarding modules

* more progress on forwarding modules and FB config

* improved how certain modules get inlined for fb and cjs

* more forwarding modules

* added comments to the module aliasing code

* made ReactPerf and ReactTestUtils bundle again

* Use -core suffix for all bundles

This makes it easier to override things in www.

* Add a lazy shim for ReactPerf

This prevents a circular dependency between ReactGKJSModule and ReactDOM

* Fix forwarding module for ReactCurrentOwner

* Revert "Add a lazy shim for ReactPerf"

This reverts commit 723b402c07116a70ce8ff1e43a1f4d92052e8f43.

* Rename -core suffix to -fb for clarity

* Change forwarding modules to import from -fb

This is another, more direct fix for ReactPerf circular dependency

* should fix fb and cjs bundles for ReactCurrentOwner

* added provides module for ReactCurrentOwner

* should improve console output

* fixed typo with argument passing on functon call

* Revert "should improve console output"

This breaks the FB bundles.

This reverts commit 65f11ee64f678c387cb3cfef9a8b28b89a6272b9.

* Work around internal FB transform require() issue

* moved  ReactInstanceMap out of React and into ReactDOM and ReactDOMFiber

* Expose more internal modules to www

* Add missing modules to Stack ReactDOM to fix UFI

* Fix onlyChild module

* improved the build tool

* Add a rollup npm script

* Rename ReactDOM-fb to ReactDOMStack-fb

* Fix circular dependencies now that ReactDOM-fb is a GK switch

* Revert "Work around internal FB transform require() issue"

This reverts commit 0a50b6a90bffc59f8f5416ef36000b5e3a44d253.

* Bump rollup-plugin-commonjs to include a fix for rollup/rollup-plugin-commonjs#176

* Add more forwarding modules that are used on www

* Add even more forwarding modules that are used on www

* Add DOMProperty to hidden exports

* Externalize feature flags

This lets www specify them dynamically.

* Remove forwarding modules with implementations

Instead I'm adding them to react-fb in my diff.

* Add all injection necessary for error logging

* Add missing forwarding module (oops)

* Add ReactART builds

* Add ReactDOMServer bundle

* Fix UMD build of ReactDOMFiber

* Work in progress: start adding ReactNative bundle

* tidied up the options for bundles, so they can define what types they output and exclude

* Add a working RN build

* further improved and tidied up build process

* improved how bundles are built by exposing externals and making the process less "magical", also tidied up code and added more comments

* better handling of bundling ReactCurrentOwner and accessing it from renderer modules

* added NODE_DEV and NODE_PROD

* added NPM package creation and copying into build chain

* Improved UMD bundles, added better fixture testing and doc plus prod builds

* updated internal modules (WIP)

* removed all react/lib/* dependencies from appearing in bundles created on build

* added react-test-renderer bundles

* renamed bundles and paths

* fixed fixture path changes

* added extract-errors support

* added extractErrors warning

* moved shims to shims directory in rollup scripts

* changed pathing to use build rather than build/rollup

* updated release doc to reflect some rollup changes

* Updated ReactNative findNodeHandle() to handle number case (#9238)

* Add dynamic injection to ReactErrorUtils (#9246)

* Fix ReactErrorUtils injection (#9247)

* Fix Haste name

* Move files around

* More descriptive filenames

* Add missing ReactErrorUtils shim

* Tweak reactComponentExpect to make it standalone-ish in www

* Unflowify shims

* facebook-www shims now get copied over correctly to build

* removed unnecessary resolve

* building facebook-www/build is now all sync to prevent IO issues plus handles extra facebook-www src assets

* removed react-native-renderer package and made build make a react-native build dir instead

* 😭😭😭

* Add more SSR unit tests for elements and children. (#9221)

* Adding more SSR unit tests for elements and children.

* Some of my SSR tests were testing for react-text and react-empty elements that no longer exist in Fiber. Fixed the tests so that they expect correct markup in Fiber.

* Tweaked some test names after @gaearon review comment https://github.com/facebook/react/pull/9221#discussion_r107045673 . Also realized that one of the tests was essentially a direct copy of another, so deleted it.

* Responding to code review https://github.com/facebook/react/pull/9221#pullrequestreview-28996315 . Thanks @spicyj!

* ReactElementValidator uses temporary ReactNative View propTypes getter (#9256)

* Updating packages for 16.0.0-alpha.6 release

* Revert "😭😭😭"

This reverts commit 7dba33b2cfc67246881f6d57633a80e628ea05ec.

* Work around Jest issue with CurrentOwner shared state in www

* updated error codes

* splits FB into FB_DEV and FB_PROD

* Remove deps on specific builds from shims

* should no longer mangle FB_PROD output

* Added init() dev block to ReactTestUtils

* added shims for DEV only code so it does not get included in prod bundles

* added a __DEV__ wrapping code to FB_DEV

* added __DEV__ flag behind a footer/header

* Use right haste names

* keeps comments in prod

* added external babel helpers plugin

* fixed fixtures and updated cjs/umd paths

* Fixes Jest so it run tests correctly

* fixed an issue with stubbed modules not properly being replaced due to greedy replacement

* added a WIP solution for ReactCurrentOwner on FB DEV

* adds a FB_TEST bundle

* allows both ReactCurrentOwner and react/lib/ReactCurrentOwner

* adds -test to provides module name

* Remove TEST env

* Ensure requires stay at the top

* added basic mangle support (disbaled by default)

* per bundle property mangling added

* moved around plugin order to try and fix deadcode requires as per https://github.com/rollup/rollup/issues/855

* Fix flow issues

* removed gulp and grunt and moved tasks to standalone node script

* configured circleci to use new paths

* Fix lint

* removed gulp-extract-errors

* added test_build.sh back in

* added missing newline to flow.js

* fixed test coverage command

* changed permissions on test_build.sh

* fixed test_html_generations.sh

* temp removed html render test

* removed the warning output from test_build, the build should do this instead

* fixed test_build

* fixed broken npm script

* Remove unused ViewportMetrics shim

* better error output

* updated circleci to node 7 for async/await

* Fixes

* removed coverage test from circleci run

* circleci run tets

* removed build from circlci

* made a dedicated jest script in a new process

* moved order around of circlci tasks

* changing path to jest in more circleci tests

* re-enabled code coverage

* Add file header to prod bundles

* Remove react-dom/server.js (WIP: decide on the plan)

* Only UMD bundles need version header

* Merge with master

* disabled const evaluation by uglify for <script></script> string literal

* deal with ART modules for UMD bundles

* improved how bundle output gets printed

* fixed filesize difference reporting

* added filesize dep

* Update yarn lockfile for some reason

* now compares against the last run branch built on

* added react-dom-server

* removed un-needed comment

* results only get saved on full builds

* moved the rollup sized plugin into a plugins directory

* added a missing commonjs()

* fixed missing ignore

* Hack around to fix RN bundle

* Partially fix RN bundles

* added react-art bundle and a fixture for it

* Point UMD bundle to Fiber and add EventPluginHub to exported internals

* Make it build on Node 4

* fixed eslint error with resolve being defined in outer scope

* Tweak how build results are calculated and stored

* Tweak fixtures build to work on Node 4

* Include LICENSE/PATENTS and fix up package.json files

* Add Node bundle for react-test-renderer

* Revert "Hack around to fix RN bundle"

We'll do this later.

This reverts commit 59445a625962d7be4c7c3e98defc8a31f8761ec1.

* Revert more RN changes

We'll do them separately later

* Revert more unintentional changes

* Revert changes to error codes

* Add accidentally deleted RN externals

* added RN_DEV/RN_PROD bundles

* fixed typo where RN_DEV and RN_PROD were the wrong way around

* Delete/ignore fixture build outputs

* Format scripts/ with Prettier

* tidied up the Rollup build process and split functions into various different files to improve readability

* Copy folder before files

* updated yarn.lock

* updated results and yarn dependencies to the latest versions
Browse files
Changed paths240 files
First-parent comparison
M .babelrc ModifiedM .flowconfig ModifiedD Gruntfile.js DeletedM circle.yml ModifiedM eslint-rules/__tests__/no-primitive-constructors-test.js ModifiedA fixtures/art/.gitignore AddedA fixtures/art/README.md AddedA fixtures/art/VectorWidget.js AddedA fixtures/art/app.js AddedA fixtures/art/index.html AddedA fixtures/art/package.json AddedA fixtures/art/webpack.config.js AddedA fixtures/art/yarn.lock AddedM fixtures/dom/.gitignore ModifiedM fixtures/dom/package.json ModifiedM fixtures/dom/public/react-loader.js ModifiedM fixtures/dom/yarn.lock ModifiedM fixtures/fiber-debugger/package.json ModifiedM fixtures/fiber-debugger/src/App.js ModifiedM fixtures/fiber-debugger/src/Fibers.js ModifiedM fixtures/fiber-debugger/yarn.lock ModifiedM fixtures/fiber-triangle/index.html ModifiedM fixtures/packaging/README.md ModifiedA fixtures/packaging/babel-standalone/dev.html AddedR fixtures/packaging/browserify/.gitignore →fixtures/packaging/browserify/dev/.gitignore RenamedR fixtures/packaging/browserify/index.html →fixtures/packaging/browserify/dev/index.html RenamedR fixtures/packaging/browserify/input.js →fixtures/packaging/browserify/dev/input.js RenamedR fixtures/packaging/browserify/package.json →fixtures/packaging/browserify/dev/package.json RenamedA fixtures/packaging/browserify/prod/.gitignore AddedR fixtures/packaging/systemjs-builder/index.html →fixtures/packaging/browserify/prod/index.html RenamedR fixtures/packaging/brunch/input.js →fixtures/packaging/browserify/prod/input.js RenamedA fixtures/packaging/browserify/prod/package.json AddedR fixtures/packaging/brunch/.gitignore →fixtures/packaging/brunch/dev/.gitignore RenamedR fixtures/packaging/brunch/app/initialize.js →fixtures/packaging/brunch/dev/app/initialize.js RenamedR fixtures/packaging/brunch/config.js →fixtures/packaging/brunch/dev/config.js RenamedR fixtures/packaging/brunch/index.html →fixtures/packaging/brunch/dev/index.html RenamedR fixtures/packaging/webpack-alias/input.js →fixtures/packaging/brunch/dev/input.js RenamedA fixtures/packaging/brunch/dev/package.json AddedD fixtures/packaging/brunch/package.json DeletedA fixtures/packaging/brunch/prod/.gitignore AddedR fixtures/packaging/webpack/input.js →fixtures/packaging/brunch/prod/app/initialize.js RenamedA fixtures/packaging/brunch/prod/config.js AddedA fixtures/packaging/brunch/prod/index.html AddedA fixtures/packaging/brunch/prod/input.js AddedA fixtures/packaging/brunch/prod/package.json AddedM fixtures/packaging/build-all.js ModifiedR fixtures/packaging/globals.html →fixtures/packaging/globals/dev.html RenamedA fixtures/packaging/globals/prod.html AddedA fixtures/packaging/index.html AddedR fixtures/packaging/requirejs.html →fixtures/packaging/requirejs/dev.html RenamedA fixtures/packaging/requirejs/prod.html AddedD fixtures/packaging/rjs/config.js DeletedR fixtures/packaging/rjs/.gitignore →fixtures/packaging/rjs/dev/.gitignore RenamedA fixtures/packaging/rjs/dev/config.js AddedR fixtures/packaging/rjs/index.html →fixtures/packaging/rjs/dev/index.html RenamedR fixtures/packaging/rjs/input.js →fixtures/packaging/rjs/dev/input.js RenamedR fixtures/packaging/rjs/package.json →fixtures/packaging/rjs/dev/package.json RenamedR fixtures/packaging/systemjs-builder/.gitignore →fixtures/packaging/rjs/prod/.gitignore RenamedA fixtures/packaging/rjs/prod/config.js AddedA fixtures/packaging/rjs/prod/index.html AddedA fixtures/packaging/rjs/prod/input.js AddedA fixtures/packaging/rjs/prod/package.json AddedD fixtures/packaging/systemjs-builder/config.js DeletedR fixtures/packaging/webpack-alias/.gitignore →fixtures/packaging/systemjs-builder/dev/.gitignore RenamedR fixtures/packaging/systemjs-builder/build.js →fixtures/packaging/systemjs-builder/dev/build.js RenamedA fixtures/packaging/systemjs-builder/dev/config.js AddedR fixtures/packaging/webpack-alias/index.html →fixtures/packaging/systemjs-builder/dev/index.html RenamedR fixtures/packaging/systemjs-builder/input.js →fixtures/packaging/systemjs-builder/dev/input.js RenamedR fixtures/packaging/systemjs-builder/package.json →fixtures/packaging/systemjs-builder/dev/package.json RenamedR fixtures/packaging/webpack/.gitignore →fixtures/packaging/systemjs-builder/prod/.gitignore RenamedA fixtures/packaging/systemjs-builder/prod/build.js AddedA fixtures/packaging/systemjs-builder/prod/config.js AddedR fixtures/packaging/webpack/index.html →fixtures/packaging/systemjs-builder/prod/index.html RenamedA fixtures/packaging/systemjs-builder/prod/input.js AddedA fixtures/packaging/systemjs-builder/prod/package.json AddedR fixtures/packaging/systemjs.html →fixtures/packaging/systemjs/dev.html RenamedA fixtures/packaging/systemjs/prod.html AddedD fixtures/packaging/webpack-alias/config.js DeletedA fixtures/packaging/webpack-alias/dev/.gitignore AddedA fixtures/packaging/webpack-alias/dev/config.js AddedA fixtures/packaging/webpack-alias/dev/index.html AddedA fixtures/packaging/webpack-alias/dev/input.js AddedR fixtures/packaging/webpack-alias/package.json →fixtures/packaging/webpack-alias/dev/package.json RenamedA fixtures/packaging/webpack-alias/prod/.gitignore AddedA fixtures/packaging/webpack-alias/prod/config.js AddedA fixtures/packaging/webpack-alias/prod/index.html AddedA fixtures/packaging/webpack-alias/prod/input.js AddedR fixtures/packaging/webpack/package.json →fixtures/packaging/webpack-alias/prod/package.json RenamedA fixtures/packaging/webpack/dev/.gitignore AddedR fixtures/packaging/webpack/config.js →fixtures/packaging/webpack/dev/config.js RenamedA fixtures/packaging/webpack/dev/index.html AddedA fixtures/packaging/webpack/dev/input.js AddedA fixtures/packaging/webpack/dev/package.json AddedA fixtures/packaging/webpack/prod/.gitignore AddedA fixtures/packaging/webpack/prod/config.js AddedA fixtures/packaging/webpack/prod/index.html AddedA fixtures/packaging/webpack/prod/input.js AddedA fixtures/packaging/webpack/prod/package.json AddedD grunt/config/browserify.js DeletedD grunt/config/compare_size.js DeletedD grunt/config/npm.js DeletedD grunt/data/header-template-short.txt DeletedD grunt/tasks/browserify.js DeletedD grunt/tasks/jest.js DeletedD grunt/tasks/npm-react-dom.js DeletedD grunt/tasks/npm-react-native.js DeletedD grunt/tasks/npm-react-noop.js DeletedD grunt/tasks/npm-react-test.js DeletedD grunt/tasks/npm-react.js DeletedD grunt/tasks/npm.js DeletedD grunt/tasks/release.js DeletedD gulp/tasks/eslint.js DeletedD gulp/tasks/flow.js DeletedD gulp/tasks/version-check.js DeletedD gulpfile.js DeletedM package.json ModifiedA packages/react-art/README.md AddedA packages/react-art/index.js AddedA packages/react-art/package.json AddedM packages/react-dom/index.js ModifiedM packages/react-dom/package.json ModifiedM packages/react-dom/server.js ModifiedD packages/react-native-renderer/README.md DeletedD packages/react-native-renderer/index.js DeletedD packages/react-native-renderer/package.json DeletedM packages/react-noop-renderer/index.js ModifiedM packages/react-noop-renderer/package.json ModifiedM packages/react-test-renderer/index.js ModifiedM packages/react-test-renderer/package.json ModifiedA packages/react/index.js AddedM packages/react/package.json ModifiedD packages/react/react.js DeletedM scripts/babel/transform-object-assign-require.js ModifiedA scripts/circleci/build.sh AddedM scripts/circleci/test_coverage.sh ModifiedM scripts/circleci/test_entry_point.sh ModifiedD scripts/circleci/test_extract_errors.sh DeletedM scripts/circleci/test_html_generation.sh ModifiedM scripts/error-codes/Types.js ModifiedM scripts/error-codes/__tests__/dev-expression-with-codes-test.js ModifiedM scripts/error-codes/__tests__/evalToString-test.js ModifiedM scripts/error-codes/__tests__/invertObject-test.js ModifiedM scripts/error-codes/codes.json ModifiedM scripts/error-codes/dev-expression-with-codes.js ModifiedM scripts/error-codes/evalToString.js ModifiedR scripts/error-codes/gulp-extract-errors.js →scripts/error-codes/extract-errors.js RenamedM scripts/error-codes/invertObject.js ModifiedM scripts/error-codes/print-warnings.js ModifiedM scripts/facts-tracker/index.js ModifiedM scripts/jest/environment.js ModifiedM scripts/jest/preprocessor.js ModifiedM scripts/jest/setupSpecEquivalenceReporter.js ModifiedM scripts/jest/test-framework-setup.js ModifiedM scripts/jest/ts-preprocessor.js ModifiedM scripts/prettier/index.js ModifiedM scripts/release-manager/Readme.md ModifiedM scripts/release-manager/cli.js ModifiedM scripts/release-manager/commands/docs-prs.js ModifiedM scripts/release-manager/commands/init.js ModifiedM scripts/release-manager/commands/npm-check-access.js ModifiedM scripts/release-manager/commands/npm-grant-access.js ModifiedM scripts/release-manager/commands/npm-publish.js ModifiedM scripts/release-manager/commands/q.js ModifiedM scripts/release-manager/commands/stable-prs.js ModifiedM scripts/release-manager/commands/start-release.js ModifiedM scripts/release-manager/commands/utils/git.js ModifiedM scripts/release-manager/commands/utils/npm.js ModifiedM scripts/release-manager/commands/version.js ModifiedA scripts/rollup/build.js AddedA scripts/rollup/bundles.js AddedA scripts/rollup/header.js AddedA scripts/rollup/mangle.js AddedA scripts/rollup/modules.js AddedA scripts/rollup/packaging.js AddedA scripts/rollup/plugins/sizes-plugin.js AddedA scripts/rollup/results.json AddedA scripts/rollup/shims/facebook-www/DOMProperty.js AddedA scripts/rollup/shims/facebook-www/EventPluginHub.js AddedA scripts/rollup/shims/facebook-www/EventPluginUtils.js AddedA scripts/rollup/shims/facebook-www/EventPropagators.js AddedA scripts/rollup/shims/facebook-www/PooledClass.js AddedA scripts/rollup/shims/facebook-www/ReactBrowserEventEmitter.js AddedA scripts/rollup/shims/facebook-www/ReactChildren.js AddedA scripts/rollup/shims/facebook-www/ReactDOMComponentTree.js AddedA scripts/rollup/shims/facebook-www/ReactDOMInputSelection.js AddedA scripts/rollup/shims/facebook-www/ReactDOMSelection.js AddedA scripts/rollup/shims/facebook-www/ReactElement.js AddedA scripts/rollup/shims/facebook-www/ReactErrorUtils.js AddedA scripts/rollup/shims/facebook-www/ReactFiberErrorLogger.js AddedA scripts/rollup/shims/facebook-www/ReactInputSelection.js AddedA scripts/rollup/shims/facebook-www/ReactInstanceMap.js AddedA scripts/rollup/shims/facebook-www/ReactPerf.js AddedA scripts/rollup/shims/facebook-www/ReactTestUtils.js AddedA scripts/rollup/shims/facebook-www/SyntheticEvent.js AddedA scripts/rollup/shims/facebook-www/SyntheticKeyboardEvent.js AddedA scripts/rollup/shims/facebook-www/SyntheticMouseEvent.js AddedA scripts/rollup/shims/facebook-www/SyntheticUIEvent.js AddedA scripts/rollup/shims/facebook-www/adler32.js AddedA scripts/rollup/shims/facebook-www/findDOMNode.js AddedA scripts/rollup/shims/facebook-www/flattenChildren.js AddedA scripts/rollup/shims/facebook-www/getComponentName.js AddedA scripts/rollup/shims/facebook-www/getEventCharCode.js AddedA scripts/rollup/shims/facebook-www/getEventKey.js AddedA scripts/rollup/shims/facebook-www/getEventTarget.js AddedA scripts/rollup/shims/facebook-www/getVendorPrefixedEventName.js AddedA scripts/rollup/shims/facebook-www/isEventSupported.js AddedR grunt/data/header-template-extended.txt →scripts/rollup/shims/facebook-www/onlyChild.js RenamedA scripts/rollup/shims/facebook-www/renderSubtreeIntoContainer.js AddedA scripts/rollup/shims/facebook-www/setInnerHTML.js AddedA scripts/rollup/shims/facebook-www/setTextContent.js AddedA scripts/rollup/shims/react-native/NativeMethodsMixin.js AddedA scripts/rollup/shims/react-native/PooledClass.js AddedA scripts/rollup/shims/react-native/ReactDebugTool.js AddedA scripts/rollup/shims/react-native/ReactErrorUtils.js AddedA scripts/rollup/shims/react-native/ReactNativeComponentTree.js AddedA scripts/rollup/shims/react-native/ReactNativePropRegistry.js AddedA scripts/rollup/shims/react-native/ReactPerf.js AddedA scripts/rollup/shims/react-native/TouchHistoryMath.js AddedA scripts/rollup/shims/react-native/createReactNativeComponentClass.js AddedA scripts/rollup/shims/react-native/findNodeHandle.js AddedA scripts/rollup/shims/rollup/DevOnlyStubShim.js AddedA scripts/rollup/shims/rollup/ReactCheckPropTypesRollupShim.js AddedA scripts/rollup/shims/rollup/ReactComponentTreeHookRollupShim.js AddedA scripts/rollup/shims/rollup/ReactCurrentOwnerRollupShim.js AddedA scripts/rollup/stats.js AddedA scripts/tasks/eslint.js AddedA scripts/tasks/flow.js AddedA scripts/tasks/jest.js AddedA scripts/tasks/version-check.js AddedA src/fb/ReactDOMFBEntry.js AddedA src/fb/ReactDOMFiberFBEntry.js AddedA src/fb/ReactFBEntry.js AddedM src/renderers/art/ReactARTStack.js ModifiedM src/renderers/dom/shared/eventPlugins/TapEventPlugin.js ModifiedM src/renderers/noop/ReactNoop.js ModifiedM src/renderers/shared/fiber/ReactFiberErrorLogger.js ModifiedM src/shared/utils/getComponentName.js ModifiedM src/test/reactComponentExpect.js ModifiedM src/umd/ReactDOMUMDEntry.js ModifiedM yarn.lock Modified
Patch

Files changed

Rendering syntax-highlighted changes…