dillon1000/react

Commit

[compiler][patch] Patch O(n^2) traversal in validatePreserveMemo

Double checked by syncing internally and verifying the # of `visitInstruction` calls with unique `InstructionId`s.

This is a bit of an awkward pattern though. A cleaner alternative might be to override `visitValue` and store its results in a sidemap (instead of returning)

ghstack-source-id: f6797d765224fb49c7d26cd377319662830d7348
Pull Request resolved: https://github.com/facebook/react/pull/30077
Browse files
Mofei Zhang authored 4bfab0783204810cb51b9dda24464bb57777eb97 Parent 7d9861e
Changed paths4 files
First-parent comparison
M compiler/packages/babel-plugin-react-compiler/src/Validation/ValidatePreservedManualMemoization.ts ModifiedA compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/repro-slow-validate-preserve-memo.expect.md AddedA compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/repro-slow-validate-preserve-memo.ts AddedM compiler/packages/snap/src/sprout/shared-runtime.ts Modified
Patch

Files changed

Rendering syntax-highlighted changes…